Received-SPF: pass (google.com: domain of linux-kernel+bounces-16604-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 4 Jan 2024 12:48:05 +0100
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>, Rob Herring
 <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 William Zhang <william.zhang@broadcom.com>, Anand Gore
 <anand.gore@broadcom.com>, Kursad Oney <kursad.oney@broadcom.com>, Florian
 Fainelli <florian.fainelli@broadcom.com>, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?=
 <rafal@milecki.pl>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@broadcom.com>, "David S. Miller"
 <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski
 <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Andrew Lunn
 <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King
 <linux@armlinux.org.uk>, Jacek Anaszewski <jacek.anaszewski@gmail.com>,
 =?UTF-8?B?RmVybsOhbmRleg==?= Rojas <noltari@gmail.com>, Sven Schwermer
 <sven.schwermer@disruptive-technologies.com>, linux-leds@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [net-next PATCH v8 5/5] net: phy: at803x: add LED support for
 qca808x
Message-ID: <20240104124805.1b0ba142@device-28.home>
In-Reply-To: <20240104110114.2020-6-ansuelsmth@gmail.com>
References: <20240104110114.2020-1-ansuelsmth@gmail.com>
	<20240104110114.2020-6-ansuelsmth@gmail.com>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hello Christian,

On Thu,  4 Jan 2024 12:01:12 +0100
Christian Marangi <ansuelsmth@gmail.com> wrote:

> Add LED support for QCA8081 PHY.
> 
> Documentation for this LEDs PHY is very scarce even with NDA access
> to Documentation for OEMs. Only the blink pattern are documented and are
> very confusing most of the time. No documentation is present about
> forcing the LED on/off or to always blink.
> 
> Those settings were reversed by poking the regs and trying to find the
> correct bits to trigger these modes. Some bits mode are not clear and
> maybe the documentation option are not 100% correct. For the sake of LED
> support the reversed option are enough to add support for current LED
> APIs.

I have one small comment below :

> +static int qca808x_led_blink_set(struct phy_device *phydev, u8 index,
> +				 unsigned long *delay_on,
> +				 unsigned long *delay_off)
> +{
> +	int ret;
> +	u16 reg;
> +
> +	if (index > 2)
> +		return -EINVAL;
> +
> +	reg = QCA808X_MMD7_LED_FORCE_CTRL(index);
> +
> +	/* Set blink to 50% off, 50% on at 4Hz by default */
> +	ret = phy_modify_mmd(phydev, MDIO_MMD_AN, QCA808X_MMD7_LED_GLOBAL,
> +			     QCA808X_LED_BLINK_FREQ_MASK | QCA808X_LED_BLINK_DUTY_MASK,
> +			     QCA808X_LED_BLINK_FREQ_256HZ | QCA808X_LED_BLINK_DUTY_50_50);

The comment (4Hz) and the blink frequency (256Hz) don't match, is that
right ? because I see there exists a QCA808X_LED_BLINK_FREQ_4HZ
definition, shouldn't it be used ?

Thanks,

Maxime