Received-SPF: pass (google.com: domain of linux-kernel+bounces-16665-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d994e6c3-f69e-4910-b699-65cb3ab6c72b@kernel.org>
Date: Thu, 4 Jan 2024 13:56:03 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] OPP: Remove the unused argument to config_clks_t
Content-Language: en-US
From: Konrad Dybcio <konradybcio@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Bart Van Assche <bvanassche@acm.org>, Dmitry Osipenko <digetx@gmail.com>,
 Thierry Reding <thierry.reding@gmail.com>,
 "Rafael J. Wysocki" <rafael@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
 Viresh Kumar <vireshk@kernel.org>,
 Vincent Guittot <vincent.guittot@linaro.org>,
 "James E.J. Bottomley" <jejb@linux.ibm.com>,
 Jonathan Hunter <jonathanh@nvidia.com>,
 "Martin K. Petersen" <martin.petersen@oracle.com>,
 Alim Akhtar <alim.akhtar@samsung.com>, Chanwoo Choi <cw00.choi@samsung.com>,
 Kyungmin Park <kyungmin.park@samsung.com>,
 MyungJoo Ham <myungjoo.ham@samsung.com>, Nishanth Menon <nm@ti.com>,
 linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
 linux-scsi@vger.kernel.org, linux-tegra@vger.kernel.org,
 Avri Altman <avri.altman@wdc.com>, Bjorn Andersson <andersson@kernel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
References: <f24f32f1213b4b9e9ff2b4a36922f8d6e3abac51.1704278832.git.viresh.kumar@linaro.org>
 <64ee255e-9a5a-405e-b342-e91c55bd95ce@kernel.org>
In-Reply-To: <64ee255e-9a5a-405e-b342-e91c55bd95ce@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 4.01.2024 13:53, Konrad Dybcio wrote:
> 
> On 3.01.2024 11:48, Viresh Kumar wrote:
>> The OPP core needs to take care of a special case, where the OPPs aren't
>> available for a device, but in order to keep the same unified interface
>> for the driver, the same OPP core API must take care of performing a
>> simple clk_set_rate() for the device.
>>
>> This required the extra argument, but that is used only within the OPP
>> core and the drivers don't need to take care of that.
>>
>> Simplify the external API and handle it differently within the OPP core.
>>
>> This shouldn't result in any functional change.
> Hi, so this apparently breaks serial on Qualcomm platforms using
> "qcom,geni-debug-uart".. I'm seeing garbage on the console, likely
> meaning that ratesetting wasn't done.

+CC Bjorn, Dmitry

Probably also worth noting it only happens when an OPP table is present
in the device tree.

Konrad