Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7697206rdb; Thu, 4 Jan 2024 05:07:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMjeMM/xGRxU9/Wy1zOoDjo1h5/pJwhNJ7csR/YF5+VEVsCFnAzavFU6e0JfeeRfZkKYjp X-Received: by 2002:a50:9514:0:b0:556:cf25:b46c with SMTP id u20-20020a509514000000b00556cf25b46cmr363007eda.53.1704373679067; Thu, 04 Jan 2024 05:07:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704373679; cv=none; d=google.com; s=arc-20160816; b=rNAVkBjrzXFJzupImfb00C6kz8tf3Yc6ssoR4ZUKN8kvamPVJksGjc79wbqsnJCbIX q8bq7jzyEzogoG4of0bMnQjXyJaGESfdT/1njOXTPnhy9dntVLdsq9Oq1gdWlXivAO7I INhHfhdy5mZiG5Zv8BXNKrUHUPhlhMLArs2hzE5N/Htr9orrokdU5dG7hL2W+AXz39TF 0uZAEEFgkhWE7b03qr//V98j9vQK6MmjAr88RYiRsiDr73aD1LMOfAsJPA4js2gY5dla YS4fL68/ucyfE5l/sh2WAJ8/LN2pXCoRxYBqnjgyHLSRWFkiDhckOp+xNexi7BYwAOvX WYug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=y1A8fgZsiIjsazqh2xXbSQAE7toMo839MhQ2MSFa1Ik=; fh=W/EP8ggtWE3pTQFPFMgdC/0O48yhbPiS7FzeFIEUugA=; b=OfmQMg84gj8r2TffMKnRf/XNnYKC5WbKGT2uY/ZzOeHk6asRJhVWxVlioDFydmxeOp 5T9hs7xg1WB57rVIHPbL8Jr/TLgPA0/S/xDRRo7KHV6vFFVoHzRtWpbYu8I5kXdV33Pm Xie1jENfi62aSnMNRsgynO6CJKLH8ifopBBVQNsGaWZN3YT3nE17gZFbQhZWMU7UU+bm voRPi2WoytkxLajhCbm369QG/CBS/QLieoedaQRDfKZ3i37fmqv0vFppMmc9reWfU8Li tTHraHHHOjssAgNpqfktv+Oe3m8zRULzO29ntBdgbH8Xnz3pLvyntpln1tloP8XkPhY5 xFTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Y8rRXlep; spf=pass (google.com: domain of linux-kernel+bounces-16685-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16685-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id z23-20020a50cd17000000b0055410efcb5dsi13358244edi.398.2024.01.04.05.07.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 05:07:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16685-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Y8rRXlep; spf=pass (google.com: domain of linux-kernel+bounces-16685-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16685-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id CBE341F22234 for ; Thu, 4 Jan 2024 13:07:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E22B4224D6; Thu, 4 Jan 2024 13:05:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Y8rRXlep" X-Original-To: linux-kernel@vger.kernel.org Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7256121343; Thu, 4 Jan 2024 13:05:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=y1A8fgZsiIjsazqh2xXbSQAE7toMo839MhQ2MSFa1Ik=; b=Y8rRXlepBxDcgCzTA7uGpVud/D k6UiLHKLWjtAi60KxLwieZ5dGpeTkkKhx8hLP2gQ1a/2yP/23fNx52Ni9hMfIArOoaCiqHF649NrL /UrUYIc+HmCWT7z4WLOR8hICBXldkNSVsH/VEYFjoL7dni5lc4IeWVVdAcWGLZ3GPxfk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rLNPd-004LdL-03; Thu, 04 Jan 2024 14:05:29 +0100 Date: Thu, 4 Jan 2024 14:05:28 +0100 From: Andrew Lunn To: "Gan, Yi Fang" Cc: Russell King , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek =?iso-8859-1?Q?Beh=FAn?= , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Looi Hong Aun , Voon Weifeng , Song Yoong Siang , Choong Yong Liang Subject: Re: [PATCH net v3 1/1] net: phylink: Add module_exit() Message-ID: References: <20240104101255.3056090-1-yi.fang.gan@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240104101255.3056090-1-yi.fang.gan@intel.com> On Thu, Jan 04, 2024 at 06:12:55PM +0800, Gan, Yi Fang wrote: 65;7401;1c> In delete_module(), if mod->init callback is defined but mod->exit callback > is not defined, it will assume the module cannot be removed and return > EBUSY. The module_exit() is missing from current phylink module drive > causing failure while unloading it. This is still missing the explanation why this is safe. Andrew --- pw-bot: cr