Received-SPF: pass (google.com: domain of linux-kernel+bounces-16698-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 4 Jan 2024 14:20:45 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	William Zhang <william.zhang@broadcom.com>,
	Anand Gore <anand.gore@broadcom.com>,
	Kursad Oney <kursad.oney@broadcom.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	=?iso-8859-1?Q?Fern=E1ndez?= Rojas <noltari@gmail.com>,
	Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	netdev@vger.kernel.org
Subject: Re: [net-next PATCH v8 3/5] net: phy: add support for PHY LEDs
 polarity modes
Message-ID: <47f18def-d34f-4224-9de2-6e0ae7122a52@lunn.ch>
References: <20240104110114.2020-1-ansuelsmth@gmail.com>
 <20240104110114.2020-4-ansuelsmth@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240104110114.2020-4-ansuelsmth@gmail.com>

> +	if (phydev->drv->led_polarity_set) {
> +		if (of_property_read_bool(led, "active-low"))
> +			set_bit(PHY_LED_ACTIVE_LOW, &modes);
> +		if (of_property_read_bool(led, "inactive-high-impedance"))
> +			set_bit(PHY_LED_INACTIVE_HIGH_IMPEDANCE, &modes);
> +
> +		err = phydev->drv->led_polarity_set(phydev, index, modes);
> +		if (err)
> +			return err;
> +	}

I think we should return an error if asked to set the mode, but its
not implemented by the driver. Something like:

	if (of_property_read_bool(led, "active-low"))
		set_bit(PHY_LED_ACTIVE_LOW, &modes);
	if (of_property_read_bool(led, "inactive-high-impedance"))
		set_bit(PHY_LED_INACTIVE_HIGH_IMPEDANCE, &modes);

		
	if (mode)
		if (phydev->drv->led_polarity_set) {
			return -EINVAL;
		} else {
			err = phydev->drv->led_polarity_set(phydev, index, modes);
			if (err)
				return err;
		}
	}

> +	/**
> +	 * @led_polarity_set: Set the LED polarity if active low

The 'if active low' is not ouw of date, since it is used for more than
that.

> +	 * @dev: PHY device which has the LED
> +	 * @index: Which LED of the PHY device or -1
> +	 * @modes: bitmap of LED polarity modes
> +	 *
> +	 * Configure LED with all the required polarity modes in @modes
> +	 * to make it correctly turn ON or OFF.

index == -1 should be explained.

> +	 *
> +	 * Returns 0, or an error code.
> +	 */
> +	int (*led_polarity_set)(struct phy_device *dev, int index,
> +				unsigned long modes);


    Andrew

---
pw-bot: cr