Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7708080rdb; Thu, 4 Jan 2024 05:26:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6qwluBl6c7UdQX+zUQKP5bIC4Pu+MnCZGfxuNUuNdytB5reSD1LMBlb79N2hNZrCZhMx4 X-Received: by 2002:a05:6a20:5497:b0:196:a7a9:165c with SMTP id i23-20020a056a20549700b00196a7a9165cmr606460pzk.66.1704374810721; Thu, 04 Jan 2024 05:26:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704374810; cv=none; d=google.com; s=arc-20160816; b=pGgJGtJBeGFfi9y5Paszfe4GE7R0u1F4ntZ1Yhz5VtI6kCwHtfJKcbbpJLwkgpaKSG CLrWTlSz3193EPGP2DCo7ycneXUyWYynkheR7Mnp/TK94eXmAKHJnqPP6xVe/eRKAwyc 6p0vOy1v9xvfKqinmoZyEsetxogjKHPNOx63lplNwEyd72NYhLqZBPX+IN/qQUeVAS+j +UzTKUD+RD4mDbvS4gMNmbY2BG5yz1ECdYc93byBHbvjTZprDgH800p9Se5eB0limuIo 7gqh0EgfQTmRLX/NJ8i2U09L90IUfn1ee5ppvu/gpYG6qOI2fHEHWj6N+tcNHAG4lST/ Mb6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1Bga3Oc0/FfATWs4xOTtGXjtDFgHK1/H9XT5vBXq0cE=; fh=qbvL9rxVg2Dl597X+m8XJfpLyodS/eD90v3/lNJFI54=; b=l4BN59EguiJUeaITgRwRt1cFwXEvVUFuwr+NhYd5TeJ9PeFN1Bq1vQx3zpMiNJSXmn ojDMomcR9zYhLbM67v+ifKKpQxRISAje0qs5a3zpdGBs80kjGlltt35T+YuJ7vT7ND/H F89kmtU8wPgQGY8lTpK//NineMSDY3c46oM4fIRmCF3GeLiY5c2K7dNZgFyangG8Gr6C Fg2TxPIWVIilgwAy91qExqlSwizEdRdD4V0g1w7o5brFM4DHgabz7tdy+6Mp5Kh+9lqO JK5Padr4W1WuB5/ralFYgcXe1KFtF2jYZClr3pA2Klnenq6ID6o5ag4vpPHLkiU0FN3Y /byA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b="ahn/3crK"; spf=pass (google.com: domain of linux-kernel+bounces-16701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16701-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id s26-20020a056a00179a00b006d9b2675e34si18244149pfg.323.2024.01.04.05.26.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 05:26:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b="ahn/3crK"; spf=pass (google.com: domain of linux-kernel+bounces-16701-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16701-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D909AB24567 for ; Thu, 4 Jan 2024 13:26:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 42D8322337; Thu, 4 Jan 2024 13:26:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="ahn/3crK" X-Original-To: linux-kernel@vger.kernel.org Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FC5E2230B; Thu, 4 Jan 2024 13:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id B86E740E01B2; Thu, 4 Jan 2024 13:26:34 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ZqTtG1JNcLTX; Thu, 4 Jan 2024 13:26:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1704374792; bh=1Bga3Oc0/FfATWs4xOTtGXjtDFgHK1/H9XT5vBXq0cE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ahn/3crK6bA90TIXsgmAC6I23fk+n+mUEHzdiLHFWF5R1eFbbFkndV/xK0AEhLpOM m5ONnFOgbLyRce01Gj6d0TzD/MsGqieMJWM0hhHkz/t49Y7Z1zOpcQWsn12UVd4TlA JK533nXJ1zANet8Em44kke+XiE/CtkgRozU0MnQrNSCf1yjBT+M+yxJhK0mgYfIKS1 v2Vw2+lxDwhLIHt44wi56r7RQeb/oktUoH3EEg8lnSpJdCtc8dCqpm1tvngkHD+bP0 6HQTPXedQiG321pxNj+OHgbywnYOXb2F6VgGasaifJS74eCAYQ7yzxTK+Zz0LX1/Q1 RFq7oodSYfJgM33W9h9MpCuGPSX+K2jGE9Z7buELhlr0KzducieGGYxcOfht1gsUnJ cVKAIAcFJtP2dhxz9aho8nD8IwF/l283bX0io/qo1B520jEP1Wx+GnXoxajCP7LHZA sfjluUFw84ScRjvZcEr8xkcC6ygJoXmPdJi5zqquQjJdSc9cbjdXj5adlQ4R+ndYSR nwkUkjqPzzMS90d1RHzHV3bIy3aH11A6osGmutZuZT2Qm0Zz1+yxLD6Cm7C2XWEHOO UsaKyOoV1jEcPDJ+S/SiQ/+/OjTMNULy6tfpujXWnfuPvCB07hoFoLSgzfGTRbYJbD f0tW+IGJuY/BC7YoAracVf8w= Received: from zn.tnic (pd9530f8c.dip0.t-ipconnect.de [217.83.15.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 998A540E0196; Thu, 4 Jan 2024 13:26:24 +0000 (UTC) Date: Thu, 4 Jan 2024 14:26:23 +0100 From: Borislav Petkov To: Josh Poimboeuf Cc: "Kaplan, David" , Ingo Molnar , "linux-kernel@vger.kernel.org" , "linux-tip-commits@vger.kernel.org" , "Peter Zijlstra (Intel)" , "x86@kernel.org" , David Howells Subject: Re: [PATCH -v2] x86/retpoline: Ensure default return thunk isn't used at runtime Message-ID: <20240104132623.GFZZax/wyf5Y3rMX5G@fat_crate.local> References: <20231019063527.iwgyioxi2gznnshp@treble> <20231019065928.mrvhtfaya22p2uzw@treble> <20231019141514.GCZTE58qPOvcJCiBp3@fat_crate.local> <20231019143951.GEZTE/t/wECKBxMSjl@fat_crate.local> <20231019152051.4u5xwhopbdisy6zl@treble> <20231024201913.GHZTgmwf6QMkX8BGbo@fat_crate.local> <20240103184656.GEZZWroPmHLJuP6y5H@fat_crate.local> <20240104131210.GDZZauqoeKoZGpYwDd@fat_crate.local> <20240104132446.GEZZaxnrIgIyat0pqf@fat_crate.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240104132446.GEZZaxnrIgIyat0pqf@fat_crate.local> On Thu, Jan 04, 2024 at 02:24:46PM +0100, Borislav Petkov wrote: > +void __warn_thunk(void) > +{ > + pr_warn_once("\n"); > + pr_warn_once("**********************************************************\n"); > + pr_warn_once("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); > + pr_warn_once("** **\n"); > + pr_warn_once("** Unpatched return thunk in use. This should not **\n"); > + pr_warn_once("** happen on a production kernel. Please report this **\n"); > + pr_warn_once("** to x86@kernel.org. **\n"); I'm not yet sure here whether this should say "upstream kernels" because otherwise we'll get a bunch of distro or whatnot downstream kernels reports where we can't really do anything about... Hmmm. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette