Received-SPF: pass (google.com: domain of linux-kernel+bounces-16714-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 4 Jan 2024 14:43:23 +0100
From: Robert Richter <rrichter@amd.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Ira Weiny <ira.weiny@intel.com>, Davidlohr Bueso <dave@stgolabs.net>,
	Jonathan Cameron <jonathan.cameron@huawei.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>, linux-cxl@vger.kernel.org,
	linux-kernel@vger.kernel.org, Fan Ni <nifan.cxl@gmail.com>,
	Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] cxl/pci: Get rid of pointer arithmetic reading CDAT table
Message-ID: <ZZa1-11632f6CckT@rric.localdomain>
References: <20231116-fix-cdat-devm-free-v1-1-b148b40707d7@intel.com>
 <ZVfIaNhiSc-yQZo5@rric.localdomain>
 <ZVfJ6Fxidvw_gz7r@rric.localdomain>
 <657bd741d2961_269bd294d@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <657bd741d2961_269bd294d@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?OYIMF377hacjKLsdaPsRmFDVFp7ljWrVnkIAp721gbxzHdbUhbXGB2WpAN8K?=
 =?us-ascii?Q?y/f4+5x9OjebU+SH1URv5WLm0j3W/6aW61rNeqzaFbopx7vjt+qhnJugr5uC?=
 =?us-ascii?Q?Dnb/AMiltJJZFYDun6DkShjEmEGW6B6StyMXhKqAU53jSU93/x0xDxWm4HDN?=
 =?us-ascii?Q?qpGz3PFwbmx8Vu1G42lGJgwn3pVcv+toXRfd8v3yKTCWRHwlmFXaMbeBiDOU?=
 =?us-ascii?Q?ouwt4N7X1GBo0+QD2BsnIhgto3iWzIjyBpQ0Tpgznzft78olsiyU4yNx24J3?=
 =?us-ascii?Q?g13o8QztjwHDG6awcqBjwwU7bZM00VRroa9UzOYX6i9QVNQ/8iDyXQqx/7PE?=
 =?us-ascii?Q?bYR6FFhKyVuht0CEgQMVM1FG/NbGjwCtS5wVQwig0u/XIx2bdhxe/NIy+A3b?=
 =?us-ascii?Q?VroTn6F6wozLNlp8fezSMougeRWdzhHuP9dKXV/XRND6+TCv3QM+Hgw1FmCa?=
 =?us-ascii?Q?XBbt9yWF5IpPtBOXWI4zngd0WWiLxaesXuwro/lqronRmRoDjKF3C39hZTdQ?=
 =?us-ascii?Q?9nN92wMpFPmV4Wi7p+ik5D9cyz885JI4KsPQn0OQs2k1qd1XiXuRZGFUEbTA?=
 =?us-ascii?Q?ou92n6OyCNRUDzbZh3cGOt359OinEKPdZNmVte8MjuYH63IvzJP6xYCsROtm?=
 =?us-ascii?Q?rJiHA1+Ch4bMF7jtR6FISG1Ox3rQNmLHPHVMImXPhxdwBiHCFevSGxO/0j6a?=
 =?us-ascii?Q?KFKVzkGyZKQEBwOzJhJJDoNyDSpDLLhKlD1dAMg9gjIxNmJ11kPwWVu6jnha?=
 =?us-ascii?Q?81PQdw9/N3blvIDqzrmgIlvgFQWEKMMAqjKU6fLRY/XVyOxXbAl8AtvFPkcb?=
 =?us-ascii?Q?CFEjGKWwkDrfMzhqHa8O4paVLFnpDYc99XFvW7XwoE2sjyfk8/T6WHBvz2+4?=
 =?us-ascii?Q?oVt4RniCTs0vMh34PNLCp48K/BxihF1ys4Zh6keDr9GXcogoX53qHOWYl/BP?=
 =?us-ascii?Q?G6N+8NektolF4XtDr9S/yeTMwwTCJZYtyWqjYYtSu/eJAXLVhKFkKDs22YwV?=
 =?us-ascii?Q?VlazFO75ExCggdDKuWLr6fuNoUnTHOy5u0Tvx4B5SbJ6utovumFyM9Cp7YCL?=
 =?us-ascii?Q?DDkE5JcHXTz8+H13G6Fxg33qmmJacTqBdC03mml1EgyQFjqhfCJ/ypr61zVg?=
 =?us-ascii?Q?hJgjW37Zo8V/3Q8M1w5DyCh+qSzcxq5oMH6spCf9I7+Ard4UPgZCplii1YKn?=
 =?us-ascii?Q?4X5x84B2eHOoW87ZS4SiW4MFc4bhr9yFRtnmYpOn4oPEpIHY1UO2IfkhjaXb?=
 =?us-ascii?Q?BtvYshzkMC9T6+TVsywJY4UD8BEOG+fhgyief8gYM1k4ifhvyp2XpWs72Gzw?=
 =?us-ascii?Q?eYwESHeabxjvqkV6q+Hr/LGU0uojbhH9o7nAxyIBfxcVrrrsNLw1XIkV732d?=
 =?us-ascii?Q?DiYOfH0Ba0u5JpVTgG/QXPiqBiRlAA5GRhtl/zPOpJ1xk2nRkmBw89SJw2E/?=
 =?us-ascii?Q?ZSw+vb6BwpXnxLM4lyvX2IqwtHN6fnkemZR8D7fFWFTqoLQx4eY/i3/CPtzt?=
 =?us-ascii?Q?Iixa+/j9aQoFwwPDMSZ/oihBhx8Smx0e+tHPt/AQHG4VnzIfiaGud6/XGQt2?=
 =?us-ascii?Q?OY9NAnpLp5qBg6/VzHRpXfRlkPcUVgBsWB9R5NTN?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 49de766a-83c3-4171-39de-08dc0d2b227e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3657.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 13:43:29.4749
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8xPbcvwf8SIZmF40hKQwAOVvneGYI9BHLKUERky7FF8bqfdZJN3/mVjDi68ltdUcfM9RtaiElB6Bs5+35S7Vbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7360

On 14.12.23 20:34:09, Dan Williams wrote:

> struct cdat_response {
>        __le32 doe_header;
>        union {
>                struct cdat_header header;
>                struct cdat_entry_header entry;
>                u8 table[];
>        };
> } __packed;
> 
> As far as I can see nothing outside of drivers/cxl/core/pci.c needs
> 'struct cdat_response', so it can stay local to this C file.

I moved that close to cdat_header and cdat_entry_header which is also
defined in cxlpci.h but only used in core/pci.c. I would like to keep
them together but we could move that completely into pci.c in a
separate patch?

Thanks,

-Robert