Received-SPF: pass (google.com: domain of linux-kernel+bounces-16716-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <tencent_E286962837EA4A84759D77A766423C3D3609@qq.com>
From: Edward Adam Davis <eadavis@qq.com>
To: syzbot+f8a023e0c6beabe2371a@syzkaller.appspotmail.com
Cc: linux-kernel@vger.kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [fs?] [trace?] BUG: unable to handle kernel paging request in tracefs_apply_options
Date: Thu,  4 Jan 2024 21:44:42 +0800
In-Reply-To: <0000000000006bf22a060e117a8d@google.com>
References: <0000000000006bf22a060e117a8d@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

please test unable to handle kernel paging request in tracefs_apply_options

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 453f5db0619e

diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
index 62524b20964e..51eacb5f4e08 100644
--- a/fs/tracefs/inode.c
+++ b/fs/tracefs/inode.c
@@ -220,9 +220,11 @@ static void set_gid(struct dentry *parent, kgid_t gid)
 		change_gid(dentry, gid);
 
 		/* If this is the events directory, update that too */
-		ti = get_tracefs(dentry->d_inode);
-		if (ti && (ti->flags & TRACEFS_EVENT_INODE))
-			eventfs_update_gid(dentry, gid);
+		if (!IS_ERR_OR_NULL(dentry->d_inode)) {
+			ti = get_tracefs(dentry->d_inode);
+			if (ti && (ti->flags & TRACEFS_EVENT_INODE))
+				eventfs_update_gid(dentry, gid);
+		}
 
 		if (!list_empty(&dentry->d_subdirs)) {
 			spin_unlock(&this_parent->d_lock);