Received-SPF: pass (google.com: domain of linux-kernel+bounces-16736-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <39fc8ce8-baab-bf53-d177-1034dfc81be9@amd.com>
Date: Thu, 4 Jan 2024 19:20:05 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [Patch v2 2/2] thunderbolt: Teardown tunnels and reset downstream
 ports created by boot firmware
Content-Language: en-US
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Sanath S <Sanath.S@amd.com>, mario.limonciello@amd.com,
 andreas.noever@gmail.com, michael.jamet@intel.com, YehezkelShB@gmail.com,
 linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231218131840.GH1074920@black.fi.intel.com>
 <0fd5c09f-1cf2-8813-a8f9-1bd856e3a298@amd.com>
 <20231219122634.GJ1074920@black.fi.intel.com>
 <0816caa4-81b5-d0f9-2305-80c7fec6abb9@amd.com>
 <20231219180424.GL1074920@black.fi.intel.com>
 <20231220125857.GA2543524@black.fi.intel.com>
 <5bfaa405-b15e-36ef-a4e0-04b93dd983b1@amd.com>
 <257c694f-5aa2-c29b-891d-3a1f480dd4a1@amd.com>
 <20231221095307.GB2543524@black.fi.intel.com>
 <6308b3e6-d935-93cb-b05d-7c9790b091d4@amd.com>
 <20240103171709.GL2543524@black.fi.intel.com>
From: Sanath S <sanaths2@amd.com>
In-Reply-To: <20240103171709.GL2543524@black.fi.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SFVuNlJEaVkxMHNOT3pkdGlwSFRTNXFDTGRMRXpBa0Uva28xdmFmaGpXWkc3?=
 =?utf-8?B?TGtxcUdBWkF3WEVsMW1YWW9WZFNYbm43Nnk1OTJydXlva0JFTGhueFVDODBa?=
 =?utf-8?B?RHFFSWFGQWQxNmhLVkNHMVlCTnYrZU16MXhpbGJ5aVV2NTgzelROb051ZzJs?=
 =?utf-8?B?UGFVRVlzL3Rva1RWTmh2OWF1TmRsZno3TWZ5dVpBM0JpS3hWZUNzTFJlQU0z?=
 =?utf-8?B?OEZ3VHh6SnRrYzdMK1l1aFJCaWlPT2lPM2Q2MzZWNWgyQkh1aU15UmtEdW02?=
 =?utf-8?B?N29DN0tZRVFhNkR4a0RBNHU3c2c1eUNpYUYwbld2dkZzRnZyTGUvL0h3WnpP?=
 =?utf-8?B?RGFlLzRGMUlTMjVWMHpXYVRYaEozaFFXYmtDUzlrV0tEMXErREtESlhzYU1y?=
 =?utf-8?B?Sk1HQ21pLzB1Q3BjMVRNekFjSHJmbnNDYnMvaEZhYisyVkZCWmRHNk42NzZh?=
 =?utf-8?B?bDFHLzRMM29tWTRvSkwxZW9JZ1pOVlpwTWhJQVVtdXZ2Z1g3Z01jNWhydytS?=
 =?utf-8?B?RGJsTWM2WWwwT2hCcmxOcC8rTlBCaWFtbVZidHJtVTJidXl6QnRDdnNWYlZV?=
 =?utf-8?B?S2NHWFlhcXBvMU9ocDR6dS94VHFSMWVsSERXUm5TS1NTNmhQZUZFQ1dmUXVV?=
 =?utf-8?B?YlpPR2NTamNSTCtOTWNOZytWOFMzQTFGdGNmUnpiRDFpcUV4VDZNdStIcGRr?=
 =?utf-8?B?Qk1kbHhRVlVwc2dOZFNwdkliYjU4c0tnRUViQWw1Sk5oQStNUmIrU0FUN1VY?=
 =?utf-8?B?WHg3QTUwSElTTXRRaERFWC9KdTNaanJIR2FadFpVcEdDOFVCWGlBOGJPMHNa?=
 =?utf-8?B?YlEyK21tQjB4UWxiaHVOZTBlazRGZEg0OHhLbTFOMCtHS1RCWEI4Z1YyZGtn?=
 =?utf-8?B?YUhxbEVLdDF2QnU5aDlxWkJ2TjBQTkt3TmQrRm9JcFpUVnVrYmlXMGloOElu?=
 =?utf-8?B?NElqRHZ4Z0RnanZNVC9hMVF0MjZrM2M5QUZ0Y3JFVDAyRTd4cW0zc29rK3N1?=
 =?utf-8?B?WHpDUktNdXpvUlF2ZDZmeUkyN1k1N28yVTYrYzg1YVArV3A3NlVvNlZZQkVr?=
 =?utf-8?B?MENvU3VkK3JBYUZFdGVNQmg0SFFJRGNiVUc3cTROWE0zZ1dOTXRhVVNqaHow?=
 =?utf-8?B?aWdHb01lME43N3M5NXF5RHJ4cVZKa29Gd3piV2w5UmYvWmV2VkhUcFhaeXFi?=
 =?utf-8?B?bnNiSDdIblkrQitMRnV1WEYrOWltcDc5MG9aOUZSZG0zR2h0OUxJb0M1MkpG?=
 =?utf-8?B?REF5VUx2QjBWbU9JbE84RE02SDAzZkNGT0JISkYrbGlzNXJqS0IrdFgrdWdJ?=
 =?utf-8?B?MldRbVJPQVVpeGgrRGQ4cnVvbjJBM1JEZE1mN0svbjRDMVgwcEVpc1FaVlJa?=
 =?utf-8?B?elYzQ21lNDVQclkwQ3BmZ1lXRVNrV1AwT3pjbkdFYWRzYWhjaGdJZ09DOFhq?=
 =?utf-8?B?S1paejhKcWlPa09ySC96VmFnVWM0b0YzMHBLNEE1aDhwMUFBMnVRQ0hhNEhU?=
 =?utf-8?B?ZHFYbjQ2Rko1Y05wZXRVSmowQS9HeFBCZjJrcTNTVk9hL3Zyd1dZODE1OHJr?=
 =?utf-8?B?VkM1b3BlVnRWa042NzZPT2RKK2NpN3RWdFZBa1J0eDZleHJSY3ZwMnV6NHBF?=
 =?utf-8?B?OGFMWm1mSVVTclJRaG1KUVJmZUtxMU1sdHVuSVE4NTJHSmZyZjVkSWZSOGNk?=
 =?utf-8?B?N1ZVcXJJa2RURUJ3R1J4Q3ZlcnlvRkh4SkxYeXhrUHNhc1JnOUg1Y0tqWGsy?=
 =?utf-8?B?WlNkQXRkUXdRam1YZDlubGFSN2FXUVIxd3FMMzd2cVRjWVptanJUQ2M1OGho?=
 =?utf-8?B?ZEk2b1VsbVdZTkk5bjlrRlVQT3plWVNvMjIzU2NmTXNUV0FyTFlFazJKVyt1?=
 =?utf-8?B?dUJZMTJ2dXRJVW1wL0I1VGt4TU1zdFFZeDRsWjhrTzNGSE9sb1dTT2Qybi9W?=
 =?utf-8?B?dkg4cDVqYThYRlhNaldRNXFob2wrR3lyS3NScUNSRUE1akdtekpGVHU1K3lB?=
 =?utf-8?B?UFllbDh4RWV1SjRWQVM1ODdkUVU0YzJMTGlrK09sYWRlWUpBRDNNQVYvTFlt?=
 =?utf-8?B?RjdXUkU2YU1xdDQ4R3RVY01Eb3Y0aWhwSElDVmZwWm9TT3lwNVlsRUJ5ZU5j?=
 =?utf-8?Q?cUwy9UuXw7EFb3SuKOHJilpFn?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 796b3d89-9735-44ce-7b38-08dc0d2c1300
X-MS-Exchange-CrossTenant-AuthSource: MW4PR12MB7016.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 13:50:13.1393
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZjL0h53cspY5/nbFjAsBfAywjaBNxjZACyD2WyPDBVEAR6D7cmUEhYpz3YA3WaLEWYmk2RrqhbsDwD6+neG72Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6539


On 1/3/2024 10:47 PM, Mika Westerberg wrote:
> On Wed, Jan 03, 2024 at 07:45:56PM +0530, Sanath S wrote:
>> On 12/21/2023 3:23 PM, Mika Westerberg wrote:
>>> On Thu, Dec 21, 2023 at 03:01:50PM +0530, Sanath S wrote:
>>>>> Sure. I'll check with these combinations.
>>>> Can you name any docks that meets these requirements ? I'll try to get
>>>> hold of it here and check.
>>> Pretty much every Titan Ridge based dock. For instance Dell WD19TB.
>>>
>>> I have some hardware here that I can use to try it out too.
>> It seems that issue is seen on Dell WD19TB too. So this fix may have to
>> extended to TBT3 as well ?
> Hm, what issue? I thought this works accross all the supported devices
> due to the DFP, no?
>
>> I'll give it a try this week and share the observation.
Got my hands on Dell WD19TB. And it works!

Here is lspci -t output with and without fix

without fix:
            +-03.1-[04-62]----00.0-[05-07]--+-02.0-[06]----00.0
            |                               \-04.0-[07]--
With fix:
            +-03.1-[04-62]----00.0-[05-62]--+-02.0-[06]----00.0
            |                               \-04.0-[07-62]--

I'll send out v3 with with splitting into 2/3 patches(Will see how it 
looks good).
Any other comments, we can take it on v3.
> Okay thanks!
>
>> Any luck from your end ?
> I did not have time to try it out yet unfortunately.