Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7721307rdb; Thu, 4 Jan 2024 05:53:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGfJm/fs5mIdh8XkFCMoFJN+NotCjE+NBtML806+G+car5Y6SYr5vMGE+Q8rLBtlBTD7m1Y X-Received: by 2002:a17:902:db0a:b0:1d4:1999:d9ac with SMTP id m10-20020a170902db0a00b001d41999d9acmr535873plx.94.1704376404007; Thu, 04 Jan 2024 05:53:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704376403; cv=none; d=google.com; s=arc-20160816; b=JZcrki7qImIXoges2nNCjHfn3eupmY/KqbKgBv1qWZxbDv5XmskWZ+Rzd3LtlHpkc2 pk9ys+WFQrY39CIyWVhSCFbNrK0p3QlrVzCp7w5JBVjJRpb/vVghw+xImzE02EtnIeHr 6yWqqEDXAgCtdL1ddBeETJnO22BDcyY6BPWyH3k4dtpuWICshQKHnDwbHAOgDP0YP/1A W6Xek3cRZyofepnGGTyjZf5G/ddCBynAg9EZpu5KGXwcAEam+sXT+3qcVs19+uVFe851 KCRDyV7CsuTELMMDSMdU5F92+ipTIqpPWLgCkC2EaEoz8V8FkC4NihFuo/w/E3aVjlJ0 i4uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=/MfPQh4H35nlx+QASSAm2zP9UXUv9F49uxYi2GkZRd8=; fh=ZoVubQCsNQOHN49KPCayoZVg1FQY9yrX5yE190npkqs=; b=nYXUBcCwp+49sRXJkarTeDr6A+JUcaaXie/K2Wnep4K/mJW85RsYibhe+Zwel5VAQu ZCeJiIsKyRVe00/F8SSCbJk7DLKte7QPSv0nJ3fFzyjf9MoOrLrx25Yi3+0kc3zzJvqk KQQlAJBa54LFOoYZzh3ZSQT6zxXKSDOB0w5d1CF9PXYbP8S9BHsVD3cAE1f4CAra0zry FA63VmJE4pYWcv7Z6CRlOYN0Us1fiG6EtTNI2+yok3rrWJ3uiVgHAmhR32kekSOHxzN0 sroNPS3LMWUNOIRwgehazWLIKx2XH9YGUxepUkoWymW+IcJfIvuVKilHUKxHb4Qgh8Ao Uf/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="C/qvNdU7"; spf=pass (google.com: domain of linux-kernel+bounces-16739-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16739-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id jb19-20020a170903259300b001d0be32b0c2si23328419plb.48.2024.01.04.05.53.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 05:53:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16739-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="C/qvNdU7"; spf=pass (google.com: domain of linux-kernel+bounces-16739-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16739-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id ABA352866B0 for ; Thu, 4 Jan 2024 13:53:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 40059224DA; Thu, 4 Jan 2024 13:53:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="C/qvNdU7" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-vk1-f181.google.com (mail-vk1-f181.google.com [209.85.221.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85E192232F for ; Thu, 4 Jan 2024 13:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-vk1-f181.google.com with SMTP id 71dfb90a1353d-4b7a3189d47so171586e0c.0 for ; Thu, 04 Jan 2024 05:53:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1704376392; x=1704981192; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/MfPQh4H35nlx+QASSAm2zP9UXUv9F49uxYi2GkZRd8=; b=C/qvNdU7d/CWH9lPt5H1mQW1JRR+8r8Qw21HzKHMmyBbhXcS1pafSAv2oBQx8KRto2 qOVX4PSihNQb0LBZ/UBJwJOtvO8rf/ucWl/xa+CcO8Uix29i8tzFPmtgI7Wtr0mnckA5 ABG+8kgiqsFTivT680o25tGkE1vxnLZQxVptaWOr6fz9CVWKCvelQi1PJE6AZAK8Rzyj IBUzbPdthTzGMH4UmkyksnbDNnB6dA3b16XmqBvqio+HKfgIa60crbnVNUO8YW0YR89Z ktwjk6R59fxnoJTzEoYlPcb/5BMNgtXtUhydsvVNaiPwLVNtOt4D3XIwrAIgt0O0XQf2 BFnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704376392; x=1704981192; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/MfPQh4H35nlx+QASSAm2zP9UXUv9F49uxYi2GkZRd8=; b=f4tzCZSn97E2zigEMRaZRManEHmsCL5Et0Ip7xtXkR4Q0NKS0hQJ1hQrb9j1wdMgsL yFQdGb8qaI5JXX8lwD5L5C13Eos/4rXTs1aUC8Wn/p6TNBUi1xivMgOPmcQgq9NFqJdq UPJy7tl15F9BLqyCFDgVOnFzN/ykIowAXg0EuxmdwriTpiVLcfjhAhxN4UxgWG+e1YRU 6rE5511fSPOvkgRahWCNuGbve+vJ5mNtkIPAhX6WmGi9IRSfrAahCp4HxBwIm12qMGHV +uM3QwUo8GEOpN2sUz0QKZKwlwZXPgmyeQ9SXK5Q1p+yi8aHGN/F8iz5WHAnmYr0lVdD 7ykQ== X-Gm-Message-State: AOJu0YwTvoYIwiQXO2ACWwFtVvLSRoKxtWT5ksK5BQ/xX8Z+ke7+wnYk GvmXF2Nf6aPKP0Qv2oRwaVE5gOdi7iCM5FUHQKlqfryKxaPd X-Received: by 2002:a1f:fc06:0:b0:4b6:bee9:3cbd with SMTP id a6-20020a1ffc06000000b004b6bee93cbdmr470548vki.5.1704376392392; Thu, 04 Jan 2024 05:53:12 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231216-rb-new-condvar-methods-v2-0-b05ab61e6d5b@google.com> <20231216-rb-new-condvar-methods-v2-2-b05ab61e6d5b@google.com> In-Reply-To: From: Alice Ryhl Date: Thu, 4 Jan 2024 14:53:01 +0100 Message-ID: Subject: Re: [PATCH v2 2/4] rust: time: add msecs to jiffies conversion To: Boqun Feng Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Tiago Lam , Thomas Gleixner , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Dec 18, 2023 at 10:07=E2=80=AFPM Boqun Feng = wrote: > > On Sat, Dec 16, 2023 at 03:31:40PM +0000, Alice Ryhl wrote: > [...] > > diff --git a/rust/kernel/time.rs b/rust/kernel/time.rs > > new file mode 100644 > > index 000000000000..23c4d1a74f68 > > --- /dev/null > > +++ b/rust/kernel/time.rs > > @@ -0,0 +1,17 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +//! Timers. > > + > > Please consider the following mod level description: > > //! Time related primitives. > //! > //! This module contains the kernel APIs related to time and timers that > //! have been ported or wrapped for usage by Rust code in the kernel. > > Otherwise it looks fine to me. > > Reviewed-by: Boqun Feng Sure, that sounds good to me. I'll update the module description and add your tag. Alice