Received-SPF: pass (google.com: domain of linux-kernel+bounces-16750-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 4 Jan 2024 14:08:38 +0000
From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
CC: Mark Brown <broonie@kernel.org>,
        Greg Kroah-Hartman
	<gregkh@linuxfoundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regmap: fix kcalloc() arguments order
Message-ID: <20240104140838.GF14858@ediswmail.ad.cirrus.com>
References: <20231220175829.533700-1-dmantipov@yandex.ru>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231220175829.533700-1-dmantipov@yandex.ru>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Wed, Dec 20, 2023 at 08:58:19PM +0300, Dmitry Antipov wrote:
> When compiling with gcc version 14.0.0 20231220 (experimental)
> and W=1, I've noticed a bunch of four similar warnings like:
> 
> drivers/base/regmap/regmap-ram.c: In function '__regmap_init_ram':
> drivers/base/regmap/regmap-ram.c:68:37: warning: 'kcalloc' sizes specified with
> 'sizeof' in the earlier argument and not in the later argument [-Wcalloc-transposed-args]
>    68 |         data->read = kcalloc(sizeof(bool), config->max_register + 1,
>       |                                     ^~~~
> 
> Since 'n' and 'size' arguments of 'kcalloc()' are multiplied to
> calculate the final size, their actual order doesn't affect the
> result and so this is not a bug. But it's still worth to fix it.
> 
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---

Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>

Thanks,
Charles