Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7773704rdb; Thu, 4 Jan 2024 07:19:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1P5s6mvPGE03kofHZWBN+tcTq6HAHpSmfK6kr+NvLXrd8y/GoYXNX3UP3QkIpa0vQBNxg X-Received: by 2002:a17:906:af11:b0:a28:c1e1:8437 with SMTP id lx17-20020a170906af1100b00a28c1e18437mr426346ejb.137.1704381574308; Thu, 04 Jan 2024 07:19:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704381574; cv=none; d=google.com; s=arc-20160816; b=y4I9SKFrCvxmR/hM/OXqb0IC8MBsIGPZnz/cwwMTCboIQse+r0EWZE/I7tRaHuS+kO 77hdBuoS0bzdBJJGUDyUO2K2q5/DHrPXKLIKeXR5BKPpW9cfbKnA/7tWoOpO2BqHc37D hPP3G62/4zA4b0dV3S+SdHIUmtQeGK2eqWLUC6mJ975TNqKF/ImBe634T4LhIzXYMV36 j1m3aVIYfFD4CxTLGCf/7mQMPk+Fr160PTVy6PGK7nzuu+Q5j329hz7j8QY3jkmqtsMA YVkagku9kRgUV9ROsJi/obqfUkBgXDF5f2pACRV8adxfSQXgXWnWwRa5Gis1FyZkuEoD 6CnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=GC60muPixeBjriui0b/NBYmBxbA4VVNVHrp1WJSoqbQ=; fh=xOOiDc9ZdmZ+fP9fHWVLaxWNknXV/dK9Z5uyzUxyQF8=; b=AUr/hi3rMcGvdWwg230spAu55KdhcvC+yj/olJTErCSPQbwsGnW0t7HNZateB9xd5w 8AfBvNfDsHRAxI+j04YhI/d1HIQ/AUnvpx7PL66Pmwu+gJXdBikTBxw3zmqHWj8bqi4h SvV9sLsHirQfYHxY332wN7EnF403YHgauME2S7Z6NdB/ErMeH41YeV+MqzYjEe36noBj CXOhuRzu0xc7M10UoQQptNteBn0gj3ZkjMD/pUt5vL8YphA9ZKtJFQhnBn8u5+Ju6MjC 996ed1D7EV+2oLluZ/EGO4yH0Ew7mn5+Ai+yp2MlC+wjdPTFqdFV/z2f4Y/vrQnI9FRO /bog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="BwQV3B/o"; spf=pass (google.com: domain of linux-kernel+bounces-16846-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16846-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id fi24-20020a1709073ad800b00a26dc88a38dsi9313877ejc.601.2024.01.04.07.19.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 07:19:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-16846-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b="BwQV3B/o"; spf=pass (google.com: domain of linux-kernel+bounces-16846-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-16846-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 13C611F22462 for ; Thu, 4 Jan 2024 15:19:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B5B0C249FE; Thu, 4 Jan 2024 15:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BwQV3B/o" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A1FC249E8 for ; Thu, 4 Jan 2024 15:19:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-203fe0e3fefso282354fac.2 for ; Thu, 04 Jan 2024 07:19:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1704381560; x=1704986360; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GC60muPixeBjriui0b/NBYmBxbA4VVNVHrp1WJSoqbQ=; b=BwQV3B/oOFf6xjdPwEz7F8Z1MNHq9OcLbciKmWMA3mMwwvL9RYFA9efgX+hVo4MZHS ORbMjonx+GtodKU0DpCbAJyKAjXggUH3R/LKIxolorXNc51/Oc8ayKM5sH1+dnKpBWEp 1XIKUmwK7zvyS4YWulkZCGA7wCYt3H/CsopqltDuacW5SkpBoHCyVOAM743ts4/f2XtU XYShoP7K2svY73xRKLcUJfgveGBJ+p1jolw2IdT/j95D31SpuVmyEaK26MeTOPSnKU6b cJaQre9aSIPTJ+mf4BYQ/ACk1LV00C/tmRjm7xKzDsPi5Xx4epFwO0ty5MzGVUynIqRF u8Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704381560; x=1704986360; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GC60muPixeBjriui0b/NBYmBxbA4VVNVHrp1WJSoqbQ=; b=DVBu4vH2+LaUv1t5m5TWG3yeXHuFEXqRRFO4qlU56yeYCN/uLzEhnEOoGShPw9wvRZ P4wKMJ/NAkm6vYAZe2geBYC1PCTAsjYrCAt+y5As8gU1/NhwX1rd3HU3PddlBlLu7l1V OniVhpUERTuQQtsDPmiI7un1w+0Ag1uKZS6mhYTvg7RAs7jDLTMSh+zLYZw62xzHkBDt 8h8JuymKOWHMYuPPMhOBSSbrdf7TW2ZUY1Uykq5h9s88V0XUY1OkUjuPsOUJwZzUdAjw GYQwkUQZ4/CANTk0ODN1IlsOaSHyrFDs9d4nz4ofKehWSnLjQKRv6tN2l5xw3+OalZcf eTYw== X-Gm-Message-State: AOJu0YzaSDWyOY7Cfd4+ekVq8kjqwS9Wgznv4R2FJOVGJgulNhm8VBlO /C3gkNJ6iZe+XpUhbK9HcZ/R4j/hjKcof7xDjww95e+MhdbH X-Received: by 2002:a05:6870:558d:b0:204:4437:57fc with SMTP id qj13-20020a056870558d00b00204443757fcmr657149oac.54.1704381560358; Thu, 04 Jan 2024 07:19:20 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231213220447.3613500-1-benno.lossin@proton.me> <20231213220447.3613500-3-benno.lossin@proton.me> In-Reply-To: <20231213220447.3613500-3-benno.lossin@proton.me> From: Alice Ryhl Date: Thu, 4 Jan 2024 16:19:09 +0100 Message-ID: Subject: Re: [PATCH v2 3/3] rust: workqueue: add `#[pin_data]` to `Work` To: Benno Lossin Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Andreas Hindborg , Martin Rodriguez Reboredo , Tejun Heo , Wedson Almeida Filho , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 13, 2023 at 11:09=E2=80=AFPM Benno Lossin wrote: > > The previous two patches made it possible to add `#[pin_data]` on > structs with default generic parameter values. > This patch makes `Work` use `#[pin_data]` and removes an invocation of > `pin_init_from_closure`. This function is intended as a low level manual > escape hatch, so it is better to rely on the safe `pin_init!` macro. > > Signed-off-by: Benno Lossin Tested-by: Alice Ryhl Reviewed-by: Alice Ryhl