Received-SPF: pass (google.com: domain of linux-kernel+bounces-16859-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <eacd168f-22dd-4e11-8907-0c79ee33f595@wanadoo.fr>
Date: Thu, 4 Jan 2024 16:36:00 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] android: removed asm-generic/errno-base.h
Content-Language: fr
To: Tanzir Hasan <tanzirh@google.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 =?UTF-8?Q?Arve_Hj=C3=B8nnev=C3=A5g?= <arve@android.com>,
 Todd Kjos <tkjos@android.com>, Martijn Coenen <maco@android.com>,
 Joel Fernandes <joel@joelfernandes.org>,
 Christian Brauner <brauner@kernel.org>, Carlos Llamas <cmllamas@google.com>,
 Suren Baghdasaryan <surenb@google.com>
Cc: linux-kernel@vger.kernel.org, Nick Desaulniers <nnn@google.com>,
 Al Viro <viro@zeniv.linux.org.uk>
References: <20231226-binderfs-v1-1-66829e92b523@google.com>
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
In-Reply-To: <20231226-binderfs-v1-1-66829e92b523@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> will still build correctly. It is an asm-generic file which should be
> avoided if possible.
> 
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
>   drivers/android/binderfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> index 1224ab7aa070..d04ff6029480 100644
> --- a/drivers/android/binderfs.c
> +++ b/drivers/android/binderfs.c
> @@ -29,7 +29,7 @@
>   #include <linux/uaccess.h>
>   #include <linux/user_namespace.h>
>   #include <linux/xarray.h>
> -#include <uapi/asm-generic/errno-base.h>
> +#include <linux/errno.h>

linux/errno.h is already included a few lines above.

CJ

>   #include <uapi/linux/android/binder.h>
>   #include <uapi/linux/android/binderfs.h>
>   
> 
> ---
> base-commit: 606d9c29e71fbf52fcfd3fcc3ad92e444c8e1d47
> change-id: 20231218-binderfs-a758e162e0ba
> 
> Best regards,