Received-SPF: pass (google.com: domain of linux-kernel+bounces-16922-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 4 Jan 2024 11:27:52 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Petr Mladek <pmladek@suse.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, =?UTF-8?B?5a2f5pWs5ae/?=
 <mengjingzi@iie.ac.cn>, john.ogness@linutronix.de,
 senozhatsky@chromium.org, keescook@chromium.org, tony.luck@intel.com,
 gpiccoli@igalia.com, linux-hardening@vger.kernel.org,
 linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@linuxfoundation.org>
Subject: Re: Suggestion for Capability Check Refinement in
 check_syslog_permissions()
Message-ID: <20240104112752.120cb566@gandalf.local.home>
In-Reply-To: <ZZZ92cjhyr_CgLRJ@alley>
References: <1ee10aa6.d064.18ccdb23971.Coremail.mengjingzi@iie.ac.cn>
	<2024010306-tweezers-skinhead-083e@gregkh>
	<ZZZ92cjhyr_CgLRJ@alley>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 4 Jan 2024 10:43:53 +0100
Petr Mladek <pmladek@suse.com> wrote:

> And CAP_SYS_ADMIN has really been deprecated last 13 years, see the
> commit ee24aebffb75a7f940cf ("cap_syslog: accept CAP_SYS_ADMIN for now").
> 
> Maybe, it is really time to remove it.

Perhaps what we should do is to remove it in a simple change that can be
easily reverted if someone complains.

The point is, Linus always says "Don't break user space", but he has even
said that we have broken user API before, but as long as no user space
breaks, it's OK. It's the "tree falls in the forest" analogy. If we break
user space API, but no user space application uses it, did it really break?

If nothing is using CAP_SYS_ADMIN why keep it?

If we remove it, and nobody complains, it means that nothing broke. If we
remove it and someone complains, then we know it's still needed and we
revert the removal just like Linus would do with any other commit that
broke user space.

-- Steve