Received-SPF: pass (google.com: domain of linux-kernel+bounces-16941-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b0963302-b498-4a81-b635-0b4faf02e83b@wolfvision.net>
Date: Thu, 4 Jan 2024 17:36:35 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/4] usb: typec: tipd: add patch update support for
 tps6598x
Content-Language: en-US
To: Roger Quadros <rogerq@kernel.org>, Jai Luthra <j-luthra@ti.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
 linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, vigneshr@ti.com,
 d-gole@ti.com, nm@ti.com
References: <20231207-tps6598x_update-v2-0-f3cfcde6d890@wolfvision.net>
 <vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws>
 <2nqiaxakx6setx4tzgddnbjadbh7miegz5p6wamsbbiyrfuq3x@un2uxajbswkg>
 <e9e8dd9f-b11b-43fc-8d76-6734dbddb540@kernel.org>
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <e9e8dd9f-b11b-43fc-8d76-6734dbddb540@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bEFHYnM3R2djVXRSWGVNNXhydUVLWEVKU2JGeUU1VmEvc1pKZEJkbzdzWTd5?=
 =?utf-8?B?MHJDcHNLRithbDM0alExVCtBV2E5L3NmMnBnRzJBbTdsZnFKSWpIT2lCbUly?=
 =?utf-8?B?aHhmUzlCSXhLbXlQZjB0ZHBYUFZNTXJCU3RjMnkwSlFHWU1LeklLVUZMWE1K?=
 =?utf-8?B?ZURpWFZHcW52dldBREYxaDUvajBldTBkS05SbzQzSlB6UHB0ZFBLVUpUbzdu?=
 =?utf-8?B?RTlVQW4zVjF3bm5hazhkSTZqeFVrSktOanRHQTV1bDJMaE5Od1lzbjFOaXdL?=
 =?utf-8?B?QS9tcHJiL2hqRG0vNWVVQk5lUjF5elIvdWVuSzgvQmFEU1Z6Ukxqa2NjWkJ4?=
 =?utf-8?B?KzQrUldRRXRxNktlS1d6RlNjcGNNc2g0WnptNmU2VE44NFZFK3hsSmRGYlE5?=
 =?utf-8?B?RGp2Q0M3NlpyMCsvMnhQZG1ETDYrUm1iWjQwdnRGbnZNV1QwVStNakFvak9E?=
 =?utf-8?B?dnFEUGdFeFRXN1hJaW4yVnArck05ODFXamQ1T0RsNWZ3Q1lUZ0xiTE1zT0py?=
 =?utf-8?B?eUdxcFdLQ1NrRnVxOXpaN0hnYkhFMnlSMGdEekJHeUtJRC8yVUNDTmc3enha?=
 =?utf-8?B?aWJsVlA2UmZ1NkhjOGd1WWo4SVdiN1Y1dlhHMnN5WGVaRXJHZEYvQkNJTWQx?=
 =?utf-8?B?TCt2NXZneGNMVU52dk9SdjBOMXlMVzJwNjEyeGx1SFdPQWhrM2t4bnc3TFhP?=
 =?utf-8?B?UTRqejRCekRZVnAxcDFsTXE0a21RWHhqSUJKOU5PRmV0cFFsZjB2U1o0dXFs?=
 =?utf-8?B?T1p1NEVjNFovOGlzcEFLaW92c210azhaajEzNWpTSzVPNDdlTWVQN2NVcWlV?=
 =?utf-8?B?MmVYcWZrcHBCMmNpMEJGS0lRK2ZQak90TUpacWNyKy9QM2lyRlA5RWdaMElW?=
 =?utf-8?B?UmV5WE56aDBCZW5EOWNQM1pwekFHNVdnSXFrVHh1dnNxTHRiRnB4SGgvM1Yv?=
 =?utf-8?B?Kzc0OGptbkF1OFAxRTN4Wk1qWnJuekR4alpWbk15ZXltblE5TWtqMXNNTTkv?=
 =?utf-8?B?ZVRkQkVUZFM1OWFuTXhVcFQ3ME5Fc1lKYWlHN0lVeHJNR0N1OTBXM1M3elAx?=
 =?utf-8?B?L29jQ0pxTnJLU3dxc20xUis5dFVJZzQ0L3Z5SnYrVk5KWGZzZm9kMytoU1Ay?=
 =?utf-8?B?RlRhRitvSTZvcnJPRXpSUFRDNE5zN05GakxqTG9rSkhvaUhtUDJYUnJpcXdC?=
 =?utf-8?B?TzVXUlQ5OExDVmU3UVlRR1ZvWFlPNDQ4WFFqQVBOcG01K3g4ZlY5S29yNEht?=
 =?utf-8?B?L0FXTlF5WXUzY2kydzUwYzRNUzJtdExXQzFYYkErdzBTVFVJekxuVzF0d2I0?=
 =?utf-8?B?MDVZRUJRSlBKZzdiR3lPMCtaaWh2N3ZtT2xyM3RqblJaSVdlQkt1bGtkZ2xS?=
 =?utf-8?B?bHlEald2dk9tSktZZitIdjRWcW5LMWxJVWlJU3J6bEd6eEhCUEhzdkJtR1Zl?=
 =?utf-8?B?UGhGeWc5ejVVVWdCaTMzREFHdTUwcG9NZ3FadGRVdU4rWDV5Mnp0SUhFYmJK?=
 =?utf-8?B?SmNPak56Z0gzK2lCRXVNSVpiOFI3L2hTN1l1Q0ZQUjFWVGpxMkZiZklQUmVh?=
 =?utf-8?B?M0lmaEJOMjFXTkhsSm00cWd2Q21sU1pFdlJVdkxvckJlU05jZUw4Z2NZelVp?=
 =?utf-8?B?dVhKUlV0bEpCbCs3eldJS0c1RmJ1ekZlaUs0MjZBbVl1WW91NzlwTFpMZytJ?=
 =?utf-8?B?c21WVThyR0hzc09jQUMxa3Q5V1ZuN0JsTitHbVkyb3c0NW8wUXRRSVpLa0hW?=
 =?utf-8?B?TjAyYytBSGxwTnY2Y3dGaytuOG44aXNjdXFpcmVSTzVtcE9VUnFkSlNDWlVS?=
 =?utf-8?B?dlQyYVBMTlhrZ2F4TzNNYzAzbnp2QjhzRWFJMDRsVFc5dGVvdGYzN1B5aWx3?=
 =?utf-8?B?SmRNZmRvTEZaRmlJT0o5SGpiYnhLcEZkL3hEY0VQVUUvWUhHUzczQVpSSHhh?=
 =?utf-8?B?RU9WN3RJSy8wMkNjOXV5V3hEVmdWcnFiRG84T1ZiWEUvRVVEQWo4TmZkekR1?=
 =?utf-8?B?dVBUYUFoRmpoMTlEYU0yS1Bsc3FsOW9LQXlxMWZhb0ljUXVIVzg2RFZGMCtu?=
 =?utf-8?B?c3czY3dMc2oxdE9XSmEvUHZkeTJpS3pHV3J1bHdnSzVlMWVDMnlVSjhGeFZO?=
 =?utf-8?B?Y3h3TVgvT1hQNHNIend0dDZ5ZHhtSS84bHZwYy9KbDBsTjlpak9vQUZnQ1hE?=
 =?utf-8?B?dUlqUHlua3REQ21TWHh1Q1l4cExUaFhQWDZaYlBzS01aa0ZCZmlMaTZVVUE5?=
 =?utf-8?Q?Z6uiTy7UzJRfWlHiYQzOB/lZsO3ureLZzE5XZU+Ubc=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f278c62-827f-4a7c-ed3c-08dc0d4352c2
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 16:36:38.3711
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t9OVL6VnsBif2H/AqSqk7qHWpkYhOQwZxFfBzOsGjcUlK9vaGGkudtARb9h0hTWPK814l8liLOQhqLXeMXNDAeBnJ8HB/Acn43AMFPyszSw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5578

On 04.01.24 17:15, Roger Quadros wrote:
> 
> 
> On 04/01/2024 17:47, Jai Luthra wrote:
>> Hi Javier,
>> The following change seems to fix boot on SK-AM62A without reverting 
>> this whole series:
>>
>> ------------------
>>
>> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
>> index a956eb976906a5..8ba2aa05db519b 100644
>> --- a/drivers/usb/typec/tipd/core.c
>> +++ b/drivers/usb/typec/tipd/core.c
>> @@ -1223,11 +1223,16 @@ static int cd321x_reset(struct tps6598x *tps)
>>  	return 0;
>>  }
>>  
>> -static int tps6598x_reset(struct tps6598x *tps)
>> +static int tps25750_reset(struct tps6598x *tps)
>>  {
>>  	return tps6598x_exec_cmd_tmo(tps, "GAID", 0, NULL, 0, NULL, 2000, 0);
>>  }
>>  
>> +static int tps6598x_reset(struct tps6598x *tps)
>> +{
>> +	return 0;
>> +}
>> +
>>  static int
>>  tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
>>  {
>> @@ -1545,7 +1550,7 @@ static const struct tipd_data tps25750_data = {
>>  	.trace_status = trace_tps25750_status,
>>  	.apply_patch = tps25750_apply_patch,
>>  	.init = tps25750_init,
>> -	.reset = tps6598x_reset,
>> +	.reset = tps25750_reset,
>>  };
>>  
>>  static const struct of_device_id tps6598x_of_match[] = {
>>
>> ------------------
>>
>> I am not an expert on this, will let you/others decide on what should be 
>> the correct way to reset TPS6598x for patching without breaking this SK.
>>
>>
> 
> This looks like a correct fix to me.
> Could you please send a proper PATCH with Fixes tag? Thanks!
> 
Hi Roger,

that fix only removes the reset function and does nothing instead, but
the reset call is identical for both devices (hence why there was a
single function for both devices). As I mentioned in my reply to Jai
Luthra, I would like to know why the reset is triggered and why that
should not happen.

Thanks and best regards,
Javier Carrasco