Received-SPF: pass (google.com: domain of linux-kernel+bounces-16954-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <7a47a61f-4356-4913-8e04-5b815c8382b2@wolfvision.net>
Date: Thu, 4 Jan 2024 17:39:59 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/4] usb: typec: tipd: add init and reset functions to
 tipd_data
Content-Language: en-US
To: Roger Quadros <rogerq@kernel.org>,
 Heikki Krogerus <heikki.krogerus@linux.intel.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231207-tps6598x_update-v2-0-f3cfcde6d890@wolfvision.net>
 <20231207-tps6598x_update-v2-1-f3cfcde6d890@wolfvision.net>
 <2a001d00-32c8-4ec3-9635-08473df6a069@kernel.org>
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <2a001d00-32c8-4ec3-9635-08473df6a069@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dDl5ZXhpVnE0dWJyRHJXVXFqVzV5aDRFWWUwRElyRCsybnFkaE5xcDNnY3pv?=
 =?utf-8?B?eEEwd0x1cmJhV2ZIMEVyRHZnMVJoLy9nMFNieGJwV2NZai9KekdleFRYR21M?=
 =?utf-8?B?NGFhZC9PVEdpNlNoWEt3SGsrVzF2MnBhZDEzM3cwcmxWQS90US9ZMFloRloz?=
 =?utf-8?B?b3hWZDJWcHFhTWlhaWZpRXAxT1lOaVNyblF5Z21PUkk5LzdPZEN6cE1pSXdY?=
 =?utf-8?B?TVloWmNIQStrWGNKcXJ3OXcvSkJud3RaOXpvRmU3cDBRaXd4VXlJSDdNRVl6?=
 =?utf-8?B?QW5RSW1CTnR1emY1SHlUamY0b0QvYmVNbHVPZVVmL3dsSmk1R2Y3YURvYWNa?=
 =?utf-8?B?OUhucDByTlVFRnE5Y3pQOXpKbHdtUzd4WEpuNkZtSGJ3Mm1qd0xYaDhNeHl6?=
 =?utf-8?B?em5LM25uQ2E0ejM5dDc4a0RoOTVsR2tPeDczSjI5cldwQnQ4blIxVUN2RnBw?=
 =?utf-8?B?UWpWWlhONk1wTnBFUks2SzJOYk1ETGI3Q2oySG9QYVM0N2g0VUxLNjdTTW4v?=
 =?utf-8?B?WkpDQ0NFWExPYW5HUjZEbzgyS2NFT09yampXM3Q4d0pBUXFVTW44bnhDWHpl?=
 =?utf-8?B?L1ZTdjUwekltd21CMS8xdGl6cTFONHVWbGVnd0gyYTdIWFF1R0FqUWFobldC?=
 =?utf-8?B?VUdqWmF4Yi84OHlybzlGOXRaVloyRG5pU3RCTzJuR2JGM0lSbmkzbWxoNS83?=
 =?utf-8?B?Z3l4UU93MERjWFhWcjIwbHQyVnVuVUx2Z3JnN1NlK0k2c1JJVFdSV29IMnVK?=
 =?utf-8?B?MnpxUDdtRW93TmJnaEVqeUNhem5FV0lZeVNPZUJwNjlTbWF0TW16VWluc1o3?=
 =?utf-8?B?dXpkOVJPazE3bldMMUNSMnpGR0ZJWG5EODZ6YlQyMSt2V3RXenE2YUVpbjhs?=
 =?utf-8?B?by8wWlE4NjVrRkZDdFQwSDdBaWZacjZZZE41Y3d3Nm5MOHp1bzR0ZHZsdit5?=
 =?utf-8?B?VFJjT2tFY1Yrb3FieTJDUWUrVGRtQ1QwOHIyRVFwL2VQdE1LNnE2YUlLR0Qw?=
 =?utf-8?B?K2ZuUlFtTmsyZE56R1RZZDRoNWZXbGNQUnFsc0xydjhPNHZ6L3BWRmQyVDdT?=
 =?utf-8?B?UGNGZmxYQi9BNXZaTmE5UWhDWm8rZ3kycWtHOVBBdUNkVHNrbzVQOXp4R2RC?=
 =?utf-8?B?ajltWmNSeHBUWGorSG9hR2ludEx2MEpubTVZWmt2bE9hZUJpV1BxVWE0T2h4?=
 =?utf-8?B?N0t5WGgxRTA3d05hWCtzM1dLSStrZ05RSGFmZFA1Zm5uUUNDaE5aSmZzT3BB?=
 =?utf-8?B?MG9qemtWYWFaRWlLZmhmNmpJVFpLWHBoVXdRN1ZEZEpVcWQycHArNEJrRHoz?=
 =?utf-8?B?ZGlrNEJad3VCNFpRQWN5NnF3UXZTclloYmFHNDF3YVN2SnpYUmJNb0xRU0tv?=
 =?utf-8?B?dHJ1VkE3Ujd1WEpPdktkSUdvbUNoRGhEMW9RTmI5eUZIZk5GTlVPUHppYllG?=
 =?utf-8?B?V0ZocjZjT2VmdDI2MCtORENoeEs3eGpPV2JNQWs0QVVYWFB6NVQ1YUg1ZTBT?=
 =?utf-8?B?ZkJtenZaamxqb21kTmd3dDJJK2s3U25rUVl0a0NObjNSV3YxU2N5bVBPbkUz?=
 =?utf-8?B?dkZwTEI3S1RhZXZiTXNQUHdpM2JtRGJNbEhPK09RSnlPRjlwckhGR1VUZTly?=
 =?utf-8?B?L2E1OVRGS3RLVXBhYjJReGNneGtKZVgybGttbEtmdWtVa1hPQUg5c2wrR0VB?=
 =?utf-8?B?dlcwYmZRUnRHTU4vWFM2R2VTNEQ2bTVFK05UK2dBeEdZVUZPaUY2bUpBMXFZ?=
 =?utf-8?B?WHUyQjhPWE0wOEsrQ3BSaU5TaUYzNWY0d2RlYlp5a3BQTFgvZlpVTU5ZN0p1?=
 =?utf-8?B?VElzMC96bncrbjRrMlNBMHlkbGFRQU1xQWFWb1VMS2s2Q1hhYjBETEtXbDZi?=
 =?utf-8?B?TzFkS3pwcSt0Mm5pM2YvZDZuNU9pNk1XTGRvZCsxbmkyZ09vT2VyT1lxLzdS?=
 =?utf-8?B?VzU5UkwySmVnMkIzN0FFeHpKb3JReTdkUnJGYlhWM2R1TTdBbHdUQmNmUGR5?=
 =?utf-8?B?UjFCRm9SQWlHSEtRT0Y1Njg0emFINTlDZlVoUWpXR1lmMHlyUXBSV2Q5REow?=
 =?utf-8?B?dEQyNExjdkRVUExLL1k3YXNPWWFsTWNxQnV1dWVlakhEY3kvc0sySkNxbzJx?=
 =?utf-8?B?MFZNcW8reVJWcnVSNGFHQmJ4K2xKdVVWMjlDa2lQYkt1VDhBcDJoczU3UWlG?=
 =?utf-8?B?dUNTcFVMM3lPMVBlUm9VMWF3a21QU1dUQmV5MVNoTVlnY0ZFY1J1UHZDRHhB?=
 =?utf-8?Q?pgYf9NWMJeCYXuL/8pAiOpmeKUZoJrcHDHS0gPgx7Y=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 90d7f1d1-051d-469a-aa12-08dc0d43cc2f
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 16:40:02.0517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x1xQrjBZPH8hzefM8nlHlzxeNuFjvshcysfyefrVxL1tOJHUpzydoPoNTxlaeQVXPa7cVckSIZ1BzlfrMRATV8zPesf0tbdKNiTn+hNkDDk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5578

On 04.01.24 17:14, Roger Quadros wrote:
>> @@ -1393,7 +1412,7 @@ static int __maybe_unused tps6598x_resume(struct device *dev)
>>  	if (ret < 0)
>>  		return ret;
>>  
>> -	if (device_is_compatible(tps->dev, "ti,tps25750") && ret == TPS_MODE_PTCH) {
>> +	if (ret == TPS_MODE_PTCH) {
> 
> Won't this function will be invoked for all variants?
> If so, why are we calling a tsp25750 specific function here?
> 
>>  		ret = tps25750_init(tps);
>>  		if (ret)
>>  			return ret;

Hi Roger,

good catch. The device-specific init function should be called instead,
as it is already done in the probe function:

  	ret =  tps->data->init(tps);
  	if (ret)
  		return ret;

I will send the fix asap.

Thanks a lot for your feedback and best regards,
Javier Carrasco