Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757082AbXLLFs3 (ORCPT ); Wed, 12 Dec 2007 00:48:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752480AbXLLFsS (ORCPT ); Wed, 12 Dec 2007 00:48:18 -0500 Received: from smtp2.linux-foundation.org ([207.189.120.14]:50835 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750820AbXLLFsR (ORCPT ); Wed, 12 Dec 2007 00:48:17 -0500 Date: Tue, 11 Dec 2007 21:46:34 -0800 From: Stephen Hemminger To: "David S. Miller" Cc: "Joonwoo Park" , , , , , Subject: [RFC] net: napi fix Message-ID: <20071211214634.4dedb274@freepuppy.rosehill> In-Reply-To: <20071211213939.122de1db@freepuppy.rosehill> References: <002901c83c73$b089b6e0$9c94fea9@jason> <20071211213939.122de1db@freepuppy.rosehill> Organization: Linux Foundation X-Mailer: Claws Mail 3.1.0 (GTK+ 2.12.1; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 779 Lines: 21 Isn't this a better fix for all drivers, rather than peppering every driver with the special case. This is how the logic worked up until 2.6.24. --- a/net/core/dev.c 2007-12-11 12:16:20.000000000 -0800 +++ b/net/core/dev.c 2007-12-11 21:43:39.000000000 -0800 @@ -2184,7 +2184,7 @@ static void net_rx_action(struct softirq have = netpoll_poll_lock(n); - weight = n->weight; + weight = min(n->weight, budget); /* This NAPI_STATE_SCHED test is for avoiding a race * with netpoll's poll_napi(). Only the entity which -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/