Received-SPF: pass (google.com: domain of linux-kernel+bounces-17028-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240104164937.424320-1-pierre.gondois@arm.com>
In-Reply-To: <20240104164937.424320-1-pierre.gondois@arm.com>
From: Marco Elver <elver@google.com>
Date: Thu, 4 Jan 2024 18:16:09 +0100
Message-ID: <CANpmjNOwqoEbmuyE_LeMmJ=x9-3CkpXqYsi6m3Gniudyj+RFzw@mail.gmail.com>
Subject: Re: [PATCH v2 0/3] list: Add hlist_count_nodes()
To: Pierre Gondois <pierre.gondois@arm.com>
Cc: linux-kernel@vger.kernel.org, 
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, =?UTF-8?B?QXJ2ZSBIasO4bm5ldsOlZw==?= <arve@android.com>, 
	Todd Kjos <tkjos@android.com>, Martijn Coenen <maco@android.com>, 
	Joel Fernandes <joel@joelfernandes.org>, Christian Brauner <brauner@kernel.org>, 
	Carlos Llamas <cmllamas@google.com>, Suren Baghdasaryan <surenb@google.com>, Coly Li <colyli@suse.de>, 
	Kent Overstreet <kent.overstreet@gmail.com>, Kees Cook <keescook@chromium.org>, 
	Jani Nikula <jani.nikula@intel.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, 
	Ingo Molnar <mingo@kernel.org>, linux-bcache@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Thu, 4 Jan 2024 at 17:50, Pierre Gondois <pierre.gondois@arm.com> wrote:
>
> v2:
> - Add usages of the function to avoid considering it as dead code.
> v1:
> - https://lore.kernel.org/all/20240103090241.164817-1-pierre.gondois@arm.com/
>
> Add a generic hlist_count_nodes() function.
>
> This function aims to be used in a private module. As suggested by
> Marco, having it used would avoid to consider it as dead code.
> Thus, add some usages of the function in two drivers.

Whether or not it's used in a private module is probably irrelevant
from an upstream perspective.

But this is a reasonable cleanup, and at the same time adds API
symmetry with the already existing list_count_nodes().

> Pierre Gondois (3):
>   list: Add hlist_count_nodes()
>   binder: Use of hlist_count_nodes()
>   bcache: Use of hlist_count_nodes()
>
>  drivers/android/binder.c  |  4 +---
>  drivers/md/bcache/sysfs.c |  8 +-------
>  include/linux/list.h      | 15 +++++++++++++++
>  3 files changed, 17 insertions(+), 10 deletions(-)

For the series:

Acked-by: Marco Elver <elver@google.com>

Thanks.