Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757348AbXLLGz5 (ORCPT ); Wed, 12 Dec 2007 01:55:57 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753670AbXLLGzu (ORCPT ); Wed, 12 Dec 2007 01:55:50 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:34817 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753513AbXLLGzt (ORCPT ); Wed, 12 Dec 2007 01:55:49 -0500 Date: Tue, 11 Dec 2007 22:55:24 -0800 From: Greg KH To: Dave Young Cc: Andrew Morton , "Huang, Ying" , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Andi Kleen , "Eric W. Biederman" , linux-kernel@vger.kernel.org Subject: Re: [PATCH -mm] x86 boot : export boot_params via sysfs Message-ID: <20071212065524.GA28963@kroah.com> References: <1197391749.17188.8.camel@caritas-dev.intel.com> <20071211184012.a84fff36.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1592 Lines: 44 On Wed, Dec 12, 2007 at 12:42:48PM +0800, Dave Young wrote: > On Dec 12, 2007 10:40 AM, Andrew Morton wrote: > > On Tue, 11 Dec 2007 16:49:09 +0000 "Huang, Ying" wrote: > > > > > This patch export the boot parameters via sysfs. This can be used for > > > debugging and kexec. > > > > > > The files added are as follow: > > > > > > /sys/kernel/boot_params/data : binary file for struct boot_params > > > /sys/kernel/boot_params/version : boot protocol version > > > > Your patch uses kobject_create_and_register() which was added in Greg's > > driver tree as of 2.6.24-rc4-mm1. > > > > However for some reason kobject_create_and_register() has magically vanished > > from Greg's current driver tree so I cannot carry this patch, sorry. > > Seems kobject_create_and_register would be replaced by > kobject_create_and_add, and the uevent handling would be separated > from original create_and_register onefunction. Yes, that is what has now changed. > wait for greg's patches or modify to use: > > kobject_init > kobject_add > kobject_uevent > > BTW, I suspect whether the uevent is really needed for boot_params object. Actually, for something as trivial as this, just use the kobject_create_and_add() and don't worry about the uevent. It should be pretty trivial. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/