Received-SPF: pass (google.com: domain of linux-kernel+bounces-17125-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Support Opensource
	<support.opensource@diasemi.com>
CC: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Input: da9063_onkey - avoid using OF-specific APIs
Thread-Topic: [PATCH] Input: da9063_onkey - avoid using OF-specific APIs
Thread-Index: AQHaM7sSPNjMGyCnK0uUxJqt/la6lLDKGx/w
Date: Thu, 4 Jan 2024 19:08:54 +0000
Message-ID:
 <TYCPR01MB11269AA2B4A9372ABF78E5EEA86672@TYCPR01MB11269.jpnprd01.prod.outlook.com>
References: <ZYOsUfKceOFXuCt5@google.com>
In-Reply-To: <ZYOsUfKceOFXuCt5@google.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Qqx6JeGVGmHdSTKjrXbSguzEjzQTOi6P43Obxdf24Q8u4Rw3BBGQgztJPyWM?=
 =?us-ascii?Q?VRbhpHR9HUjEyq3AC82vhybi5OLPaCqPWE6p+j5iTphw3zruYN0bbNB+3J3x?=
 =?us-ascii?Q?adWyOCj0zT05Guss9thOUZVTZK7z47PAeREZQA74lqZSA2ZFQOaWmuDTAxRD?=
 =?us-ascii?Q?+p1qsh4eSPeT0zONa6EfSDPbvDP6RJihjUUniBIeYy1U9A37mqODOlJ79OIn?=
 =?us-ascii?Q?b5GVtj8e1NabKvJ6mak/no+J+wxxHJdxWPMU/Rz9VPZs3Lc0BpRGLNaPFjsZ?=
 =?us-ascii?Q?cbz4q5zCKm0B0AWlP/os5s/Du1LYwVTMnznxofy6k2jxHzKfqr9URMFfVTXx?=
 =?us-ascii?Q?mY0duzhSgdyuV/VEXC20J9DY8VEnjklglSRUEP5G4IiR/sLcF1s3kQJCpwv+?=
 =?us-ascii?Q?b4Xp+zspO5Eupq2fr5xz6X8zQ0uiDA/5RN6Za3utzzMvsjnHIxH01aVh78JT?=
 =?us-ascii?Q?B8vJmEMJH080O9mqyzC8sGW5zY8M9DB1Jah1Bsf0p5E8FAzCr4a/bKbDU2dw?=
 =?us-ascii?Q?G6tzGYBi++yMEch2hphOh76ZfQVeF7JJAkM5pCW6OlWk41eLuacZXffml2QH?=
 =?us-ascii?Q?7K7uIbWlA36S6wZzZePQ4lXSgVrJ/d0bKi/N4DgQ8YEf6yX1p2IBOAqfBqDB?=
 =?us-ascii?Q?LO5nZ49miSKs5l4jwjEbtPQNz/p2olxOvfaqeVEOD5XsNGF4xv40s/m/7YXh?=
 =?us-ascii?Q?EyVOgI20zRXRu+CRQQyFh/NeHot0/TaL+JcaEWwBpN9IzEEn3NSowyvYpzL7?=
 =?us-ascii?Q?b2oNhiHA3kuKgVTje48vtnQpOdBxt4FJ7C8tdgHxTzOfdYrVgxcX0/iVgE1K?=
 =?us-ascii?Q?rEpLmB0dWnQWxJjIf6M7Yfo8stI3EeJNCmO4h/EhUCZ10JHyMaKXPLnuu5w3?=
 =?us-ascii?Q?kJDP5s6K21XxpJ0J02jPN8GTo56WUq827jYfAPiU+fNJnWowzkvGNVsAGY0i?=
 =?us-ascii?Q?2WUAYA19Sw2xqYcLop9sa5k8PF/SMSP7Nr5TMIQZVZt9bn7kry9WyjFaJw8E?=
 =?us-ascii?Q?M4W8h+/Kly00uun+vcB96xeXjVslYzhVwnNHJQmsMyLRGkiGb5eDXh7HPXYn?=
 =?us-ascii?Q?hDJHO62t3tBh+3UtTqwHHkOH3AVSVHn44v+YjTIME+3qisYT/fs76HSjUgHJ?=
 =?us-ascii?Q?B59JL0o9FZXk2QgaOWh2hLlagrQoepcwPTvXWPdOJR2Yp6oG2ssfS0tscCRF?=
 =?us-ascii?Q?GhEgOjXO3wAC1a/3m4gU1SjVKxSpG1TFVRA/0XQa5/yltg17ZpBu0JBxlrT4?=
 =?us-ascii?Q?5AOzHxe/hEIGyl4AWwQIIDLN13alwOQ1kRnPEm36rWYWvvhHHt+Q4ptIcqJF?=
 =?us-ascii?Q?nYAPEu+5bIP4gijwMFPBnZHkmWEMkRe5qkoAUQ5GupdqVvjf37v34VrE/hqI?=
 =?us-ascii?Q?2UAV4eQPHvQAyM0KuCiNpIEPtSXSsnSj5IvchMo8qgzZOp9NkEHagq9ooHpR?=
 =?us-ascii?Q?98IRYbQQ3/eCoZdZrbIKvWhJlWyECRJgIgtq7m+qHQe6J8MJ3sSzzM2riDKQ?=
 =?us-ascii?Q?dFXZQG427yRX51kJeZU1tHKj4WQJ4v2XLiz6m91dJxg5YDo8nvqolR5ifF/K?=
 =?us-ascii?Q?tgY6gfTRnWk7WlpnsSk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11269.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44d8e101-97ab-477b-79aa-08dc0d5898ab
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2024 19:08:54.8950
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ksak0os4MU1PVVzcZqXx5B11j3f7ftEBeDGPDjXJcNZO/2T5U3AMaPRCayHWuZRNh0Qtrv2vbtfYq1tQ27XoAjy16u2yq/6pU5RAALD56ow=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB8478

Hi Dmitry Torokhov,

Thanks for the patch.

> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Sent: Thursday, December 21, 2023 3:09 AM
> To: Support Opensource <support.opensource@diasemi.com>; Biju Das
> <biju.das.jz@bp.renesas.com>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] Input: da9063_onkey - avoid using OF-specific APIs
>=20
> There is nothing OF-specific in the driver, so switch from OF properties
> helpers to generic device helpers.
>=20
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

> ---
>  drivers/input/misc/da9063_onkey.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/input/misc/da9063_onkey.c
> b/drivers/input/misc/da9063_onkey.c
> index a8b7f1cd0ec2..ce499c28a7b2 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -9,11 +9,12 @@
>  #include <linux/errno.h>
>  #include <linux/input.h>
>  #include <linux/interrupt.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_wakeirq.h>
> +#include <linux/property.h>
>  #include <linux/workqueue.h>
>  #include <linux/regmap.h>
> -#include <linux/of.h>
>  #include <linux/mfd/da9063/core.h>
>  #include <linux/mfd/da9063/registers.h>  #include
> <linux/mfd/da9062/core.h> @@ -199,8 +200,8 @@ static int
> da9063_onkey_probe(struct platform_device *pdev)
>  		return dev_err_probe(&pdev->dev, -ENXIO,
>  				     "Parent regmap unavailable.\n");
>=20
> -	onkey->key_power =3D !of_property_read_bool(pdev->dev.of_node,
> -						  "dlg,disable-key-power");
> +	onkey->key_power =3D !device_property_read_bool(&pdev->dev,
> +						      "dlg,disable-key-power");
>=20
>  	onkey->input =3D devm_input_allocate_device(&pdev->dev);
>  	if (!onkey->input)
> --
> 2.43.0.195.gebba966016-goog
>=20
>=20
> --
> Dmitry