Received-SPF: pass (google.com: domain of linux-kernel+bounces-17127-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Support Opensource
	<support.opensource@diasemi.com>
CC: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] Input: da9063_onkey - avoid explicitly setting input's
 parent
Thread-Topic: [PATCH] Input: da9063_onkey - avoid explicitly setting input's
 parent
Thread-Index: AQHaM7spcaFVxQzVj0aWvnobzcBporDKG4WQ
Date: Thu, 4 Jan 2024 19:09:48 +0000
Message-ID:
 <TYCPR01MB1126942265F2B95741501A78286672@TYCPR01MB11269.jpnprd01.prod.outlook.com>
References: <ZYOseYfVgg0Ve6Zl@google.com>
In-Reply-To: <ZYOseYfVgg0Ve6Zl@google.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?nIb7pyp641aFKKhv5Z01IJsMOrBG2OBJRzJsBD3xlyvlrvjCi7PXdHbL4cCm?=
 =?us-ascii?Q?K2U9TmxA3fagoDJu6JzUqCID9v1MW2Ggw9hjHLKAf11IuY0bZabU3E+atHL7?=
 =?us-ascii?Q?O/1m6qaJoG8Q7yJzRObxevPIuhBUM/PX5i9NjRrUXC7QEuT9zmMuHZYCey8m?=
 =?us-ascii?Q?IGRcJ8BGdqbVc6+Ce8FrKSOnk2jxfpCjHWuECc6wsubgxIewjnimfU94bSBW?=
 =?us-ascii?Q?GjCa/nTGyuBFtjA5E0Gsl82gt0knJI1FN8n8NyT8kYV9c40KPlEgW/w8vA2/?=
 =?us-ascii?Q?7TlulgIYZNyELLQhmiZzptI2dhdfSDsoutHhGgMq94hthAN8WFht0aXo/eXI?=
 =?us-ascii?Q?0yry5vOKpeEw4Xk+UxOjNnutjww4+CK2xXTQMtIpuwwiMMB+09wavpSBKhA2?=
 =?us-ascii?Q?peWCTUr1VDHF49QNXrXhoNBfnh/FwQuIHZO+Hhe58vsqf6+v5USqU0Vj5yCJ?=
 =?us-ascii?Q?44B03f8LEFDAiMfwgkXIc4MR/HGtSixGlP/qzD0K4vzCSDB6uyJSU4UVJJcY?=
 =?us-ascii?Q?ZD1xrNAHdgrT5v3hITn0kvXVktCG3vOi7FCXB/IpgfCoj4S4baJdfU+V1mrL?=
 =?us-ascii?Q?r1l9kqCTGSd8wjKVhAE62J20ZPdywdkGXN6t0xDZG5gUcicygFM0Joe4jEVG?=
 =?us-ascii?Q?w6ldSYrAgzVWYlzoEAWeVtyjheCaSR66BntSCPJIDXYT8vySCyaZZwTM0fXe?=
 =?us-ascii?Q?ISqpPEA8HFIsew5+Q/60urHoaitI1qy3fnTlhZZNV8Nt4NyxFiJaYvZARTbE?=
 =?us-ascii?Q?gX4076P8LPPqE1dZbfollrQVgNW7f2rlrMqFzhxLaujmjlldykGQhgocVvSl?=
 =?us-ascii?Q?RLvt6ChLgLjyiJIYURXRgrxAlHMtEoKlUXpWjjAKsAt2dznqrorlTOxAcHkP?=
 =?us-ascii?Q?/wp7Qox8PPEa3vX7rlS4BP4qlHOco4pkKPKUJuOywi+ARE90c3Zxy56Fp63p?=
 =?us-ascii?Q?pjo7xpLPTOWaMla1FkgBd/ugKjw98dArUGkcgin710f0+G7NSAIKsAEQUFpt?=
 =?us-ascii?Q?z39KqD1YhkYvbFg1f+HuCHyLrPk4YeHsQIiGMPEgj8Gr0pTK9ZZ0vuWB5hn5?=
 =?us-ascii?Q?yDES3cRkGFD9eqOqumJThgkoHKnP7kHHaB4xG5vFdo1g3GqKcxlR3RzXigAQ?=
 =?us-ascii?Q?G4UxHHH/UA+2AR1KL6YkG7bwkU9kT+hFk5/oLqnwBA7wmw4FIvbvBErXTore?=
 =?us-ascii?Q?R8QMdX7o03z8/PgFMFndCLvegl4AR313wP4YkJKA4u2x1C/5F6iWcCG2quC5?=
 =?us-ascii?Q?hHxhe1D43sFqU1htab2s90+CteTflSsx/J3kzkqu2hkIq2GI203tzUdmWQeA?=
 =?us-ascii?Q?4WJY1iQCuCzoKQrpm/Sj8CE88yC1PAauCCnZDQaGTPBI3ROujvHo1byQouEp?=
 =?us-ascii?Q?REpaCtPfwhLVMHLNT8kDRV0zzeplU5NYmPZxf7Pe0n0RlDwAnUKeLJVDBeRv?=
 =?us-ascii?Q?yArA7pMvnwg7Dg0vYT46SMk0hXs/rClTbNuQCM0JVZG6X6pu/eerB10b6OcC?=
 =?us-ascii?Q?6SbxyY1dSBFp5Ds4QmY4KJOkwp+fze1wP163xXvleDklPfM49tahrZZM9KwU?=
 =?us-ascii?Q?b4STt5JzgfMsi6OcMXM=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB11269.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca0361a5-16ac-45c3-0532-08dc0d58b8ae
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2024 19:09:48.6410
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JXED2/cLVlkWGX0E0o1z6xkp7tJn31qvwBx+B5S2v/5vLfz/9NI6vocRRAa2zIKRxxSap1AXt5VfSd2EO3DD/4zlSODJZ9wkTkaydLvGoug=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB8478

Hi Dmitry Torokhov,

Thanks for the patch.

> -----Original Message-----
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Sent: Thursday, December 21, 2023 3:10 AM
> To: Support Opensource <support.opensource@diasemi.com>; Biju Das
> <biju.das.jz@bp.renesas.com>
> Cc: linux-input@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] Input: da9063_onkey - avoid explicitly setting input's
> parent
>=20
> devm_input_allocate_device() already sets parent of the new input device,
> there's no need to set it up explicitly.
>=20
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju

> ---
>  drivers/input/misc/da9063_onkey.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/input/misc/da9063_onkey.c
> b/drivers/input/misc/da9063_onkey.c
> index ce499c28a7b2..c338765e0ecd 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -211,7 +211,6 @@ static int da9063_onkey_probe(struct platform_device
> *pdev)
>  	snprintf(onkey->phys, sizeof(onkey->phys), "%s/input0",
>  		 onkey->config->name);
>  	onkey->input->phys =3D onkey->phys;
> -	onkey->input->dev.parent =3D &pdev->dev;
>=20
>  	input_set_capability(onkey->input, EV_KEY, KEY_POWER);
>=20
> --
> 2.43.0.195.gebba966016-goog
>=20
>=20
> --
> Dmitry