Received-SPF: pass (google.com: domain of linux-kernel+bounces-17195-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ee37ec0f-13e8-4eed-a675-94e315de7c15@wolfvision.net>
Date: Thu, 4 Jan 2024 21:15:27 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/4] usb: typec: tipd: add patch update support for
 tps6598x
Content-Language: en-US
To: Dhruva Gole <d-gole@ti.com>, Roger Quadros <rogerq@kernel.org>
Cc: Jai Luthra <j-luthra@ti.com>,
 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 Heikki Krogerus <heikki.krogerus@linux.intel.com>,
 linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, vigneshr@ti.com,
 nm@ti.com
References: <20231207-tps6598x_update-v2-0-f3cfcde6d890@wolfvision.net>
 <vmngazj6si7xxss7txenezkcukqje2glhvvs7ipdcx3vjiqvlk@ohmmhhhlryws>
 <2nqiaxakx6setx4tzgddnbjadbh7miegz5p6wamsbbiyrfuq3x@un2uxajbswkg>
 <e9e8dd9f-b11b-43fc-8d76-6734dbddb540@kernel.org>
 <20240104185242.tf2fvgf56ehajqd5@dhruva>
From: Javier Carrasco <javier.carrasco@wolfvision.net>
In-Reply-To: <20240104185242.tf2fvgf56ehajqd5@dhruva>
Content-Type: text/plain; charset=UTF-8
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?a1oySFRBdGZqTkJwd0ttY0ZySVplUUhKazRzSVJ3Y2NtNUZYdUhkRGtWN3FH?=
 =?utf-8?B?aXJ4SXJZMjRwekRTNU9td2J5NUlWeE8rcVhRMG5VMXZuRHNDR2JLeTl1ZldN?=
 =?utf-8?B?UVY1VGhob09jY2lNOHkzWHhubjZJL0dYbjJ6RzcrSHpYUVVGODd3bW9iM0xY?=
 =?utf-8?B?TDlqd0hDelB0NlRKNGdxVHBJNHl5emMzNG9QZlU4NGM4RUtHcTQwNElCRlJy?=
 =?utf-8?B?Nzl3YzMvMGs5eFo5SUsxWWVqZ0o2MzRYdHcwS1NLSTB5VER4WlVGbXdsV1gv?=
 =?utf-8?B?UkFMNWFWdEV5VVhvcXV0ZG5ENXlwbE03NFRSaHZaM1dOb3I0S1U4NFRnVmZF?=
 =?utf-8?B?WHRtcldoak1qaS81d3BrQzVEQmhWanptSldWR1FBMTNOU2g4bTd4QmtLcGtX?=
 =?utf-8?B?NUlkY3NwVFg2R1N5TWJnRC9LSnRGZnNkZ1FqYUk3Q2k4ZTZXRHV3Vi9waFBn?=
 =?utf-8?B?QTBXRE1zZXJUaTlNSkI1eVI4VjNxeWZKbTN0bWlyVXZNK3ZCS01vdUNWQnVB?=
 =?utf-8?B?L0VnUXRPNi9HUWF5TGVGK3UwTjJSUEdtMVNvRmUwMVYvSzAwbFlnc1VqT3M0?=
 =?utf-8?B?M2FpU0ZvN012Y21ma2dGM0NzNE96WnhnWDNiTkQ3NHlXUWh4SDFHVUNxSTh1?=
 =?utf-8?B?MVNBbElnT0JJK0UxTjFZUHg2S0lkRGdJUHh6dlRwdC92LzBTaXdDSFN5d3d4?=
 =?utf-8?B?ZTFkTXpsdDJVc3JWazdTRU4zcG1RYkt6eGpnaDNWak9QelB6Y1NaTHA2dlZW?=
 =?utf-8?B?SGY1aWdMZFgxaStpYXhZcnNra2Q5ejN0blB1aWRjeGlNSndhcXBzeUQydGJJ?=
 =?utf-8?B?d1pFS0N4VDNaRFQ5Q2QzZU8wZ2pIS1A2cGhMaERKNGtuYVhXdTJHT0lhd3hD?=
 =?utf-8?B?a3FDVDV3bDVCaWZtaGFrT0t6TnBmZEZrN0txbmRIRlFSZng2ME0vZVh2czZi?=
 =?utf-8?B?eUdTek5hYjNlWTRaLy9IK1d5UmRQRWhLRjVqSW4vWGNMakgxUEJBVC9pZVR2?=
 =?utf-8?B?bUJvbGNzVWhseDhIM3FYL1ZkSllsUENVV3dSN0Rwb1ZjdGpiZGlrTDFnZEdN?=
 =?utf-8?B?RlVhZTR5QUFobTRGcXpzWm5zTE1mQ05IS2NPSENvNUtsbWttcjFlanlaeDBG?=
 =?utf-8?B?S29OS1NUczRlWmxrMFloVGFTcThKZG85TEJKOFlFeVVBSGE3dHFka0t3ME9R?=
 =?utf-8?B?Um1uSGNmVTk3Mmh2c3A2MDZUQ3FtLzdDNXNsNFpSc0FLdXoyYVUzV0ljRmps?=
 =?utf-8?B?SVNHREx3ZEJwcmovaEpnKy9nUlQ3U2NxeG1DTXRPcjc4VXUvMTV3ZEQxNDUv?=
 =?utf-8?B?eDkwWGJ3MzIrV1hzaWZDRU5mMXA1UTk1NFVsSlREdHg3dnNTWjJ0ZC9ZdWQx?=
 =?utf-8?B?RWV0ZDluRkN0dXQ5S213dHZUM2lFVElRWUZHYWZNQWtPUWErM3hVRkZlNi92?=
 =?utf-8?B?NGtZUStKdWZRTWliWmo3NzAyRlVpR0wzTDVkbzFXdFJEenBTTmlGMUFpNG5D?=
 =?utf-8?B?S1lsK0x5ZUhYMVNHeWNuVUJGTlg5QUN3cCszUjhEaE14WWg4eHJpem5yRGlM?=
 =?utf-8?B?ejZLOTZjRUVKbWtiMGZ0eGs1M3dhT2pObi9DQUhWTU5QQk9xaVhtOXU4VG5Q?=
 =?utf-8?B?UWFoL3hTWXV6TzcwYjNYTTkvNGNEUXNrTHVYRGh4OUFFTXVPa1JZbkgxQU1Y?=
 =?utf-8?B?U1FKTXBLRUJad0JpTmFlVStXenJ6c3pJdXVYVFZjL2RETFIrL1h5R3U2akF3?=
 =?utf-8?B?OVZiSkFpbnMzcEh2MGhRUEkwbGZ3K1FFYzVVRGlFdVRVWlkzOG9nazQvK1V4?=
 =?utf-8?B?L2MrM3duaWtjRUtPZ1ByamQxMEp5U2UxUFFKVFVjdml1NG9TNUNOcDFsT05m?=
 =?utf-8?B?UWdjTjlDalRZTjdvbmFxWFBMZFRFWnNIdURpRWNsQU1rYUg0THBoWEpISnRD?=
 =?utf-8?B?SFg4MEo1QU41S0c0NVNYdjRYQ2JwVld5Zjd4cFhvM0xKQ2hGU1BMeE0xNE15?=
 =?utf-8?B?dlpNZ0hIRjBHRjlvSVVPaUpFUzlDeHRvWGVmWVBPQUhaT09CcWl5TStBRnZB?=
 =?utf-8?B?Snd5c3F5NUdZRnJtUXg2c2RveFNKRmxpMEh4ZEx2c3hIVG9IdVJYZTdDd2tB?=
 =?utf-8?B?RFRDZUdhM0o0Y0ZHZ0crSmRINFl4a2RnQkhNMmxCR3FVZUFucXhhREJzY3hj?=
 =?utf-8?B?Q1dNZGdSem1hSGpLeTN2ekZYQW5JeHRWaWJ4Z3dzTjFPZDBORVpLNm43ZDZT?=
 =?utf-8?Q?Bwq+kPTLqHrcNklKiWlJh8Xcxj3DdgUZ4kTeF6ZjNM=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: bc2d8e65-1d84-4368-f032-08dc0d61e60a
X-MS-Exchange-CrossTenant-AuthSource: VE1PR08MB4974.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 20:15:30.3714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PybDfI9x36/0+hrEUvA1c592nDl2eZbuBvpQyVeTXyAsa8KrpmjEpmi38AaAx7C3+m0YSFmKqjElYxzc5Dh804P/Eby1OuL23gUQMt8nAs0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5706

On 04.01.24 19:52, Dhruva Gole wrote:

> 
> This series also broke boot on TI SK-AM62x [0].
> 

>>
>> This looks like a correct fix to me.
>> Could you please send a proper PATCH with Fixes tag? Thanks!
> 
> Thanks for reviewing this Roger, the same patch above worked for me to
> fix SK-AM62x as well [1].
> 
> [0] https://storage.kernelci.org/next/master/next-20240103/arm64/defconfig/gcc-10/lab-ti/baseline-nfs-am62xx_sk-fs.txt
> [1] https://gist.github.com/DhruvaG2000/326b5d7fab4be95f20cd0aac4125f577
> 
Hi Dhruva,

I am glad that you guys found a fix that quickly.

it seems that you guys work for the device manufacturer (because of your
email addresses), so I was wondering if you could explain (or provide
the documentation) why the tps6598x should not receive the GAID command
and a reset crashes the system. Everything looks exactly the same as for
the tps25750, but in that case there are no complaints from sending a
cold reset.

Thanks again and best regards,
Javier Carrasco