Received-SPF: pass (google.com: domain of linux-kernel+bounces-17209-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
Message-ID: <trinity-940b6e7e-1246-45f8-af65-f5048bc2265b-1704401680934@3c-app-gmx-bs29>
From: Frank Wunderlich <frank-w@public-files.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Daniel Golle <daniel@makrotopia.org>, Frank Wunderlich
 <linux@fw-web.de>, linux-mediatek@lists.infradead.org, Michael Turquette
 <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Matthias
 Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@collabora.com>, Philipp Zabel
 <p.zabel@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley
 <conor+dt@kernel.org>, Sam Shih <sam.shih@mediatek.com>,
 linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Aw: Re: [PATCH 1/2] dt-bindings: reset: mediatek: add MT7988 LVTS
 reset ID
Content-Type: text/plain; charset=UTF-8
Date: Thu, 4 Jan 2024 21:54:40 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <3e3455a1-c540-4323-9d9d-95289a395c3f@linaro.org>
References: <20240104173930.13907-1-linux@fw-web.de>
 <20240104173930.13907-2-linux@fw-web.de>
 <ZZb0-pFWxuQlEm7q@pidgin.makrotopia.org>
 <3e3455a1-c540-4323-9d9d-95289a395c3f@linaro.org>
UI-OutboundReport: notjunk:1;M01:P0:tB+ieJbTebQ=;0WICBO5JQdiX9M3vSS+T9ckm3a9
 bGtqXX18GHN6TYSLML7cneFFD2QCV0i55WJmMuU6C3NnsZzm7XZGNPSL2fVmEnaarxkfVGXtH
 u0nyxo+FCXPVprhuYZwKluLsQBI3+AXoNTKEC1lxjGM4TAqbZdgH/dudmrYqXpk41uBE9I7az
 28FsvUElYvWBgGO3d4PSJIV07+q+uNKtXYoVq0WXrDRc7Lv/Q9dVYqrqkS0aOU+htULnJ7gnC
 W4vYjamfWlb1Y5LFMNu5YnNeMTNB6frj+XOUNOB7mjf2rz1sMJWg/sKW6xDIkO0kFrtCm5k1a
 F11TBoh2WrGmunSRhCxHPFEQGJrFQ8B412mqr5ubbuLZ2GCk9dtUuen9PapKyofzttvcPrQpw
 j43qPTxTVd8R1zxscAxHJpb/ivgBL8Mqj69QbRe4ldLrHCwG9yQKJrAIu9jVR4UMg2vqkcj5L
 MW7ijNCAOaO7maqwa9Ab3t80RzVf5gR0ljoMBy6yT0dKFAJdpaVsTXC2FrNMZB69CkB2oZvBo
 gg15EsOhF7obUIWzF9KufGYYGe450auwNceaiXv6HkQkER69bQ0Tu+sa5Aqwi7iUWKM5Xmdcb
 oIQIk0KRkBriUvzo9BohB5dUnA4bO/Hz6B8OkZGDra9DdSQJEuz22LiDCotNZpdcmvmVl0zXS
 UX33TFUhPKS+oQYZPEzeiXoZ075J/2FfTS/iCboU/HXZCuIlgNIY6oYNRD1MYIzyz8+axCWPZ
 N1f6B/PcyoF1JfUlNwKCQc78IOgdR2C7ZopRmhPBJTDir9ozPjav8PFHiwGrD6Hbw9JOFQR00
 VTrNtPB/zjBe/yMvvEQ7lLkyiSPb2CATLh6gaNXrFcPOk=
Content-Transfer-Encoding: quoted-printable

Hi

> Gesendet: Donnerstag, 04. Januar 2024 um 20:19 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
> Betreff: Re: [PATCH 1/2] dt-bindings: reset: mediatek: add MT7988 LVTS r=
eset ID
>
> On 04/01/2024 19:12, Daniel Golle wrote:
> > Hi Frank,
> >
> > On Thu, Jan 04, 2024 at 06:39:29PM +0100, Frank Wunderlich wrote:
> >> From: Frank Wunderlich <frank-w@public-files.de>
> >>
> >> ---
> >>  include/dt-bindings/reset/mediatek,mt7988-resets.h | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/include/dt-bindings/reset/mediatek,mt7988-resets.h b/inc=
lude/dt-bindings/reset/mediatek,mt7988-resets.h
> >> index 493301971367..3f1e4ec07ad5 100644
> >> --- a/include/dt-bindings/reset/mediatek,mt7988-resets.h
> >> +++ b/include/dt-bindings/reset/mediatek,mt7988-resets.h
> >> @@ -10,4 +10,8 @@
> >>  /* ETHWARP resets */
> >>  #define MT7988_ETHWARP_RST_SWITCH		0
> >>
> >> +/* INFRA resets */
> >> +#define MT7988_INFRA_RST0_THERM_CTRL_SWRST	9
> >
> > I suppose this argument applies here as well:
> >
> > "IDs should start from 0 or 1 and increment by 1. If these are not IDs=
,
> > then you do not need them in the bindings."
> >
> > https://lore.kernel.org/all/59629ec1-cc0c-4c5a-87cc-ea30d64ec191@linar=
o.org/
> >
> > As a consequence, as what you are describing there are hardware bits
>
> If this is existing driver which already uses such pattern, then it is
> fine. I usually comment this on new drivers which can be changed.

this is a new driver so i guess i should change this like daniel suggests.
As i want to use this constant in dts and driver i would like keep it as b=
inding in the reset header,
but because i use it only as index in the infra_idx_map array its value do=
es not need to have the value
needed in hardware. i kept it same to not have different values and for or=
dering purposes (when the other
possible resets are added).

so the way starting at 0 will be the preferred one for me, is this ok?

regards Frank