Received-SPF: pass (google.com: domain of linux-kernel+bounces-17219-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "Mehta, Sohil" <sohil.mehta@intel.com>, "jarkko@kernel.org"
 <jarkko@kernel.org>, "x86@kernel.org" <x86@kernel.org>,
 "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
 "cgroups@vger.kernel.org" <cgroups@vger.kernel.org>, "hpa@zytor.com"
 <hpa@zytor.com>, "mingo@redhat.com" <mingo@redhat.com>, "tj@kernel.org"
 <tj@kernel.org>, "mkoutny@suse.com" <mkoutny@suse.com>, "tglx@linutronix.de"
 <tglx@linutronix.de>, "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "bp@alien8.de"
 <bp@alien8.de>, "Huang, Kai" <kai.huang@intel.com>, "Dave Hansen"
 <dave.hansen@intel.com>
Cc: "mikko.ylinen@linux.intel.com" <mikko.ylinen@linux.intel.com>,
 "seanjc@google.com" <seanjc@google.com>, "Zhang, Bo" <zhanb@microsoft.com>,
 "kristen@linux.intel.com" <kristen@linux.intel.com>, "anakrish@microsoft.com"
 <anakrish@microsoft.com>, "sean.j.christopherson@intel.com"
 <sean.j.christopherson@intel.com>, "Li, Zhiquan1" <zhiquan1.li@intel.com>,
 "yangjie@microsoft.com" <yangjie@microsoft.com>
Subject: Re: [PATCH v6 09/12] x86/sgx: Restructure top-level EPC reclaim
 function
References: <20231030182013.40086-1-haitao.huang@linux.intel.com>
 <20231030182013.40086-10-haitao.huang@linux.intel.com>
 <c8fc40dc56b853fbff14ba22db197c80a6d31820.camel@intel.com>
 <op.2e0yod2lwjvjmi@hhuan26-mobl.amr.corp.intel.com>
 <431c5d7f5aee7d11ec2e8aa2e526fde438fa53b4.camel@intel.com>
 <op.2ftmyampwjvjmi@hhuan26-mobl.amr.corp.intel.com>
 <3c27bca678c1b041920a14a7da0d958c9861ebca.camel@intel.com>
 <op.2f0eo8r1wjvjmi@hhuan26-mobl.amr.corp.intel.com>
 <73ed579be8ad81835df1c309b7c69b491b7f2c8e.camel@intel.com>
 <op.2f523elowjvjmi@hhuan26-mobl.amr.corp.intel.com>
 <4b28fc01-50cf-469b-8161-7d56b863b42b@intel.com>
 <op.2g1d81fqwjvjmi@hhuan26-mobl.amr.corp.intel.com>
 <2aee5f75-836e-4a47-a29c-b272150227a8@intel.com>
Date: Thu, 04 Jan 2024 15:01:59 -0600
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: Quoted-Printable
From: "Haitao Huang" <haitao.huang@linux.intel.com>
Organization: Intel
Message-ID: <op.2g1jdlojwjvjmi@hhuan26-mobl.amr.corp.intel.com>
In-Reply-To: <2aee5f75-836e-4a47-a29c-b272150227a8@intel.com>
User-Agent: Opera Mail/1.0 (Win32)

On Thu, 04 Jan 2024 13:27:07 -0600, Dave Hansen <dave.hansen@intel.com> =
 =

wrote:

> On 1/4/24 11:11, Haitao Huang wrote:
>> If those are OK with users and also make it acceptable for merge
>> quickly, I'm happy to do that =F0=9F=99=82
>
> How about we put some actual numbers behind this?  How much complexity=

> are we talking about here?  What's the diffstat for the utterly
> bare-bones implementation and what does it cost on top of that to do t=
he
> per-cgroup reclaim?
>

For bare-bone:

  arch/x86/Kconfig                     |  13 ++++++++++++
  arch/x86/kernel/cpu/sgx/Makefile     |   1 +
  arch/x86/kernel/cpu/sgx/epc_cgroup.c | 104  =

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++=
++++++++++++++++++++
  arch/x86/kernel/cpu/sgx/epc_cgroup.h |  39  =

+++++++++++++++++++++++++++++++++++
  arch/x86/kernel/cpu/sgx/main.c       |  41  =

++++++++++++++++++++++++++++++++++++
  arch/x86/kernel/cpu/sgx/sgx.h        |   5 +++++
  include/linux/misc_cgroup.h          |  42  =

+++++++++++++++++++++++++++++++++++++
  kernel/cgroup/misc.c                 |  52  =

+++++++++++++++++++++++++++++++---------------
  8 files changed, 281 insertions(+), 16 deletions(-)

Additional for per-cgroup reclaim:

  arch/x86/kernel/cpu/sgx/encl.c       |  41 +++++++++--------
  arch/x86/kernel/cpu/sgx/encl.h       |   3 +-
  arch/x86/kernel/cpu/sgx/epc_cgroup.c | 224  =

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++=
+++++++++++++++++--
  arch/x86/kernel/cpu/sgx/epc_cgroup.h |  18 ++++++--
  arch/x86/kernel/cpu/sgx/main.c       | 226  =

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------=
--------------------
  arch/x86/kernel/cpu/sgx/sgx.h        |  85  =

+++++++++++++++++++++++++++++++++--
  6 files changed, 480 insertions(+), 117 deletions(-)


Thanks
Haitao