Received-SPF: pass (google.com: domain of linux-kernel+bounces-17241-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20231228025600.9796-1-zeming@nfschina.com>
In-Reply-To: <20231228025600.9796-1-zeming@nfschina.com>
From: Paul Moore <paul@paul-moore.com>
Date: Thu, 4 Jan 2024 16:30:38 -0500
Message-ID: <CAHC9VhSjxWR9fy2Dq8-sgP=1bkPmDjFH-QehZ4eow1U=sEpBzg@mail.gmail.com>
Subject: =?UTF-8?Q?Re=3A_=5BPATCH=5D_kernel=3A_auditfilter=3A_Remove_unnecessary_?=
	=?UTF-8?Q?=E2=80=980=E2=80=99_values_from_ret?=
To: Li zeming <zeming@nfschina.com>
Cc: eparis@redhat.com, audit@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 27, 2023 at 9:56=E2=80=AFPM Li zeming <zeming@nfschina.com> wro=
te:
>
> The ret variable is assigned when it does not need to be defined, as it
> has already been assigned before use.
>
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  kernel/auditfilter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the patch, as this is not a critical change it will be
processed after the upcoming merge window closes.

> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> index 8317a37dea0bb..be8c680121e46 100644
> --- a/kernel/auditfilter.c
> +++ b/kernel/auditfilter.c
> @@ -788,7 +788,7 @@ static int audit_compare_rule(struct audit_krule *a, =
struct audit_krule *b)
>  static inline int audit_dupe_lsm_field(struct audit_field *df,
>                                            struct audit_field *sf)
>  {
> -       int ret =3D 0;
> +       int ret;
>         char *lsm_str;
>
>         /* our own copy of lsm_str */
> --
> 2.18.2

--=20
paul-moore.com