Received-SPF: pass (google.com: domain of linux-kernel+bounces-17304-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240103153307.553838-1-brho@google.com> <20240103153307.553838-3-brho@google.com>
 <CAEf4BzbKT3LbHQSFwpAfoJuhyGy2NpHk7A6ivkFiutN_jnKHYg@mail.gmail.com> <0d9f51e9-7e07-48dd-bf18-ea28ab6b1e83@google.com>
In-Reply-To: <0d9f51e9-7e07-48dd-bf18-ea28ab6b1e83@google.com>
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date: Thu, 4 Jan 2024 14:45:56 -0800
Message-ID: <CAEf4Bzb8RviBbC0fVMzKmoY6oU0B1v_8CrnUr1RaffPWb7SpLQ@mail.gmail.com>
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: add inline assembly helpers
 to access array elements
To: Barret Rhoden <brho@google.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, Alexei Starovoitov <ast@kernel.org>, 
	Daniel Borkmann <daniel@iogearbox.net>, Song Liu <song@kernel.org>, 
	Yonghong Song <yonghong.song@linux.dev>, mattbobrowski@google.com, bpf@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 4, 2024 at 1:37=E2=80=AFPM Barret Rhoden <brho@google.com> wrot=
e:
>
> On 1/3/24 14:51, Andrii Nakryiko wrote:
> >> +
> >> +/*
> >> + * Helper to load and run a program.
> >> + * Call must define skel, map_elems, and bss_elems.
> >> + * Destroy the skel when you're done.
> >> + */
> >> +#define load_and_run(PROG) ({
> > does this have to be a macro? Can you write it as a function?
>
> can do.  (if we keep these patches).
>
> i used a macro for the ## PROG below, but i can do something with ints
> and switches to turn on the autoload for a single prog.  or just
> copy-paste the boilerplate.

why can't you pass the `struct bpf_program *prog` parameter?

>
> >> +       int err;                                                      =
  \
> >> +       skel =3D array_elem_test__open();                             =
    \
> >> +       if (!ASSERT_OK_PTR(skel, "array_elem_test open"))             =
  \
> >> +               return;                                               =
  \
> >> +       bpf_program__set_autoload(skel->progs.x_ ## PROG, true);      =
  \
>
> thanks,
>
> barret
>
>