Received-SPF: pass (google.com: domain of linux-kernel+bounces-17313-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 4 Jan 2024 15:00:21 -0800
From: Ira Weiny <ira.weiny@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>, Ira Weiny <ira.weiny@intel.com>
CC: Dan Williams <dan.j.williams@intel.com>, Bjorn Helgaas
	<bhelgaas@google.com>, Jonathan Cameron <jonathan.cameron@huawei.com>, "Smita
 Koralahalli" <Smita.KoralahalliChannabasappa@amd.com>, Shiju Jose
	<shiju.jose@huawei.com>, Yazen Ghannam <yazen.ghannam@amd.com>, "Davidlohr
 Bueso" <dave@stgolabs.net>, Dave Jiang <dave.jiang@intel.com>, "Alison
 Schofield" <alison.schofield@intel.com>, Vishal Verma
	<vishal.l.verma@intel.com>, Ard Biesheuvel <ardb@kernel.org>,
	<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-cxl@vger.kernel.org>, <linux-pci@vger.kernel.org>
Subject: Re: [PATCH v5 8/9] PCI: Define scoped based management functions
Message-ID: <659738852ffea_2dc8629466@iweiny-mobl.notmuch>
References: <6597275045fbf_267e82949d@iweiny-mobl.notmuch>
 <20240104223725.GA1829769@bhelgaas>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240104223725.GA1829769@bhelgaas>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8n6VvNkvJghk3ZwMd+idfi/XC5Kd/WorD1pMl9sxt4+yeajc1I5IEBBxxSLW?=
 =?us-ascii?Q?pzJCG6tMI5qXk9Lk9vuL8wO0clX9XntSAwR7o6x+Zskwq05DEmFQn5mR3CtN?=
 =?us-ascii?Q?4Q9JvIPsl7BVYlj5Z4QKNk+RcD3wJR6zNaSHhvWf49lgC6e558xlbyn8WpAJ?=
 =?us-ascii?Q?cqrh+lXPIqgu8pIZffRLsPyI/d4vmxQnkXinA21SZILVz/DYDc5HiJu9TBlC?=
 =?us-ascii?Q?u8fO+aZTYc/xrgHB68RjymS6b/RpSdDgv9FSQpyYEEMAHLvlRG8XiceB11x9?=
 =?us-ascii?Q?pEBFLpLZ5GBAjvRJBLVLKzYvHjKqpINDUr+j2SZiRA2Ke4YCwnVQSEBosP9F?=
 =?us-ascii?Q?uYKY1oS5z7QMCRpiJWgX2clywi0ouzi3zwb2/TPx/xvdt6rYDhXJmoOporBi?=
 =?us-ascii?Q?aK0sGnyHMii2+IoYzWXbI42w5iBvoFbvoFaJOfPyWmAgTST76q1ftBFC29yg?=
 =?us-ascii?Q?+y30g0ANT7OAhIu3ZqHMvSUjMcXEghIQZ+B5fXexj5jRMuiUSu2JmVq4PNyk?=
 =?us-ascii?Q?7F0Yk33mWzCgWkLp2q9IK5F62QbmGL+6I7sbegwhiqvii19lRPJ6GMLfBGzX?=
 =?us-ascii?Q?by72LKjkVeqdiL6zrng4tzwB84QZuKywZrJ8JeuLbClGgOClbw5Y1qHHSTB6?=
 =?us-ascii?Q?JnWN5h/y9SzCYmSbGX3qnx9lHcOiAIyj0q9DJWH4A2UXEROHZpyJsZtjQWbL?=
 =?us-ascii?Q?JJgr4Ab74jZaKI+pzSDfXWE3yZFz5DH2Ge9EDN2g3MfY5Daz/bnQdrSi53+E?=
 =?us-ascii?Q?7zrikXtop/njY6oYuFNP0eaMJ3otLmJ4pseQ1W7Yfx1LvAcMFflMiC83dw0p?=
 =?us-ascii?Q?ot70wH7wOhsqclfgt+TfV4ZOSeEI+6zUQQAIekRZEaMJi7lMQYhtIX0UC/Sg?=
 =?us-ascii?Q?VbWrae9/IjnehbrwuDpOuRBtpJu3rvqVB2XHOe63ZeWuVeOPFkkQvFsFaab6?=
 =?us-ascii?Q?6eewK8i5pIbJ5QdOQZB3BqR4kzP0sZ3ZLBtFckTTgbntGxRMjye5E+hUZ2Fv?=
 =?us-ascii?Q?cc4C3yRRk1mnaaQrth4BqL+vuuiQFqqPQMSv9qBs0VfPyQ7J+/ayHJ/4WYzl?=
 =?us-ascii?Q?iB//MGryxRqfUA1H8IxbpDIXHPOmXIRSqhazoUrPZvawyMD5l5J2I8hkqIBU?=
 =?us-ascii?Q?aqlI15al0xCsXunIo0zjWGz3ZNChPb9j8B/8DbVkCIAMia1z51t+vN+s9t/8?=
 =?us-ascii?Q?2aW/D0qga2VloLlv0CvZ4DPHW/4Jj2NmJr+G1a2u4vJxZoD7m16O0VWdSlc5?=
 =?us-ascii?Q?M9TjGmWipt6xXJZDuzHgoQ2Dpfoq/Lvchr2RlBoH2TA6W1fMJ1yZ7fZqkDkp?=
 =?us-ascii?Q?oPZO8+T4QyOfLAQyLiWxRupEzaZvdC53Vp3PGfm1GzuqQZyrx2QTDV80kWNd?=
 =?us-ascii?Q?L5q8E+zaA75jKXWJEW2gA7tU4lLJubEj9ZgZuEk1/SZl7OYp4XNun+FeM4Dg?=
 =?us-ascii?Q?oDramcYs5b1h9IiWkRtlh9ebz6cq/EHt+8Nyvw1i8TIlgIQjP445np5vlMRX?=
 =?us-ascii?Q?ec0lrIrIbLNNQfhiNktlyutDlDEgm4+VpwCvWwRZKUIhQS1qNj88VbbQDWNS?=
 =?us-ascii?Q?CEd6+CkRv5Zx4WtFiRQ8uHMCBeIWgAnpOrF7WgAl?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bd327c27-d7b8-4ac1-6a67-08dc0d78efe6
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 23:00:25.3964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 07iHAjJckr+M0veKpDGvaDh54X/bHOcZDP9kaBialIWU66GTJM8h8ev31YpxAieqzsaWCSyrjmOijlSv//RW/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6565
X-OriginatorOrg: intel.com

Bjorn Helgaas wrote:
> On Thu, Jan 04, 2024 at 01:46:56PM -0800, Ira Weiny wrote:
> > Dan Williams wrote:
> > > Bjorn Helgaas wrote:

[snip]

> > 
> > Also in this case we need devfn assigned first.
> > 
> > Is the above patch compliant with current style guidelines?
> > 
> > Or would it be better to do?
> > 
> > diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c
> > index b14237f824cf..8a180c6abb67 100644
> > --- a/drivers/cxl/pci.c
> > +++ b/drivers/cxl/pci.c
> > @@ -975,15 +975,14 @@ static void cxl_cper_event_call(enum cxl_event_type ev_type,
> >                                 struct cxl_cper_event_rec *rec)
> >  {
> >         struct cper_cxl_event_devid *device_id = &rec->hdr.device_id;
> > -       struct pci_dev *pdev __free(pci_dev_put) = NULL;
> >         enum cxl_event_log_type log_type;
> >         struct cxl_dev_state *cxlds;
> > -       unsigned int devfn;
> > +       unsigned int devfn = PCI_DEVFN(device_id->device_num, device_id->func_num);
> > +       struct pci_dev *pdev __free(pci_dev_put) = pci_get_domain_bus_and_slot(
> > +                                                       device_id->segment_num,
> > +                                                       device_id->bus_num, devfn);
> 
> I don't really care about this specific instance; my comment was more
> about the commit log for the "Define scope based management functions"
> patch, thinking maybe the example could encourage get/put togetherness
> when it's practical.

Ok thanks!
Ira