Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp7997841rdb; Thu, 4 Jan 2024 15:07:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IGU16UBwH6jpL1P2xiJboCbUzi3A9hV7zPfOMvYLyB1AnXaO7vweGLAsYcGLn0xgqyulLm0 X-Received: by 2002:a05:6e02:2163:b0:35f:b0d1:985b with SMTP id s3-20020a056e02216300b0035fb0d1985bmr1499337ilv.3.1704409624481; Thu, 04 Jan 2024 15:07:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704409624; cv=none; d=google.com; s=arc-20160816; b=VdjY1iM2cG4dXHG61K8bXW+5O8q4stE+h0/nGghDeYO6S0DdDonGDrzhnUMOiDwInQ nvfpQeSOf725mj4L4AVsCnCrlp0GWt+Lt9owD8H86XZwE9gNCh3xRbDOIV2gzxkrf4f/ JjlkLGa8UFDUjVd+CGQBx/6v9RRhVJte6AjUSLYy7V4aEbiegkbU0yRlg8MtufaJ3d0Q 7HbI6AZuiRQXhEP+4iekNLyLN+XfCSA4e+Bl3b6I1wiUiELx5SnTrC/ONmz8SRaFMJi7 18GiYsHdLNqpTCSRwP7hRd1EwIuDS18m0cTXHwfNlMFIrZ4ybXT5HGdqLRMnE+CObzXZ 5HXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=b3dqk0Ff5KxkGnHBKa5j/udiyY23Ohwl6jdUCl4DaB4=; fh=E/hj+PQlsTUIKwOC6yP+U3MeVLNiBIyrB72vrkdEgu8=; b=okqe1L4IIGfGXqWXiG9iSOq3GJrZI9i7ViOwtB6oG422sg0DDkZhJLEUpolIgv3DtY 9GA4ZvAGGS6wqN/HM1/bIe4ohD+Oi0gQt5nH5/extK7FxXvRWoN62yINnupncCyIRMCH fQcqZZy/tcde4TmtNEPCfYEBqP1Bw6EJlQ436ehTLxnPYj7RoEa5maRd5wuRYwAFj2GK Zthl53hZ6kYEgVtIhDAJU4gA3RSIwhGmM25BksTGQUpZi6/0LhdcdZZVLxhfMTmw8vXg q0AnOfXiXrsv8YZ01rbbVcirulOSQSFz2RBoSOebXXBumnaz4N9QIKJPM+yvF8Vmru2n fgeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=dXzU8xE1; spf=pass (google.com: domain of linux-kernel+bounces-17316-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17316-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l189-20020a633ec6000000b005ce04743535si300982pga.303.2024.01.04.15.07.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 15:07:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-17316-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20230601.gappssmtp.com header.s=20230601 header.b=dXzU8xE1; spf=pass (google.com: domain of linux-kernel+bounces-17316-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17316-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 02380286351 for ; Thu, 4 Jan 2024 23:07:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 634642D022; Thu, 4 Jan 2024 23:06:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="dXzU8xE1" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B8F2D036 for ; Thu, 4 Jan 2024 23:06:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Received: by mail-io1-f45.google.com with SMTP id ca18e2360f4ac-7bb5be6742fso13969539f.1 for ; Thu, 04 Jan 2024 15:06:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1704409608; x=1705014408; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b3dqk0Ff5KxkGnHBKa5j/udiyY23Ohwl6jdUCl4DaB4=; b=dXzU8xE1lqQl2K7qBNp3a3sUpSqmuTJxjsd4bnp3v497vyejefnaPCwiohBtsBc/0f FKWeuorH/FAvl5raJJYxDNmer4qPEFy2AV6asWQm+8kSLhQd6WXxCsw8tDboeKaHz7jT A0p2zzkqyZW3j5Dktq5cHhtZ0nrEpOe1cGZDtaAUsqffDykLlILtJ5a4WOr3AKvvdiId dBx1NWOhTFBO6WHzD4rJlDEKdKNhWWTEsnbQWKKYrYd5XjTmhREOmqo/kHaZsJCw13OB pmDkJubfmaPu+BMU32t7bz4J3XdVTp1F0DBRe6g6GFU6QmJqDuWphshDVGmNuZ+Yurbk gzrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704409608; x=1705014408; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b3dqk0Ff5KxkGnHBKa5j/udiyY23Ohwl6jdUCl4DaB4=; b=nDRou/Xmcl3Yv5/lDx9MjM14rMt0kqZocn83G5QNockSdXt+FPv4raUaK80GKs/pzo mOZlZjVY6BXuCICnGEvmmI4/QYWfK28/qJxZ8fQVyG+u+Wt8icdguEaKwS1EVLF/nRr6 L2Kc8uHcUfCeg1odC7NIMS0Aofx7gswx2Am4AoZ4Puqmr+MNeq8d/28ugiMSwevIpqcS vyTo30anBfZN7Ps8rbfytFys9IM8g6XBtwkf0IG1kze1G/kZGrFZzHqsN+0MwgLmKk1T GxWitZZ2wL45kTYLRpQHAEfJh7OK1dSoeK4cayD63+8VlknN6QduawE7gStDQ+m3LCg0 HHtw== X-Gm-Message-State: AOJu0YzWLzGA+rjMod/pBOd0Fc4UJOgPCUA2sStTx6vWQOydCsQ7BB4o h6L04EqsXwMIPwmZ9FcX+Nte50KZrh4oebS/3tiA1D9k0MLuDg== X-Received: by 2002:a92:c56a:0:b0:35f:b1d8:433f with SMTP id b10-20020a92c56a000000b0035fb1d8433fmr2502382ilj.3.1704409608642; Thu, 04 Jan 2024 15:06:48 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id b1-20020a63eb41000000b005aa800c149bsm199646pgk.39.2024.01.04.15.06.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 15:06:47 -0800 (PST) Message-ID: <3de0c147-0a6e-47ad-90dd-cc624da6200b@kernel.dk> Date: Thu, 4 Jan 2024 16:06:46 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] blk-cgroup: clean up after commit f1c006f1c685 Content-Language: en-US To: Daniel Vacek , Tejun Heo , Josef Bacik Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240104180031.148148-1-neelx@redhat.com> From: Jens Axboe In-Reply-To: <20240104180031.148148-1-neelx@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/4/24 11:00 AM, Daniel Vacek wrote: > Commit f1c006f1c685 moved deletion of the list blkg->q_node > from blkg_destroy() to blkg_free_workfn(). Clean up the now > useless variable. I'll fix up your commit this time, but please take a look at your title and tell me if you think it's a good one? Not very descriptive, is it. -- Jens Axboe