Received-SPF: pass (google.com: domain of linux-kernel+bounces-17324-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20231220001856.3710363-1-jstultz@google.com> <20231220001856.3710363-17-jstultz@google.com>
 <64660905-affd-4f23-b971-1dc9698c312e@arm.com>
In-Reply-To: <64660905-affd-4f23-b971-1dc9698c312e@arm.com>
From: John Stultz <jstultz@google.com>
Date: Thu, 4 Jan 2024 15:25:27 -0800
Message-ID: <CANDhNCokDDQAMkZve5===CC2fw2Rdhjx+RAuQ2auE=+jaPdQmw@mail.gmail.com>
Subject: Re: [PATCH v7 16/23] sched: Add deactivated (sleeping) owner handling
 to find_proxy_task()
To: Metin Kaya <metin.kaya@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>, 
	Joel Fernandes <joelaf@google.com>, Qais Yousef <qyousef@google.com>, Ingo Molnar <mingo@redhat.com>, 
	Juri Lelli <juri.lelli@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>, 
	Dietmar Eggemann <dietmar.eggemann@arm.com>, Valentin Schneider <vschneid@redhat.com>, 
	Steven Rostedt <rostedt@goodmis.org>, Ben Segall <bsegall@google.com>, 
	Zimuzo Ezeozue <zezeozue@google.com>, Youssef Esmat <youssefesmat@google.com>, 
	Mel Gorman <mgorman@suse.de>, Daniel Bristot de Oliveira <bristot@redhat.com>, Will Deacon <will@kernel.org>, 
	Waiman Long <longman@redhat.com>, Boqun Feng <boqun.feng@gmail.com>, 
	"Paul E. McKenney" <paulmck@kernel.org>, Xuewen Yan <xuewen.yan94@gmail.com>, 
	K Prateek Nayak <kprateek.nayak@amd.com>, Thomas Gleixner <tglx@linutronix.de>, kernel-team@android.com, 
	Valentin Schneider <valentin.schneider@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 22, 2023 at 12:33=E2=80=AFAM Metin Kaya <metin.kaya@arm.com> wr=
ote:
> On 20/12/2023 12:18 am, John Stultz wrote:
> > @@ -3936,13 +4063,19 @@ void sched_ttwu_pending(void *arg)
> >       update_rq_clock(rq);
> >
> >       llist_for_each_entry_safe(p, t, llist, wake_entry.llist) {
> > +             int wake_flags;
> >               if (WARN_ON_ONCE(p->on_cpu))
> >                       smp_cond_load_acquire(&p->on_cpu, !VAL);
> >
> >               if (WARN_ON_ONCE(task_cpu(p) !=3D cpu_of(rq)))
> >                       set_task_cpu(p, cpu_of(rq));
> >
> > -             ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRA=
TED : 0, &rf);
> > +             wake_flags =3D p->sched_remote_wakeup ? WF_MIGRATED : 0;
> > +             ttwu_do_activate(rq, p, wake_flags, &rf);
> > +             rq_unlock(rq, &rf);
> > +             activate_blocked_entities(rq, p, wake_flags);
>
> I'm unsure if it's a big deal, but IRQs are disabled here and
> activate_blocked_entities() disables them again.

Yeah. activate_blocked_entities() is also called from try_to_wakeup()
where we don't have irqs disabled, so we still need to make sure irqs
are off there.
But activate_blocked_entities does irqsave/restore so it should safely
put us back to the proper state. We could rq_unlock_irqrestore() in
the above, but it seems silly to enable irqs here just to disable them
shortly after.

But let me know if it seems I didn't quite get your concern here.


> > @@ -6663,19 +6797,6 @@ proxy_resched_idle(struct rq *rq, struct task_st=
ruct *next)
> >       return rq->idle;
> >   }
> >
> > -static bool proxy_deactivate(struct rq *rq, struct task_struct *next)
> > -{
> > -     unsigned long state =3D READ_ONCE(next->__state);
> > -
> > -     /* Don't deactivate if the state has been changed to TASK_RUNNING=
 */
> > -     if (state =3D=3D TASK_RUNNING)
> > -             return false;
> > -     if (!try_to_deactivate_task(rq, next, state, true))
>
> Now we can drop the last argument (deactivate_cond) of
> try_to_deactivate_task() since it can be determined via
> !task_is_blocked(p) I think. IOW:

True.  I'll add that into the "Drop proxy_deactivate" patch in my
fine-grained series.

Thanks again for the feedback!
-john