Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp8011594rdb; Thu, 4 Jan 2024 15:47:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWp8gS83ps2W7YfUdOhUtPG/n4jVifYYlGXW0Qsqoc5U+k/3adbXgR1Zt1XdghHbqFtZLg X-Received: by 2002:a17:906:40cf:b0:a28:e86f:242d with SMTP id a15-20020a17090640cf00b00a28e86f242dmr1218100ejk.30.1704412056977; Thu, 04 Jan 2024 15:47:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704412056; cv=none; d=google.com; s=arc-20160816; b=wbe9/nD4BwPOBFORizlr+TG7AVD1hr6kf0r3ZaDcH05E/jYbIXNrBJa9f7I5H873QA TQSZpUG6VeHfBeBpL4GkteNMvlh3c1k4xdLC6HTf8P+lmxzfdIKRrzHbHHGlg/j6NXK1 Xh8RwyHcmpDF0SUvwQTre3NkksKlbgKyhR+hauNtHvIOhpdGT0+oFtYBLaSNYyBSfpGX SnwZW6r/nsNvL+bayfVR8qlUu5ttXKXcoZgvklHl9kUTFlyWSpQVEzoJgn5UCv4PYpgJ Dj2N+9RAUn3WoRh6MH/cOgornngWLRuVtn/GmFulBnVlhj4241JYs6ETgj6nzeulNs6W csdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=PKIw7BcJSaypMdJBg4Njrm2KDvBf+rMCYg3A6sDiTso=; fh=F9t3gIz4Bbh5RZc5p2LcVlj5WBYATy7fRJ/j8vtEL6E=; b=mEgwyxmGOL+Tt/y/b7byrf3psbzlHoJS3Jeul8OZnMM1sVbclhwP12po4PSL+v3hee slGtfFDwOo/NE2oHK9ng9HZyJgWjUzVNUsUjAkkWD5aKj2BooniYusGkboIiWBec9JrS urx9RHjgpudcI736HwNon+OIcRihYb+BZ1KAHJUx9hHJaStg/nTZkT5SR/WM72iwMtgh xe9qWi1NMIGJjEdzCwLx4zo/YTy2hA90wooCcr4y6TgvGLQ4aPZ3wZXy5XN8Cjb2uKbT Xzhv41FD9XCofKkNqv37yW0sO7WbstWOKxyZcfFZ8f2qXk3e1f2Br8y2OkqZ009nPzfT Y+jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ETsWmnpX; spf=pass (google.com: domain of linux-kernel+bounces-17338-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17338-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id p20-20020a170906141400b00a2352d34076si137657ejc.470.2024.01.04.15.47.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 15:47:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-17338-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ETsWmnpX; spf=pass (google.com: domain of linux-kernel+bounces-17338-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17338-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B2CDD1F22D4D for ; Thu, 4 Jan 2024 23:47:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CA47F2D614; Thu, 4 Jan 2024 23:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ETsWmnpX" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 020022D600; Thu, 4 Jan 2024 23:47:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A670C433C8; Thu, 4 Jan 2024 23:47:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704412043; bh=PKIw7BcJSaypMdJBg4Njrm2KDvBf+rMCYg3A6sDiTso=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ETsWmnpXUD3YDF1/knK0iVgwfDEAd+0bbjKyhZVngHgIUVmY6Sn/gKd9Ywe14MFbD A4DMvgtg0jCAWwjYBsUDw3xz84vHRASIuvKF7+Nv+LTuOeBKEoPKWv05UGFrH653FH bRsHNqUExinSE4AjKApcCoYe2TbFPnfhQ1lv+KKowy8iPpqrWve2vqcBl29Tt8qtlw //G5vz7unSwEuIQlN7u9sdd9xCCLWPoHHYMgqsvrEoORUVomx80cViMgy41VGDkXNo VPiYxkCSVxdoGRNRkt3KLIFCR4SP8nRGVmzne8NO+U2QkVACLx3IOs1hTcKqUfac+W Uh3BK0vAKQjdw== Date: Thu, 4 Jan 2024 15:47:21 -0800 From: Jakub Kicinski To: Maxime Chevallier Cc: "Russell King (Oracle)" , patchwork-bot+netdevbpf@kernel.org, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, andrew@lunn.ch, edumazet@google.com, pabeni@redhat.com, linux-arm-kernel@lists.infradead.org, christophe.leroy@csgroup.eu, herve.codina@bootlin.com, f.fainelli@gmail.com, hkallweit1@gmail.com, vladimir.oltean@nxp.com, kory.maincent@bootlin.com, jesse.brandeburg@intel.com, corbet@lwn.net, kabel@kernel.org, piergiorgio.beruto@gmail.com, o.rempel@pengutronix.de, nicveronese@gmail.com, horms@kernel.org Subject: Re: [PATCH net-next v5 00/13] Introduce PHY listing and link_topology tracking Message-ID: <20240104154721.192694a8@kernel.org> In-Reply-To: <20240103153336.424dcfe3@device-28.home> References: <20231221180047.1924733-1-maxime.chevallier@bootlin.com> <170413442779.30948.3175948839165575294.git-patchwork-notify@kernel.org> <20240102105125.77751812@kernel.org> <20240103153336.424dcfe3@device-28.home> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 3 Jan 2024 15:33:36 +0100 Maxime Chevallier wrote: > I think this could help in reviewing the overall design and identifying > any glaring issue with this. The netlink handling looks a bit wobbly to me. I commented best I could in the 20min I had to look at this code :( I think it'd be best to revert, if you don't mind, because reviewing incremental fixes will get even harder.