Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp8028677rdb; Thu, 4 Jan 2024 16:33:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHvV4IVN9B3vVSh340ysV2gNPn7i9zjeZDsk0Rt5VfFzyEyQtTVk4UB+cLxOEjoOjSof3xp X-Received: by 2002:a05:620a:205d:b0:781:432a:3f83 with SMTP id d29-20020a05620a205d00b00781432a3f83mr1398987qka.23.1704414818760; Thu, 04 Jan 2024 16:33:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704414818; cv=none; d=google.com; s=arc-20160816; b=G7lD3wadzfIdn1M7gIowqwKCSggKbLezwXBwO9AyezK3zYwvx0Ond29hYIMDpkp+KZ rleSXTN4Vil1KWljxFgqsGBl9oug4Ilb1GVEauzLKsB/5SmqwMQb8VkqYxaxFi+nzWf2 NuTcACHTUeuhN9wXwbALpsCNwlksLUf7bTnXxFalzQB51+obVFrUpWbJwIPyaza7yD6x l05T1V6kHfwS6Iv4qK3iwKF0FwzNZR9CuBxriTJ6+tvK5FjM0ibA9ZPivP+A6/E0G+jG UYGLOQPwYI9fdzt04MBYjIp0mQGljJjAuQZ/GY7oTxXw8hXUqQO1rvmWG4+N2KS4SOMg M8Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=jW3PYuiGpDI9Y46QXBSVasJWKk1a/5VUlFNdiuTF92c=; fh=oNzeR09qD8dz2frvCCmRDLhX3q1FaEKWC1ntlyVU9mU=; b=feVOn2bZF6cjn0CihlZh6I7Pi8BJiaDIDDNqpuYUGm9sB9sVVC6Y6Asa3AJ9Dsd5nK 5SzJ2LGA8WkgSO7EFTrS5UuWpU9ia1a7ttU17DbVsNpDqi90g9NT9z7u7YTeFKD2+Dsj 1A54PQ/kZutAL8cMZ19nfMlzvNXragvFRq6M7nT3Sq0wyXhUqHmEXBPOsRg00OeqGJzK 2DeDcJWiJQbSfuzfuW2VNjn/hFlk0iSWD75cUr9QgnVaKqZ0EG6QAtShSziypiyEjoi6 9kUVtH04Cv+cKlogT1yec8suynDMXJIUWWE8eQlU5VHj574q1tyDNtvoOkR288cDaKZT Is0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=ernErT6u; spf=pass (google.com: domain of linux-kernel+bounces-17353-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17353-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id q5-20020a05620a0d8500b007815cd73b06si701976qkl.654.2024.01.04.16.33.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 16:33:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-17353-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=ernErT6u; spf=pass (google.com: domain of linux-kernel+bounces-17353-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17353-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7BDB51C21FFD for ; Fri, 5 Jan 2024 00:33:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 60F58110A; Fri, 5 Jan 2024 00:33:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="ernErT6u" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8248C1FA5 for ; Fri, 5 Jan 2024 00:33:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-556ea884968so1247714a12.3 for ; Thu, 04 Jan 2024 16:33:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1704414808; x=1705019608; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jW3PYuiGpDI9Y46QXBSVasJWKk1a/5VUlFNdiuTF92c=; b=ernErT6usSQRpmdsB80aw7LSVXlUr1RFLRLbmZLGyq9qYDV2huWTEHCJ8OkPclNIBx 1YmDlOUI+FIQ8Fsui7htTWqKaFbP6rm7ww1LRcMQTRdE99lClYmxiSL7wOofxV6jvgBe GP3CsM95Lq/z1lXynVyNRL6SZbO3ElSmiah48= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704414808; x=1705019608; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jW3PYuiGpDI9Y46QXBSVasJWKk1a/5VUlFNdiuTF92c=; b=ZiRis2YZzBZRh+2ElvHYX8+IZKzp2H8RcGIFg/4f4UA0ZZ68dPHub/AS4JYhlfCTBM K3nrXgjiDoC4g2gH5SKn+FKcvQ95C982i4mU6uYizR8p4HpQzeFG+ehEFsgmoA5gdIVr 9uqpCBGbYS0o4LkeRv0KETHngrm6V05w1l4UjxC72yKdtzA5lgurvDPBcW2JUvdxH+bU wJbac8TSNmmmMAALYxu3heww/70jTdcWfDwcKLHFg7C3ynBmNxtFiea2u6LtummYkjNW p09vBHeVIRVgPCK8mKVK84b1MqzhCVbgQgHDmNTRYV0+jpLyDZemrwCb7XyopGjbecwl Tj9w== X-Gm-Message-State: AOJu0YyB5X05tSJ15m82yr8lz0ojeWPyf1+qIzu74eLhy42CR77wGdkh ALRawFqhZoxAfMw9n1RZvWDfXF8V5hvdUA6993pSPquIe5DRHCqF X-Received: by 2002:aa7:d306:0:b0:540:4c04:ab94 with SMTP id p6-20020aa7d306000000b005404c04ab94mr773299edq.42.1704414808696; Thu, 04 Jan 2024 16:33:28 -0800 (PST) Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com. [209.85.218.44]) by smtp.gmail.com with ESMTPSA id d8-20020a50fb08000000b0055350d989dasm285657edq.88.2024.01.04.16.33.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 16:33:28 -0800 (PST) Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a28005f9b9cso122455366b.3 for ; Thu, 04 Jan 2024 16:33:27 -0800 (PST) X-Received: by 2002:a17:906:489a:b0:a27:7da8:aaee with SMTP id v26-20020a170906489a00b00a277da8aaeemr676587ejq.12.1704414807557; Thu, 04 Jan 2024 16:33:27 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20230920192300.3772199-1-goldstein.w.n@gmail.com> <202309231130.ZI5MdlDc-lkp@intel.com> In-Reply-To: From: Linus Torvalds Date: Thu, 4 Jan 2024 16:33:10 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: x86/csum: Remove unnecessary odd handling To: Noah Goldstein Cc: David Laight , kernel test robot , "x86@kernel.org" , "oe-kbuild-all@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "edumazet@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "hpa@zytor.com" Content-Type: text/plain; charset="UTF-8" On Thu, 4 Jan 2024 at 15:36, Linus Torvalds wrote: > > Anyway, since I looked at the thing originally, and feel like I know > the x86 side and understand the strange IP csum too, I just applied it > directly. I ended up just applying my 40-byte cleanup thing too that I've been keeping in my own tree since posting it (as the "Silly csum improvement. Maybe" patch). I've been running it on my own machine since last June, and I finally even enabled the csum KUnit test just to double-check it. Linus