Received-SPF: pass (google.com: domain of linux-kernel+bounces-17418-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 5 Jan 2024 03:25:30 +0100
From: Andrew Lunn <andrew@lunn.ch>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	William Zhang <william.zhang@broadcom.com>,
	Anand Gore <anand.gore@broadcom.com>,
	Kursad Oney <kursad.oney@broadcom.com>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	=?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	=?iso-8859-1?Q?Fern=E1ndez?= Rojas <noltari@gmail.com>,
	Sven Schwermer <sven.schwermer@disruptive-technologies.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	netdev@vger.kernel.org
Subject: Re: [net-next PATCH v8 3/5] net: phy: add support for PHY LEDs
 polarity modes
Message-ID: <957df01b-bb92-4f8a-9f2b-aacd3de1208d@lunn.ch>
References: <20240104110114.2020-1-ansuelsmth@gmail.com>
 <20240104110114.2020-4-ansuelsmth@gmail.com>
 <47f18def-d34f-4224-9de2-6e0ae7122a52@lunn.ch>
 <6597286c.050a0220.4684a.182e@mx.google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6597286c.050a0220.4684a.182e@mx.google.com>

> > > +	 * @dev: PHY device which has the LED
> > > +	 * @index: Which LED of the PHY device or -1
> > > +	 * @modes: bitmap of LED polarity modes
> > > +	 *
> > > +	 * Configure LED with all the required polarity modes in @modes
> > > +	 * to make it correctly turn ON or OFF.
> > 
> > index == -1 should be explained.
> >
> 
> If you are referring to the special way of setting the LED globally,
> that is not a thing anymore. Rob pointed out that having the double
> reference in DT is problematic and PHY driver should handle that
> internally.

So it sounds like you need to change

> > > +	 * @index: Which LED of the PHY device or -1

to remove the 'or -1'

   Andrew