Received-SPF: pass (google.com: domain of linux-kernel+bounces-17483-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231220001856.3710363-1-jstultz@google.com> <20231220001856.3710363-18-jstultz@google.com>
 <4cdaca00-dc4e-4ac0-a362-56b90ca584f0@arm.com>
In-Reply-To: <4cdaca00-dc4e-4ac0-a362-56b90ca584f0@arm.com>
From: John Stultz <jstultz@google.com>
Date: Thu, 4 Jan 2024 21:20:02 -0800
Message-ID: <CANDhNCqgiiZSVUn7erAgQ0y3kDsRrqRq2B8qx9JLJQkd-bTP2Q@mail.gmail.com>
Subject: Re: [PATCH v7 17/23] sched: Initial sched_football test implementation
To: Metin Kaya <metin.kaya@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Joel Fernandes <joelaf@google.com>, 
	Qais Yousef <qyousef@google.com>, Ingo Molnar <mingo@redhat.com>, 
	Peter Zijlstra <peterz@infradead.org>, Juri Lelli <juri.lelli@redhat.com>, 
	Vincent Guittot <vincent.guittot@linaro.org>, Dietmar Eggemann <dietmar.eggemann@arm.com>, 
	Valentin Schneider <vschneid@redhat.com>, Steven Rostedt <rostedt@goodmis.org>, 
	Ben Segall <bsegall@google.com>, Zimuzo Ezeozue <zezeozue@google.com>, 
	Youssef Esmat <youssefesmat@google.com>, Mel Gorman <mgorman@suse.de>, 
	Daniel Bristot de Oliveira <bristot@redhat.com>, Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>, 
	Boqun Feng <boqun.feng@gmail.com>, "Paul E. McKenney" <paulmck@kernel.org>, 
	Xuewen Yan <xuewen.yan94@gmail.com>, K Prateek Nayak <kprateek.nayak@amd.com>, 
	Thomas Gleixner <tglx@linutronix.de>, kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 22, 2023 at 1:32=E2=80=AFAM Metin Kaya <metin.kaya@arm.com> wro=
te:
>
> On 20/12/2023 12:18 am, John Stultz wrote:
> > Reimplementation of the sched_football test from LTP:
> > https://github.com/linux-test-project/ltp/blob/master/testcases/realtim=
e/func/sched_football/sched_football.c
> >
> > But reworked to run in the kernel and utilize mutexes
> > to illustrate proper boosting of low priority mutex
> > holders.
> >
> > TODO:
> > * Need a rt_mutex version so it can work w/o proxy-execution
> > * Need a better place to put it
>
> I think also this patch can be upstreamed regardless of other Proxy
> Execution patches, right?

Well, we would need to use rt_mutexes for the !PROXY case to validate
inheritance.
But something like it could be included before PROXY lands.

> > + *
> > + * This is done via having N offsensive players that are
>
>                                  offensive

Fixed.

> > + * medium priority, which constantly are trying to increment the
> > + * ball_pos counter.
> > + *
> > + * Blocking this, are N defensive players that are higher
> > + * priority which just spin on the cpu, preventing the medium
> > + * priroity tasks from running.
>
>        priority

Fixed.

> > +atomic_t players_ready;
> > +atomic_t ball_pos;
> > +int players_per_team;
>
> Nit: Number of players cannot be lower than 0. Should it be unsigned then=
?

Fixed.

> > +bool game_over;
> > +
> > +struct mutex *mutex_low_list;
> > +struct mutex *mutex_mid_list;
> > +
> > +static inline
> > +struct task_struct *create_fifo_thread(int (*threadfn)(void *data), vo=
id *data,
> > +                                    char *name, int prio)
> > +{
> > +     struct task_struct *kth;
> > +     struct sched_attr attr =3D {
> > +             .size           =3D sizeof(struct sched_attr),
> > +             .sched_policy   =3D SCHED_FIFO,
> > +             .sched_nice     =3D 0,
> > +             .sched_priority =3D prio,
> > +     };
> > +     int ret;
> > +
> > +     kth =3D kthread_create(threadfn, data, name);
> > +     if (IS_ERR(kth)) {
> > +             pr_warn("%s eerr, kthread_create failed\n", __func__);
>
> Extra e at eerr?

Fixed.


> > +             return kth;
> > +     }
> > +     ret =3D sched_setattr_nocheck(kth, &attr);
> > +     if (ret) {
> > +             kthread_stop(kth);
> > +             pr_warn("%s: failed to set SCHED_FIFO\n", __func__);
> > +             return ERR_PTR(ret);
> > +     }
> > +
> > +     wake_up_process(kth);
> > +     return kth;
>
> I think the result of this function is actually unused. So,
> create_fifo_thread()'s return type can be void?

It's not used, but it probably should be. At least I should be
checking for the failure cases. I'll rework to fix this.


> > +
> > +int offense_thread(void *)
>
> Does this (no param name) build fine on Android env?

Good point, I've only been testing this bit with qemu. I'll fix it up.

> > +int ref_thread(void *arg)
> > +{
> > +     struct task_struct *kth;
> > +     long game_time =3D (long)arg;
> > +     unsigned long final_pos;
> > +     long i;
> > +
> > +     pr_info("%s: started ref, game_time: %ld secs !\n", __func__,
> > +             game_time);
> > +
> > +     /* Create low  priority defensive team */
>
> Sorry: extra space after `low`.

Fixed.

> > +     mutex_low_list =3D kmalloc_array(players_per_team,  sizeof(struct=
 mutex), GFP_ATOMIC);
> > +     mutex_mid_list =3D kmalloc_array(players_per_team,  sizeof(struct=
 mutex), GFP_ATOMIC);
>
> * Extra space after `players_per_team,`.
> * Shouldn't we check result of `kmalloc_array()`?
>
> Same comments for `mutex_low_list` (previous) line.

Yep.

Thanks for all the suggestions!
-john