Received: by 2002:a05:7412:b995:b0:f9:9502:5bb8 with SMTP id it21csp8115819rdb; Thu, 4 Jan 2024 21:22:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEft9ngQCwXev9lphnW2QzLwhI2lMqQEUhatp40ysCp82FP0BWMeNhCCmdh3+WyUYiY4e3A X-Received: by 2002:a05:6830:56:b0:6dc:14c6:cb42 with SMTP id d22-20020a056830005600b006dc14c6cb42mr1682660otp.65.1704432156828; Thu, 04 Jan 2024 21:22:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704432156; cv=none; d=google.com; s=arc-20160816; b=Le0DSR/hUcICw9Ns+9gikIbFR/dmcZlOTpeTzo2xquMevM803vR1U6W7EOlYm/NHHJ sPF9OMWYYN2e7obLcLmDsO7/yHDuMefyKx+ssRF8WoWOaZVMbq1kszD9mli3oZnTmrB2 +pRnfXK0FCSWCF7iyJ76/cjDxJWbnQ9dPEJGWh6t2UJEcajLnN48OYuBpAsEK7r9tt5r eFNCKbF5GdYfSE3oS3/QPWXwyS6se4DRIe+/NmBr+OqYibgRoVEIRdydKRBOmmYqktiF nC0psmDY8Y0mZfulSa+TBajK0VQFtWJztVEjndtb2M1BNaQ8GO5fFtpaD7miBdAqOr6m 3LrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=Prv2KfoPdbRkHa0MBG1J/qgAyoY3a84lfxo+6B3V+LE=; fh=BNf93qThzKvcNrUblroeKiFR5/RdNi9rwKlfD7f6Nmg=; b=0ZVSK+4PlEFhYwv/3KEYKfF/uhcNL3jmXuTF8fWOc14OObm3/JwnHjaDd6rfNvXStQ x95yzn/pQ9UfU9EN29W0oAkjG6G4bjThT2Mex2RFI1E7XY84gCnu1SwOsR7Vhx8jb4nY 4dKU803MC4CHo5T6VJwM3mQ4dUHth6CD+MGt1ajZTKYC8R3d0s+RdFURXsEj790mx8mu X71RXUbEyVMoGXkKliV98hzhb55KedS3up3TVF8gOFQVWFUCoclCSNlGEqw6LTb+1rbt RTi8HD6IYk/CCx1tEmvC6Zr9m+RD4xEg20AB2det9rul+ZOajzpQ1kcbjBC2SBeM+XlY Lyeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=HT171pWs; spf=pass (google.com: domain of linux-kernel+bounces-17484-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17484-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id t16-20020a639550000000b005cd84983a5asi698652pgn.721.2024.01.04.21.22.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 21:22:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-17484-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=HT171pWs; spf=pass (google.com: domain of linux-kernel+bounces-17484-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17484-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 763D9B21C68 for ; Fri, 5 Jan 2024 05:22:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E883853B5; Fri, 5 Jan 2024 05:22:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HT171pWs" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE56B539C for ; Fri, 5 Jan 2024 05:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-40d5097150fso19335e9.1 for ; Thu, 04 Jan 2024 21:22:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1704432143; x=1705036943; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Prv2KfoPdbRkHa0MBG1J/qgAyoY3a84lfxo+6B3V+LE=; b=HT171pWsM76bMo37Gdj4eb1OURy5M2a/lGatwInGT+rqxFbCYAnaPqOgSZJvlBNRZZ ZidFaXt4MOWGsaJbaLm5JijiC4GzK09FQXaMYfmD1iFmQ++9nCmOfFgJ3Y3MT78mgRPt pzABQu7PrfFs97a7KD7g7caukTM3UJYpO4RsvbOEsnfGLsaVok6xyOtm4BvtwHhdZUG/ yHY/gCYVnRS1qq91uulre9LfuYdnvtT4Rt2VsxpL6rn+YZ1lxuprClDFH/WSyuCItGDi cqR9JT8wj6b47dYjsmIsfOnROYOSyDU01EFV9hIy6PZK9+RdnIhUT0VmfY37jKuQ89Mg ZO6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704432143; x=1705036943; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Prv2KfoPdbRkHa0MBG1J/qgAyoY3a84lfxo+6B3V+LE=; b=pBpabO+Ry4eS0npquuZh9gnosELLXWdFa2HOLegIdMuZYssQqcoLTs47UtRJ1HL28c ST89VmeKzAsifHyYAIFfaVOs+neb2CnXZh9eLP5oIzlUC9AG0j4gPGIJGt0HcwJvPFXt jkMuiEZzswW4rHZtFNe33BqaJomP3+PbSa0vuzdoMMfTW14bxsNwoYboJCp9bl36N0ys xEuCqgHNw8/C2GLYfSj/YgQgFmy4GfwnLgYYg466XNndw+ZIVTp9L+3Q+4NWgaiYN6vf fZzN0DI417LQefXcZ2vzZpRL3mRza6LPbwYwW8J/6fKaIj1Srw/f9JUNOIgR3TTUMuNN Nrkg== X-Gm-Message-State: AOJu0Yz7xqo10j4QiBb9ArFaBH9gf/+yNPSJcGVzHK4x2bzO1J6MqAaG BM9AsdoYZB/pzDWAjw9lDWqvhK5cnMCWR+xAT/dxPN7R/mQ= X-Received: by 2002:a05:600c:511c:b0:40d:5af5:3233 with SMTP id o28-20020a05600c511c00b0040d5af53233mr94425wms.2.1704432142832; Thu, 04 Jan 2024 21:22:22 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231220001856.3710363-1-jstultz@google.com> <20231220001856.3710363-18-jstultz@google.com> <9dbcc5ed-8994-4929-9ac5-18b13c01eb2c@arm.com> In-Reply-To: <9dbcc5ed-8994-4929-9ac5-18b13c01eb2c@arm.com> From: John Stultz Date: Thu, 4 Jan 2024 21:22:10 -0800 Message-ID: Subject: Re: [PATCH v7 17/23] sched: Initial sched_football test implementation To: Metin Kaya Cc: LKML , Joel Fernandes , Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Youssef Esmat , Mel Gorman , Daniel Bristot de Oliveira , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Xuewen Yan , K Prateek Nayak , Thomas Gleixner , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Dec 28, 2023 at 7:19=E2=80=AFAM Metin Kaya wro= te: > On 20/12/2023 12:18 am, John Stultz wrote: > > +static int __init test_sched_football_init(void) > > +{ > > + struct task_struct *kth; > > + int i; > > + > > + players_per_team =3D num_online_cpus(); > > + > > + mutex_low_list =3D kmalloc_array(players_per_team, sizeof(struct= mutex), GFP_ATOMIC); > > + mutex_mid_list =3D kmalloc_array(players_per_team, sizeof(struct= mutex), GFP_ATOMIC); > > + > > + for (i =3D 0; i < players_per_team; i++) { > > + mutex_init(&mutex_low_list[i]); > > + mutex_init(&mutex_mid_list[i]); > > + } > > + > > + kth =3D create_fifo_thread(ref_thread, (void *)10, "ref-thread", = 20); > > + > > + return 0; > > +} > > +module_init(test_sched_football_init); > > Hit `modpost: missing MODULE_LICENSE() in > kernel/sched/test_sched_football.o` error when I build this module. > > JFYI: the module does not have MODULE_NAME(), MODULE_DESCRIPTION(), > MODULE_AUTHOR(), module_exit(), ... as well. Good point. I've only been using it as a built-in. Added all of those except for module_exit() for now, as I don't want it to be unloaded while the kthreads are running. thanks -john