Received-SPF: pass (google.com: domain of linux-kernel+bounces-17484-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20231220001856.3710363-1-jstultz@google.com> <20231220001856.3710363-18-jstultz@google.com>
 <9dbcc5ed-8994-4929-9ac5-18b13c01eb2c@arm.com>
In-Reply-To: <9dbcc5ed-8994-4929-9ac5-18b13c01eb2c@arm.com>
From: John Stultz <jstultz@google.com>
Date: Thu, 4 Jan 2024 21:22:10 -0800
Message-ID: <CANDhNCo_U50+Ov2TzzD+jnDHKms8Wej3ypLsSS6PGNoEier8KQ@mail.gmail.com>
Subject: Re: [PATCH v7 17/23] sched: Initial sched_football test implementation
To: Metin Kaya <metin.kaya@arm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Joel Fernandes <joelaf@google.com>, 
	Qais Yousef <qyousef@google.com>, Ingo Molnar <mingo@redhat.com>, 
	Peter Zijlstra <peterz@infradead.org>, Juri Lelli <juri.lelli@redhat.com>, 
	Vincent Guittot <vincent.guittot@linaro.org>, Dietmar Eggemann <dietmar.eggemann@arm.com>, 
	Valentin Schneider <vschneid@redhat.com>, Steven Rostedt <rostedt@goodmis.org>, 
	Ben Segall <bsegall@google.com>, Zimuzo Ezeozue <zezeozue@google.com>, 
	Youssef Esmat <youssefesmat@google.com>, Mel Gorman <mgorman@suse.de>, 
	Daniel Bristot de Oliveira <bristot@redhat.com>, Will Deacon <will@kernel.org>, Waiman Long <longman@redhat.com>, 
	Boqun Feng <boqun.feng@gmail.com>, "Paul E. McKenney" <paulmck@kernel.org>, 
	Xuewen Yan <xuewen.yan94@gmail.com>, K Prateek Nayak <kprateek.nayak@amd.com>, 
	Thomas Gleixner <tglx@linutronix.de>, kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 28, 2023 at 7:19=E2=80=AFAM Metin Kaya <metin.kaya@arm.com> wro=
te:
> On 20/12/2023 12:18 am, John Stultz wrote:
> > +static int __init test_sched_football_init(void)
> > +{
> > +     struct task_struct *kth;
> > +     int i;
> > +
> > +     players_per_team =3D num_online_cpus();
> > +
> > +     mutex_low_list =3D kmalloc_array(players_per_team,  sizeof(struct=
 mutex), GFP_ATOMIC);
> > +     mutex_mid_list =3D kmalloc_array(players_per_team,  sizeof(struct=
 mutex), GFP_ATOMIC);
> > +
> > +     for (i =3D 0; i < players_per_team; i++) {
> > +             mutex_init(&mutex_low_list[i]);
> > +             mutex_init(&mutex_mid_list[i]);
> > +     }
> > +
> > +     kth =3D create_fifo_thread(ref_thread, (void *)10, "ref-thread", =
20);
> > +
> > +     return 0;
> > +}
> > +module_init(test_sched_football_init);
>
> Hit `modpost: missing MODULE_LICENSE() in
> kernel/sched/test_sched_football.o` error when I build this module.
>
> JFYI: the module does not have MODULE_NAME(), MODULE_DESCRIPTION(),
> MODULE_AUTHOR(), module_exit(), ... as well.

Good point. I've only been using it as a built-in.
Added all of those except for module_exit() for now, as I don't want
it to be unloaded while the kthreads are running.

thanks
-john