Received-SPF: pass (google.com: domain of linux-kernel+bounces-17545-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Shinas Rasheed <srasheed@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Haseeb Gani
	<hgani@marvell.com>, Vimlesh Kumar <vimleshk@marvell.com>,
        Sathesh B Edara
	<sedara@marvell.com>,
        "egallen@redhat.com" <egallen@redhat.com>,
        "mschmidt@redhat.com" <mschmidt@redhat.com>,
        "pabeni@redhat.com"
	<pabeni@redhat.com>,
        "horms@kernel.org" <horms@kernel.org>,
        "wizhao@redhat.com" <wizhao@redhat.com>,
        "kheib@redhat.com"
	<kheib@redhat.com>,
        "konguyen@redhat.com" <konguyen@redhat.com>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Satananda Burla
	<sburla@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet
	<edumazet@google.com>
Subject: RE: [EXT] Re: [PATCH net-next v2 6/8] octeon_ep_vf: add Tx/Rx
 processing and interrupt support
Thread-Topic: [EXT] Re: [PATCH net-next v2 6/8] octeon_ep_vf: add Tx/Rx
 processing and interrupt support
Thread-Index: AQHaNaXX1bcgGLi5HEmdzaZKEl99WrDKNr0AgACszRA=
Date: Fri, 5 Jan 2024 07:26:14 +0000
Message-ID: 
 <PH0PR18MB473450986CAA852218F225F0C7662@PH0PR18MB4734.namprd18.prod.outlook.com>
References: <20231223134000.2906144-1-srasheed@marvell.com>
	<20231223134000.2906144-7-srasheed@marvell.com>
 <20240104130016.47bc1071@kernel.org>
In-Reply-To: <20240104130016.47bc1071@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?m2DqRRJYODEPugSMJT5ZaB0RKBpYBRse77q+0IfcHo8ljGYXdlfAc4awpkkD?=
 =?us-ascii?Q?Y9p2yhpNkavUTMETd3p94f8Bch6NNhJsLl4hUDqAhCwB2Mb/sqU962BHUeow?=
 =?us-ascii?Q?FGuNocayrFRZRIMj6jL5YF5p4Rx24qB6e/hruyi0K+/Gcej5w9uf0/9tFKUy?=
 =?us-ascii?Q?MN8p7EtyYfh4pVXRuY+npas6fzKinYZZSbmu0ffVO+aBMuP5WfW42/2BhiA1?=
 =?us-ascii?Q?bVd/LFfgI9KAd02zYKNMEcOhlyZUZ/ZhFKG0swaqrow+s27Zku60dexpXNvx?=
 =?us-ascii?Q?Gz4BofDqjPsj92JDK+CdPVm+AjYoB8qFqdzwFToAaCP7aXrL75b6yTGB4S4a?=
 =?us-ascii?Q?V0frgooWJAEDxXRjKIEZIeVPjXl53nf9fU90whnh9at6aUkT9tUYQlE/Adlj?=
 =?us-ascii?Q?VDnuk0Yg86aZdt6tBRXuN5NoIxepc//Ef5oaN4W9h4RvYu8Idh417/EWwi1L?=
 =?us-ascii?Q?vUWX2w5nrl+JSVHswmPP4TnoH3LKR6P/7TMCZGSBsdk9H9CImqJocg3m9RYl?=
 =?us-ascii?Q?RiWFHWpMva6860vE96ShfJ0W/wcKNMPmPDKRk5QCBSmMSnAfYjvKR6MnZG5o?=
 =?us-ascii?Q?OuX+1JREH6PTpSzSgAEmT0F1Z3tk+X3PHnIRedAt+y7cCBjzGYZv+g38W6k3?=
 =?us-ascii?Q?7FiLePTlbe2mC5Ow/PidTP+FtIyAAIDNyfgROFSDpdZj2EMwDQdgalwXz51G?=
 =?us-ascii?Q?6vD5w7kks6ZRir8GTVNA4I54LuWt24v709VARZVQAAIKSopr6q/emf6NWuqv?=
 =?us-ascii?Q?LTrdkfgEyiEDZAzqLmuaTWtXu/11IFGyFl4gZGVis5gmkGPKKm7zTaESbCFd?=
 =?us-ascii?Q?vvNPqtJv+Dh0XV+xK9buPdUacsfX/a7z4KEAF6+qWGzd9HUpQi0WMfSS90zn?=
 =?us-ascii?Q?5f7S1O29tQktBOA/bFaNftVIFhqrkb1l04+eTHsKGywfO6Jo9PugP+Cc37mq?=
 =?us-ascii?Q?i40yp44gzKav37llEGL7Rf5GMs3d4ODBgCpWBcfi+UcvA6SEYCpYj+zjWxI0?=
 =?us-ascii?Q?jlv/NisIkt2NpU3OaMiXGW0EqKsYiIxFlC7paBzBholdsIpG1EHTj1I8fnqi?=
 =?us-ascii?Q?F5gKgqEUR4xRcpo2vmibcNWDXVOokwHy9qsVHvd779SS5P5Knt0Hm0boOJKQ?=
 =?us-ascii?Q?hHcRLqTnSd2sSChVbvuH5rAH0xnRMw8BEvwinqTXJ19W0JobXeNYQxyS9h75?=
 =?us-ascii?Q?Erp3PbFpT+ThOQ9jGCKbjNJ1IzZwu7hnjRPQ55CZUPsZisE+akT2wNB57yUK?=
 =?us-ascii?Q?KzO9JumubFlfk2UwcXoJsEw6TLWbkmvOlHk/twKQAgIZBH1/lTCbZURE3vbE?=
 =?us-ascii?Q?JGqKG4u1keDcGCxbhIqsguCi6FBVUgakTE8siuYX8qbHSYiObDxSonvzULld?=
 =?us-ascii?Q?f5ZWSmPNTIzVKnxu5UI/M+frs597/JH+A9jubEkktz1rPl8OqEvVv8lEvU8W?=
 =?us-ascii?Q?OTvAe8zA7gKkuVLlKfxIEOik7kkghS4sZyl2AI7ZeVyjIMs4TFXEt4m/SGmd?=
 =?us-ascii?Q?8BqNNwCzSGg3mpsyGyoody39e7Nn1RPHra6WCU1fJn7R/2Bc5XpkW0lsQunG?=
 =?us-ascii?Q?v9T8fwiCkxNfABCRDrJSu+wLk5Sbha/sy7+eVO05?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4734.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d260bd4e-4e2f-4871-6eec-08dc0dbf99b7
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2024 07:26:14.8050
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MosjrfrRRhT17BTFbvH9nD8V9lRTJyJnMfdapid+PiL5gxQuXm+QQA2iWUDrPbqQkeBqWEXizVla9HMX08SKZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR18MB5308
X-Proofpoint-GUID: Vslqs7rXUzxF4fv_S_TgB9rYWs4SPfyn
X-Proofpoint-ORIG-GUID: Vslqs7rXUzxF4fv_S_TgB9rYWs4SPfyn
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-09_02,2023-12-07_01,2023-05-22_02

Hi Jakub,

Thanks for the review!

> > +	rx_done =3D octep_vf_oq_process_rx(ioq_vector->oq, budget);
>=20
> You should not call Rx processing if budget is 0 at all, please see
> NAPI docs. Looks like the function may try to refill Rx buffers with
> budget of 0.
>=20
If budget is zero, octep_vf_oq_process_rx just wouldn't try to query hw for=
 packets. Also since by then, the refill count should have been less than r=
efill threshold, if not it only flushes free buffers back to the ring, (and=
 tell hw that there are more free buffers available which have been process=
ed from maybe previous calls - but this seems unlikely and should have been=
 flushed at that time).=20

> > @@ -114,8 +158,8 @@ static int octep_vf_setup_oq(struct octep_vf_device
> *oct, int q_no)
> >  		goto desc_dma_alloc_err;
> >  	}
> >
> > -	oq->buff_info =3D (struct octep_vf_rx_buffer *)
> > -			vzalloc(oq->max_count *
> OCTEP_VF_OQ_RECVBUF_SIZE);
> > +	oq->buff_info =3D vzalloc(oq->max_count *
> OCTEP_VF_OQ_RECVBUF_SIZE);
> > +
>=20
> bad fixup squash?
>=20
Sorry, I didn't understand. Can you explain?