Received-SPF: pass (google.com: domain of linux-kernel+bounces-17571-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f515b323-a932-41c9-8d06-5310c8eea248@amd.com>
Date: Fri, 5 Jan 2024 13:40:42 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: arch/x86/events/amd/uncore.c:941:52: error: '%d' directive output
 may be truncated writing between 1 and 10 bytes into a region of size 8
To: kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
 Peter Zijlstra <peterz@infradead.org>
References: <202401051554.teOdw8yt-lkp@intel.com>
Content-Language: en-US
From: Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <202401051554.teOdw8yt-lkp@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OC9DRU10cEJVNkFrSWd2SmV2M0kwU3lTNnBQdis5c0tSSzdPVVdkZVdMQmNT?=
 =?utf-8?B?NXRRYy9JZHA5QjdBZXBtazNDdFZydHdOM1lLZEZtSCtqVmsxaDRxcmo2dkk1?=
 =?utf-8?B?NXQvRzBUVGFLWlZvb2MxV0U2MEtrZzZJSzdIUGpWV0dTZzA0Tnk4SHd4Q1RD?=
 =?utf-8?B?UVQ4bExHWWtQSGZDcTFOVW93VFJodUV3bGxJWFZ4Y1JObWRwT0pwSE5mbGor?=
 =?utf-8?B?SEo2eHRjVjRBVTZkOCtaVk5NcEwrbkhhb2R6NnpjZU1lcUdNWG90TGNuOXY5?=
 =?utf-8?B?ZGoxNks3MHE4bGZ3dktOSTlYY3ZENmhJT0dNa1hKQllrVFQ5eWYvVlBCUWpR?=
 =?utf-8?B?eVRGOFJOWWw0cWlNbUI0QWk5OHJBM0tzVDQ0czJ6bFllMmdjR3l1b3J4Qmxh?=
 =?utf-8?B?cURsL2dIT0ZXelVwYm45ZkhoMjJDNFl3enNad3ZocEIxTlVlUnQrTmI3Z0tu?=
 =?utf-8?B?dklBWWFpSGg5a2dXcHpIOExnQmZYUHRnR1pqSVAxV3YxanJlU0R4OWpmcGg5?=
 =?utf-8?B?MEIxM2YyUmkrZllOWFN5OFFGYThJSUZVYzR0c3daalVabnVUM1hPMTA1Vm9K?=
 =?utf-8?B?bGlTNVBYTm41MUNjQmh2cEd2Sm91ZlRpcnpTdjZvcENidFlWQVBIYjltWklh?=
 =?utf-8?B?bmxBSzFVbEJ6c3VaVXZsVFF3ZWZoYkhiN2xjOE5GeXpJd0l2WFdzOWhaSjVm?=
 =?utf-8?B?K3NVbm9WbGtlbUpYd1o5S2NVVENoazl3a3RlV3phdG9nZmR1MTRzaHVlZFl1?=
 =?utf-8?B?dE9sRXR2YmRaMVZLMUpWOE92TjgyejZuUmlXUDIzRUh3eDA5UDhVemltLzAx?=
 =?utf-8?B?c3huNWc1U2JESnRmWnRPQUdqY21wejdFUDRwTjZGcVlEWHM3YTVOa2k4UENt?=
 =?utf-8?B?R1I5Y3hUclpTUTM4Rkp3L0luSVJUSjZvVnpDcld5Y1E4Y1NKcjM5QW1nTUdm?=
 =?utf-8?B?WEVqRVN0YkRjUW0vYUxYeUx4SEJZcmg5STBnb1BOajYwdENsR3AyNGtyenZB?=
 =?utf-8?B?V0QrTWl1bGhXZHhVUUk0UHdBNDlKQTFRQXp4dkhmMEhzRFhubktnZXJoellU?=
 =?utf-8?B?M1d5cG5rUENVdUdWc05ubWkrWGxmUjJKYzg1dldFdjREd05XS3VlejFiYnNE?=
 =?utf-8?B?elczY3pZd1NvTlVmRDUxc2V6d1lDaEVSVDFQclBZR2FpMVI3bDFRSlFmQ0tm?=
 =?utf-8?B?VXZVTzRFMGoyM0F6WEYzVjBZWmk0bTFYMzVHYTdJM1NMOTRlZnc3Rjd5b0hu?=
 =?utf-8?B?cEVTdjl0MXdHTmtrSmM4aGR2d3RJbE1HRnFsODd0cFJPaDhXQUwrWGlhc1Ft?=
 =?utf-8?B?NkdadmZVZVdjYW9WVnZkTyswV3VZYjZFZ01zcERiQTZ4RCtIdWZNbm9uMXNP?=
 =?utf-8?B?OW4zYmJVc2s4QUEvRGZDQ2tCWW9RbW9YYk1jOVpwTy9QY0xUNVhIQnJxOWZQ?=
 =?utf-8?B?cnFudld2cnZaOFdwNlpaNy9EdktIUzRXWVY2OFVHSlZ2K2RPU2lSTElqQ3pW?=
 =?utf-8?B?U01PVldwSHFKWi82MzFyemJucTYvSXM4NThyQk84V21yc0dKdFBFSUNBOWI5?=
 =?utf-8?B?LysvbGc3SVhUajJwOWcvRkFEME5UMlFBSGFOSnRZLzdDVzVLdld5Sk9xcVBz?=
 =?utf-8?B?bE56ejl3cytLRzFrVHpsZ3BoR2RqZW5UY1lwM0JhUEdGeEd6QVV0dXdtbGo0?=
 =?utf-8?B?bWd1Y2xTTnpUN2laTGZiN3JSd0FvYmhnaE1GZHJyYnd1cmFFbFphNzNjc2dI?=
 =?utf-8?B?blFMUVdwR05ZSmpNMFdOWFVCSXg3L0ozN1hiNUV5VU1FOWpuakV2elZpN2FF?=
 =?utf-8?B?N3VWMTlLOUR1alNHZjBheXBnb2hxanFIWGVETURQQ1EzT0ZkRmFYcDFpWFhz?=
 =?utf-8?B?elNETjVRR2VKTVFUYkl5VTlwNHhFWnIxRzg4ckUzV2s4T3BKU1lmei9pWitI?=
 =?utf-8?B?SjRKcU0vdVJGemVMakN1YjgzcHJEclgvdUtkRzh2VFBQb1E3UHEyTDJSUTc5?=
 =?utf-8?B?WkJ1Qkx3UHlPOE0zdytZWkJ3SUdvak8vOUJXcDhnVGJLZHNWeW8vVE9KeTBD?=
 =?utf-8?B?OExDQzEzYzN4SE9RelRnT1hGck0rY0ltQit5M0Z0aEV1MFJWcll2K0pwcTNL?=
 =?utf-8?Q?+JSeGDJoDqkaeXd1Fr00iTr98?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 365215aa-7337-48a1-31ff-08dc0dc5d504
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 08:10:51.6791
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RywVsfptkGKgqn4EXbTsDKjKpD2nujw3qNGmrOhtaMubxXyVJW0S1DZaviruPX4N+ErOezr60Lw8UImJ6NF+Fw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5190

Hi,

On 1/5/2024 1:20 PM, kernel test robot wrote:
> Hi Sandipan,
> 
> FYI, the error/warning still remains.
> 

The active UMCs in a socket are represented by a 32 bit mask coming from CPUID 0x80000022 ECX.
Since there are at most 2 sockets in a system, the maximum number of UMCs will not exceed 64.
This fits in pmu->name. While there may be SKUs in the future having more UMCs, the number is
not expected to be larger than a 7 digit integer.

- Sandipan

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   1f874787ed9a2d78ed59cb21d0d90ac0178eceb0
> commit: 25e56847821f7375bdee7dae1027c7917d07ce4b perf/x86/amd/uncore: Add memory controller support
> date:   3 months ago
> config: x86_64-sof-customedconfig-avs-defconfig (https://download.01.org/0day-ci/archive/20240105/202401051554.teOdw8yt-lkp@intel.com/config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240105/202401051554.teOdw8yt-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202401051554.teOdw8yt-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    arch/x86/events/amd/uncore.c: In function 'amd_uncore_umc_ctx_init':
>>> arch/x86/events/amd/uncore.c:941:52: error: '%d' directive output may be truncated writing between 1 and 10 bytes into a region of size 8 [-Werror=format-truncation=]
>        snprintf(pmu->name, sizeof(pmu->name), "amd_umc_%d", index);
>                                                        ^~
>    arch/x86/events/amd/uncore.c:941:43: note: directive argument in the range [0, 2147483647]
>        snprintf(pmu->name, sizeof(pmu->name), "amd_umc_%d", index);
>                                               ^~~~~~~~~~~~
>    arch/x86/events/amd/uncore.c:941:4: note: 'snprintf' output between 10 and 19 bytes into a destination of size 16
>        snprintf(pmu->name, sizeof(pmu->name), "amd_umc_%d", index);
>        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors
> 
> 
> vim +941 arch/x86/events/amd/uncore.c
> 
>    900	
>    901	static
>    902	int amd_uncore_umc_ctx_init(struct amd_uncore *uncore, unsigned int cpu)
>    903	{
>    904		DECLARE_BITMAP(gmask, UNCORE_GROUP_MAX) = { 0 };
>    905		u8 group_num_pmus[UNCORE_GROUP_MAX] = { 0 };
>    906		u8 group_num_pmcs[UNCORE_GROUP_MAX] = { 0 };
>    907		union amd_uncore_info info;
>    908		struct amd_uncore_pmu *pmu;
>    909		int index = 0, gid, i;
>    910	
>    911		if (pmu_version < 2)
>    912			return 0;
>    913	
>    914		/* Run just once */
>    915		if (uncore->init_done)
>    916			return amd_uncore_ctx_init(uncore, cpu);
>    917	
>    918		/* Find unique groups */
>    919		for_each_online_cpu(i) {
>    920			info = *per_cpu_ptr(uncore->info, i);
>    921			gid = info.split.gid;
>    922			if (test_bit(gid, gmask))
>    923				continue;
>    924	
>    925			__set_bit(gid, gmask);
>    926			group_num_pmus[gid] = hweight32(info.split.aux_data);
>    927			group_num_pmcs[gid] = info.split.num_pmcs;
>    928			uncore->num_pmus += group_num_pmus[gid];
>    929		}
>    930	
>    931		uncore->pmus = kzalloc(sizeof(*uncore->pmus) * uncore->num_pmus,
>    932				       GFP_KERNEL);
>    933		if (!uncore->pmus) {
>    934			uncore->num_pmus = 0;
>    935			goto done;
>    936		}
>    937	
>    938		for_each_set_bit(gid, gmask, UNCORE_GROUP_MAX) {
>    939			for (i = 0; i < group_num_pmus[gid]; i++) {
>    940				pmu = &uncore->pmus[index];
>  > 941				snprintf(pmu->name, sizeof(pmu->name), "amd_umc_%d", index);
>    942				pmu->num_counters = group_num_pmcs[gid] / group_num_pmus[gid];
>    943				pmu->msr_base = MSR_F19H_UMC_PERF_CTL + i * pmu->num_counters * 2;
>    944				pmu->rdpmc_base = -1;
>    945				pmu->group = gid;
>    946	
>    947				pmu->ctx = alloc_percpu(struct amd_uncore_ctx *);
>    948				if (!pmu->ctx)
>    949					goto done;
>    950	
>    951				pmu->pmu = (struct pmu) {
>    952					.task_ctx_nr	= perf_invalid_context,
>    953					.attr_groups	= amd_uncore_umc_attr_groups,
>    954					.name		= pmu->name,
>    955					.event_init	= amd_uncore_umc_event_init,
>    956					.add		= amd_uncore_add,
>    957					.del		= amd_uncore_del,
>    958					.start		= amd_uncore_umc_start,
>    959					.stop		= amd_uncore_stop,
>    960					.read		= amd_uncore_read,
>    961					.capabilities	= PERF_PMU_CAP_NO_EXCLUDE | PERF_PMU_CAP_NO_INTERRUPT,
>    962					.module		= THIS_MODULE,
>    963				};
>    964	
>    965				if (perf_pmu_register(&pmu->pmu, pmu->pmu.name, -1)) {
>    966					free_percpu(pmu->ctx);
>    967					pmu->ctx = NULL;
>    968					goto done;
>    969				}
>    970	
>    971				pr_info("%d %s counters detected\n", pmu->num_counters,
>    972					pmu->pmu.name);
>    973	
>    974				index++;
>    975			}
>    976		}
>    977	
>    978	done:
>    979		uncore->num_pmus = index;
>    980		uncore->init_done = true;
>    981	
>    982		return amd_uncore_ctx_init(uncore, cpu);
>    983	}
>    984	
>