Received-SPF: pass (google.com: domain of linux-kernel+bounces-17575-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <82a9f0c4-7e6d-477a-bc6e-6dcb046b25fd@intel.com>
Date: Fri, 5 Jan 2024 16:16:53 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 06/26] x86/fpu/xstate: Create guest fpstate with guest
 specific config
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
CC: "Hansen, Dave" <dave.hansen@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "seanjc@google.com" <seanjc@google.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "john.allen@amd.com" <john.allen@amd.com>,
	"peterz@infradead.org" <peterz@infradead.org>, "Gao, Chao"
	<chao.gao@intel.com>, "mlevitsk@redhat.com" <mlevitsk@redhat.com>
References: <20231221140239.4349-1-weijiang.yang@intel.com>
 <20231221140239.4349-7-weijiang.yang@intel.com>
 <055eee55f2ed04a822d99e1824d08a70aed942f5.camel@intel.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <055eee55f2ed04a822d99e1824d08a70aed942f5.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1VPTGZqeW5KZnhuK09CR2pjZXl6VzRuMmNURnlDVzdRQWlNY01MOTFKZnp5?=
 =?utf-8?B?VmovYU1oU2xVZzJiRGVNT3FCdzduZjE1RFpLeVE4R0VCTlA3YXNEOWF3Tzls?=
 =?utf-8?B?dWVZN0R1b1pCWGxVRml6S3JlZG42RHE5V0dIODdRbDVCdXhyNHlsRTRhdmlY?=
 =?utf-8?B?ZFFhNFNYbWNGOHNIa3dHc05hS3pLSm5GOUlIQTJvV3N6WmNIOHprcVRXazZv?=
 =?utf-8?B?MWgwdnFoZXR4cDJuRnNlUldMWmQ4UUZMcmlKVlQ0TStRT2txWmViYVhOcnJK?=
 =?utf-8?B?bHQ0dm80aHZsSi94b0w2RDFBVm5wWlJOVWprbEkxK0dHcXlRdVNISFU4TkNT?=
 =?utf-8?B?ODFaWkc3SUFGcGtoNjhSWWsvNUxYWjYwMGFkVlFYeGhpQjBzWElpV1g0enMv?=
 =?utf-8?B?SzZuclYyQ3ZhWUloSVpWNU1iUDhTUXdobXNzNlFuUjBSbGd0ZEd2UE82c0FL?=
 =?utf-8?B?cHFac3JremgyMG9JeVVUM0dEcTlBU0dBakEwR0lsR2QzTHExRUhCcThVMUxp?=
 =?utf-8?B?bk9JSCtpYm9KRXpRQVBzL1Y4Q2JBNWFGVlF4ckROUk5SaEVWVkQ2dHZPN1hu?=
 =?utf-8?B?Qk1DVS93QWFSdXlXdUFEcHBwUUxvVjBKV2IycTVNU2FyYkdmYi9hM2JMOUpX?=
 =?utf-8?B?UFJBZlpoWU50NWJLR29nRDJyWHBodkNGd1hLSUFhVGpoVVpieklXYjJENEQ3?=
 =?utf-8?B?ZlVtazlneVlueEdaWmtYMHhEM0ZGejBWYlB6VFBsM005WmhZRUJhOXE2cU9H?=
 =?utf-8?B?Qy9UVmpjclZCVy93UmpLTysrWUcrRTlBMnFLeDBYQ0FmZ2xic3ZhK2JGRTk1?=
 =?utf-8?B?WHRuVVdnY0pxMGR0UlpTMjhCU1g3UXUyV0tON0s5aXllZWRqTnEzNXorbkNB?=
 =?utf-8?B?OUY3V3NXc3ZIMFBWM1NMTERQbGVFei9TMmF1Y25ZcDMzT0VDa25yNDVtdldL?=
 =?utf-8?B?NjlpOWRzdlBuakpSV3NVN1djZENnV21ZSW5MM2VqQkRjcEk2bHBRNHZ5ck9u?=
 =?utf-8?B?c1RMRmpPMjFtQVVRazZpeFJtN1B1QlQrbHN3ZVVBdWRQTWJvWTJTV3FHRTh3?=
 =?utf-8?B?a0hsZS8zdUJrcFNXa0Q5N3pJNnl2RGc3MFJZRGpzekhFZVZpaENSdEVZVXIz?=
 =?utf-8?B?Rk1pUG93akZXZkoxSEhKVGNScjUrZ2xhbFJJN0J5WU9tM3dZZFBoZXBDS295?=
 =?utf-8?B?byswSmEyYmQ3NXFnV1RTOTk1cTFSMVRPOG8vWEhFZ2huNklISS9ZZm0wVEZl?=
 =?utf-8?B?NGo2bDF6UUJKdlZyd2xzRllsZUhFWEsrYVg2R1JMS3I4U25xQXRDYXFVM2Vl?=
 =?utf-8?B?bnBDbzdDQVR6dXRXU2crazZTVVQyNGE1cWdqVDgrbEUzTUM2MnpubVVXWGtk?=
 =?utf-8?B?bUVRWmlCd3hiczAzR3VUbkl2QUVNRHVsUndPTU0vMFFQTFdlakM3bExNV1Ev?=
 =?utf-8?B?VEM1alBCcVZEK01MeC9mM1k5YzAwVTN6ajdsRnVsU1gySnNtWU1zcStWd203?=
 =?utf-8?B?b3lvMVg3end4UW9JVHRIUHlLOVBvSlF0RGNqQk5TakRmdjhhU29HaDM5UUNz?=
 =?utf-8?B?U3Nka2g3eW5TaytsTS9Rdy9acnZZTWRsYlk3MnNsUWZaajRKQmd0bDg2MTBr?=
 =?utf-8?B?VHVuZFhyM0d6d1l2SDhyWWgwb3ZwRVlGdXhhMXdNYzdwaUE2b1pFODNjWmkv?=
 =?utf-8?B?S1psNDhwT3prMXkzc3pXUzZZdThXSkZ4Qmc0NG5YdlJDdTZhZndXY0FSWG96?=
 =?utf-8?B?eGM4UjdXd2s5WTNPNEhsUlBhT1R6dUEwVkg3VjA4RlVCZHlGQk5xUmpWTDVm?=
 =?utf-8?B?dHBGOWVuTTNYTXhjR1pFbEJTOWZpUVJjTG16ZkUrcnV3YVlTZFY3a1U3SGps?=
 =?utf-8?B?M3ZWb1NCZEo2cGRwQ3RMdHFjY0JSRXpJd0RUWEZrYmQ3UHI3eStoZHI4cjJJ?=
 =?utf-8?B?MmRsSllWTGc0d0lPa0ZkaUJSeWI4WDBOVldrSy8xbWNxVndUQStVcWd0TnJ0?=
 =?utf-8?B?K0t3bkNDempkUmtkMWJqR2xZMFpXWXBrVitkQnY5OGlvVmxrL2NlclRCSnRI?=
 =?utf-8?B?VUtVY1F4dVhtcEpwODJIZ1c4RHhmb01Rb1lmZVA5WlMyN2wxYzZuOTlFUkRu?=
 =?utf-8?B?RGlvRklLNHRyV2JGVkJ2SklQcmtGVEY1aDd5TWxHU2ZENTlIRU4zRDJncng3?=
 =?utf-8?B?N1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2283fb88-62aa-461c-d4d7-08dc0dc6b330
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 08:17:05.1101
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jVRZKklwvq3hU2QNWRh+4/tUdCyrHr4jdIVB/AsaXRpEQ5Xs3kVyyroQ2vzI6mz1NCgZ5wpPDmQGmEYkrtLbNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4643
X-OriginatorOrg: intel.com

On 1/5/2024 6:47 AM, Edgecombe, Rick P wrote:
> On Thu, 2023-12-21 at 09:02 -0500, Yang Weijiang wrote:
>> +static struct fpstate *__fpu_alloc_init_guest_fpstate(struct
>> fpu_guest *gfpu)
>>   {
>> +       bool compacted = cpu_feature_enabled(X86_FEATURE_XCOMPACTED);
>> +       unsigned int gfpstate_size, size;
>>          struct fpstate *fpstate;
>> -       unsigned int size;
>>   
>> -       size = fpu_user_cfg.default_size + ALIGN(offsetof(struct
>> fpstate, regs), 64);
>> +       /*
>> +        * fpu_guest_cfg.default_size is initialized to hold all
>> enabled
>> +        * xfeatures except the user dynamic xfeatures. If the user
>> dynamic
>> +        * xfeatures are enabled, the guest fpstate will be re-
>> allocated to
>> +        * hold all guest enabled xfeatures, so omit user dynamic
>> xfeatures
>> +        * here.
>> +        */
>> +       size = fpu_guest_cfg.default_size +
>> +              ALIGN(offsetof(struct fpstate, regs), 64);
>> +
>>          fpstate = vzalloc(size);
>>          if (!fpstate)
>> -               return false;
>> +               return NULL;
>> +       /*
>> +        * Initialize sizes and feature masks, use fpu_user_cfg.*
>> +        * for user_* settings for compatibility of exiting uAPIs.
>> +        */
>> +       fpstate->size           = gfpstate_size;
> gfpstate_size is used uninitialized.

Ah, this is another unused variable after introduce fpu_guest_cfg.*, should be replaced by
fpu_guest_cfg.default_size. Thanks for caching it!