Received-SPF: pass (google.com: domain of linux-kernel+bounces-17626-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Received-SPF: Pass (protection.outlook.com: domain of duagon.com designates
 194.38.86.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=194.38.86.34; helo=securemail.duagon.com; pr=C
Received-SPF: Pass (protection.outlook.com: domain of duagon.com designates
 20.79.222.204 as permitted sender) receiver=protection.outlook.com;
 client-ip=20.79.222.204; helo=de2-emailsignatures-cloud.codetwo.com; pr=C
From: =?iso-8859-1?Q?Sanju=E1n_Garc=EDa=2C_Jorge?=
	<Jorge.SanjuanGarcia@duagon.com>
To: "andrew@lunn.ch" <andrew@lunn.ch>, "davem@davemloft.net"
	<davem@davemloft.net>, "edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>,
	"s-vadapalli@ti.com" <s-vadapalli@ti.com>
CC: "grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	=?iso-8859-1?Q?Sanju=E1n_Garc=EDa=2C_Jorge?= <Jorge.SanjuanGarcia@duagon.com>
Subject: [PATCH net v2 1/1] net: ethernet: ti: am65-cpsw: Fix max mtu to fit
 ethernet frames
Thread-Topic: [PATCH net v2 1/1] net: ethernet: ti: am65-cpsw: Fix max mtu to
 fit ethernet frames
Thread-Index: AQHaP7T36zHr73PW9Um4XleF7+KVnw==
Date: Fri, 5 Jan 2024 08:55:43 +0000
Message-ID: <20240105085530.14070-2-jorge.sanjuangarcia@duagon.com>
References: <20240105085530.14070-1-jorge.sanjuangarcia@duagon.com>
In-Reply-To: <20240105085530.14070-1-jorge.sanjuangarcia@duagon.com>
Accept-Language: es-ES, en-US
Content-Language: en-US
Authentication-Results-Original: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=duagon.com;
X-Microsoft-Antispam-Message-Info-Original:
 NbtponacqX7nJ9kgscBppnr7W6EOhDeAIXc8IH7/tpGRNSir2/WsEnup726IOjLEkO+eMQY2KcpIYtQJK+//sSiTloqnjgJjKT0J4Xy1CgOtSwiM4mEwtKIxa6nOWjgwWxNgLh2NidooVmXKU8aSpGh60DFp/cQE82Z+yI/GbIC0tEZOZgxH6e2IyzpM0Advfu4Yjgc0hl5f6vtTNGsR5NYIBZOktBOQA7G+E6FV6r73XRL0G7T3sDUJryzqK0TfFNEUz8674h2XqfBNWLSEg5o4u6FM8C5nzqk4N9vEVJoLoLRyQ720A4Nv3i/y1KnVqsxPht6FYUcehDezYKWpm2BMITK252cMH614/kW7nmGrjwC0t7c8J8MNiV6FQ4uBQzA6x+mBfgTkIDiy4m2DOoTUTRLUUjj1TW35demy4rp+nVfVbJXbm1ZyCyG/BY5GTVJRzu+Ea07D2qDIyzP9yAM9f//gB1QruH7adLBq+4acBMLLufdRBBTWhm9Cod9X6dX8IlvhAlRra6Onu/QkZu2nK7/+xOrfNbBgzqy+mIVvyi32+lgZtVmFjI95lcHwWzF62ANLsU5iWhQ3NzTAR/5kHPYkvCuq5mAiUQH1uEX/X5iqJawNxmhXKpdz4KNM
X-Forefront-Antispam-Report-Untrusted:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:GV0P278MB0516.CHEP278.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(39850400004)(396003)(346002)(136003)(230922051799003)(1800799012)(64100799003)(186009)(451199024)(6512007)(83380400001)(6506007)(38070700009)(38100700002)(478600001)(122000001)(71200400001)(1076003)(26005)(6486002)(2616005)(107886003)(54906003)(110136005)(36756003)(2906002)(66476007)(66946007)(64756008)(76116006)(66446008)(66556008)(91956017)(8936002)(8676002)(316002)(5660300002)(4326008)(86362001)(41300700001);DIR:OUT;SFP:1102;
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVAP278MB0764
X-CodeTwo-MessageID: 0efd203e-408a-4404-a4ce-a4e7934695cd.20240105085545@de2-emailsignatures-cloud.codetwo.com
X-CodeTwoProcessed: true
X-EOPAttributedMessage: 1
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 AMS0EPF000001A1.eurprd05.prod.outlook.com
X-MS-Office365-Filtering-Correlation-Id-Prvs:
 4625a9d0-87bf-4002-9d5a-08dc0dcc19f6
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original:
 V0kmJxmam/mXa+Z6Y5kso2U5YtvcybOz9vJ4p11u8WMO5PBXUTcfkKdS85h+JkNP/9T8VGQt/5IzM52wLBCHA8c+9ezWlFGPHSwQ2I5c8AsKOhXe49llGMTXel/1P6s29cUSXGoLUa9QJCzzZM1fE1q4fNgDFH89iHsKf18Q+Ja5Jh7mA7pptMV+Dwh7oo18tvlZQh+A6145CjXmgllGxhHRhg48oiOxjKIfxx9GPx08ea2LDc1sQqhzoSRu0FSdVq8WN1CNS935fS0k9GkhffRqYHigL8wG9Q4flIW9Aed3IOZqvqgtmnBPRKuw0n0i//ydQDt6THdQosxogzyNiIq52XJ0zC8c+IAKkoCbMBUcz8S4+PQb59XszFiQDDOKBnDYsWkcXQagDBWx56RyYcqGHjisD9/9tpg/D9N0mUuVbPdH0MgNvS/ZsYLPHWgP2GZ3GwfYqUDmHR7cysFOTeoqIaKoUd+MzuHO+OnKkzW2Iz00GdR9igqT994x5Mc9BHemaMYU02zfs/+itAdLsfDnSFnV4XVabVmYMJFW9kDQ6wxhFeWKgc1LMp24HDvk+zpJljFaZXAbbgh9VlJ7+R8P7H5IAjMPkm9qJZQ9532SB6GlSl+Ei6KYWOjoBSZ5cSEdkcugA63BHsr3tlJLXnsWUWaC37lPVaNvl4LKcIuNHps0Z/ZBAhJOaR3IbJFDFoZBDy1cYE6UWbEKdsrapg==
X-Forefront-Antispam-Report-Untrusted:
 CIP:20.79.222.204;CTRY:DE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:de2-emailsignatures-cloud.codetwo.com;PTR:de2-emailsignatures-cloud.codetwo.com;CAT:NONE;SFS:(13230031)(136003)(39850400004)(396003)(346002)(376002)(230922051799003)(451199024)(64100799003)(1800799012)(186009)(82310400011)(36840700001)(46966006)(40480700001)(107886003)(36860700001)(47076005)(26005)(83380400001)(2616005)(1076003)(86362001)(5660300002)(6506007)(82740400003)(6486002)(478600001)(6512007)(336012)(7596003)(36756003)(41300700001)(7636003)(54906003)(110136005)(356005)(2906002)(4326008)(8676002)(8936002)(316002)(70586007)(70206006);DIR:OUT;SFP:1102;
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR2P278MB1164
X-MS-Exchange-Transport-CrossTenantHeadersStripped:
 DU6PEPF0000B61F.eurprd02.prod.outlook.com
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id-Prvs:
	75e97bb0-1e64-4203-c3ca-08dc0dcc1cef
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	waPCJlWQ6RZxJjhfHowvVAEfg1/XcDdj+n3CXKO5o/a1fRvs9e0lklFUEkv0XX7uMlpIezHmfb4ppIZtG4Hus9xDiB7hB6Llq3FPRptzbWGp2GhrovGCIZorZnz00fnD2IoOy1Xj/opVQWFa/2XYoJEKHq7jIJgCVXjgDwhTX2cep6DsCXAYzqZ49kwtZ3Pbv/Vlw7lTBEolvVuVDGPINgscO6yaszmTkNa+dWFO7v8dAcSAJ0OlQZMqbZqaow4y7W/felA/IBApGmZayS46NGQ3lDagXpFFPJ7khxCszF3Ju4BiOMAhJqJl4fKlmzE5c9TtgQB5C/XMAu1lbedf2cs9AWgEHRMLcJ257p+IrbRAygwBKaXXJzK5scdKI12mExNHOr+Q4z5hggTibqcqbaBEhhJjl5ruLL1bIJ713kethUvTx1kjczwmsbw3KLXViS400PGO0ZkRWFHyVhGJZJNpfP+K+TDTUZ6aLmgpEZaiDG+wUtTQraQUfI3yI0h9AdssL6eZuOQ1FSaLlfXqhNulv1cUXIDhQhXS3mWqQM+pG/fAosPTiL2iCa9VkLXvrr9cP7n8kqAB7jt33ZSIIlTHkqTkp+RqzQceiVft/mlja+J5LnguD64GmNDEm/IyHgm9pxvIHs7h+cYoIIWQ/PRkZvy+xCE7L3q1VdqQQ89CkBaKERwKX5he95YpXvJKF8hMlHgrQfCvAtI1NJpYKoTo31Mz41410yKlnht2jAsnOKS1i2lkzoxqsBxzXBYc
X-Forefront-Antispam-Report:
	CIP:194.38.86.34;CTRY:CH;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:securemail.duagon.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(136003)(346002)(396003)(376002)(39840400004)(230922051799003)(64100799003)(186009)(451199024)(82310400011)(1800799012)(46966006)(36840700001)(70586007)(70206006)(36756003)(2906002)(316002)(8936002)(8676002)(81166007)(110136005)(54906003)(41300700001)(86362001)(4326008)(5660300002)(6512007)(40480700001)(6506007)(83380400001)(26005)(36860700001)(1076003)(47076005)(2616005)(107886003)(336012)(6486002)(478600001)(36900700001);DIR:OUT;SFP:1102;
X-OriginatorOrg: duagon.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 08:55:53.0205
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 1a303355-5434-47fb-c93d-08dc0dcc1f8d
X-MS-Exchange-CrossTenant-Id: e5e7e96e-8a28-45d6-9093-a40dd5b51a57
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=e5e7e96e-8a28-45d6-9093-a40dd5b51a57;Ip=[194.38.86.34];Helo=[securemail.duagon.com]
X-MS-Exchange-CrossTenant-AuthSource:
	DU6PEPF0000B61F.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: ZR0P278MB0920

The value of AM65_CPSW_MAX_PACKET_SIZE represents the maximum length
of a received frame. This value is written to the register
AM65_CPSW_PORT_REG_RX_MAXLEN.

The maximum MTU configured on the network device should then leave
some room for the ethernet headers and frame check. Otherwise, if
the network interface is configured to its maximum mtu possible,
the frames will be larger than AM65_CPSW_MAX_PACKET_SIZE and will
get dropped as oversized.

The switch supports ethernet frame sizes between 64 and 2024 bytes
(including VLAN) as stated in the technical reference manual, so
define AM65_CPSW_MAX_PACKET_SIZE with that maximum size.

Fixes: 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth =
subsystem driver")
Signed-off-by: Jorge Sanjuan Garcia <jorge.sanjuangarcia@duagon.com>
---
 drivers/net/ethernet/ti/am65-cpsw-nuss.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/etherne=
t/ti/am65-cpsw-nuss.c
index 7651f90f51f2..3c7854537cb5 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@ -56,7 +56,7 @@
 #define AM65_CPSW_MAX_PORTS	8
=20
 #define AM65_CPSW_MIN_PACKET_SIZE	VLAN_ETH_ZLEN
-#define AM65_CPSW_MAX_PACKET_SIZE	(VLAN_ETH_FRAME_LEN + ETH_FCS_LEN)
+#define AM65_CPSW_MAX_PACKET_SIZE	2024
=20
 #define AM65_CPSW_REG_CTL		0x004
 #define AM65_CPSW_REG_STAT_PORT_EN	0x014
@@ -2196,7 +2196,8 @@ am65_cpsw_nuss_init_port_ndev(struct am65_cpsw_common=
 *common, u32 port_idx)
 	eth_hw_addr_set(port->ndev, port->slave.mac_addr);
=20
 	port->ndev->min_mtu =3D AM65_CPSW_MIN_PACKET_SIZE;
-	port->ndev->max_mtu =3D AM65_CPSW_MAX_PACKET_SIZE;
+	port->ndev->max_mtu =3D AM65_CPSW_MAX_PACKET_SIZE -
+			      (VLAN_ETH_HLEN + ETH_FCS_LEN);
 	port->ndev->hw_features =3D NETIF_F_SG |
 				  NETIF_F_RXCSUM |
 				  NETIF_F_HW_CSUM |
--=20
2.34.1