Received-SPF: pass (google.com: domain of linux-kernel+bounces-17658-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <02392379-2fe3-460c-bf38-c24e7c974297@collabora.com>
Date: Fri, 5 Jan 2024 14:25:44 +0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>, kernel@collabora.com,
 Aishwarya TCV <aishwarya.tcv@arm.com>, Shuah Khan
 <skhan@linuxfoundation.org>, linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: core: include linux/close_range.h for
 CLOSE_RANGE_* macros
Content-Language: en-US
To: Shuah Khan <shuah@kernel.org>
References: <20231024155137.219700-1-usama.anjum@collabora.com>
 <9dbda2f9-2bb2-4e79-976a-12856ab6936a@collabora.com>
 <2180095f-1dcd-4542-aafe-aa2b4d039e62@collabora.com>
From: Muhammad Usama Anjum <usama.anjum@collabora.com>
In-Reply-To: <2180095f-1dcd-4542-aafe-aa2b4d039e62@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Kind reminder

On 12/11/23 4:01 PM, Muhammad Usama Anjum wrote:
> Soft reminder
> 
> On 11/29/23 4:34 PM, Muhammad Usama Anjum wrote:
>> Soft reminder
>>
>> On 10/24/23 8:51 PM, Muhammad Usama Anjum wrote:
>>> Correct header file is needed for getting CLOSE_RANGE_* macros.
>>> Previously it was tested with newer glibc which didn't show the need to
>>> include the header which was a mistake.
>>>
>>> Fixes: ec54424923cf ("selftests: core: remove duplicate defines")
>>> Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
>>> Link: https://lore.kernel.org/all/7161219e-0223-d699-d6f3-81abd9abf13b@arm.com
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>> ---
>>>  tools/testing/selftests/core/close_range_test.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tools/testing/selftests/core/close_range_test.c b/tools/testing/selftests/core/close_range_test.c
>>> index 534576f06df1c..c59e4adb905df 100644
>>> --- a/tools/testing/selftests/core/close_range_test.c
>>> +++ b/tools/testing/selftests/core/close_range_test.c
>>> @@ -12,6 +12,7 @@
>>>  #include <syscall.h>
>>>  #include <unistd.h>
>>>  #include <sys/resource.h>
>>> +#include <linux/close_range.h>
>>>  
>>>  #include "../kselftest_harness.h"
>>>  #include "../clone3/clone3_selftests.h"
>>
> 

-- 
BR,
Muhammad Usama Anjum