Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp37611rdb; Fri, 5 Jan 2024 01:45:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IGbgbpcvN9Gsd+MEhGYIuJcHnGf3ooE2vaOCFnx0atKD0sN5fr/pu7B+IfSCQW+x+6KRc6v X-Received: by 2002:a05:6214:2a8e:b0:67f:3991:ef38 with SMTP id jr14-20020a0562142a8e00b0067f3991ef38mr1876126qvb.122.1704447922439; Fri, 05 Jan 2024 01:45:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704447922; cv=none; d=google.com; s=arc-20160816; b=lAYHRrGEE6KUDBMQYoX6sfBpc77J8zOWt5KFE1Ec8+lRK6GOGOvdDPG69fm1fgIlPQ yP4ZukM+L4+x78qhf+hwZzznc50zKbkQGc1ooeDcpCJ209uRL6pjYZwBzBFnQf0UY/5q AL3NiSC/w63txajqh2y0688Atg85VOtkSEsEP77atHJQxIY81nRCR3Wc1ea8vp/nzEI3 eP/oAPLKY4oPozjUKwkLyyszy32vUgK3OEiwSUv5CUbR6uHZ6J8aZCwBKtPRdKkte08K QJBqPYK5fkqxjj0H1js8WdE7LJHkIvQZE1aV7M7repWDaBsp1kcGlLIgSX9zJGcv57VF liFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=TFpseWSlXa6VJ8x1Bw84TJ22oa6aTo4EtNJAEkzn/5k=; fh=TMlLwFpYTEWfm6TtFQnuI3NokkFMDDew/8uJMjqlpjs=; b=pciQe0yh/uW5GAS27QzrlpgCEekVAIY2DXx8eEN68CCuteTKKmqziq7TXGFA9c9VYG yzqsCfPBEG3hm8Uk5BAKrlPV4CLgAeeoranPAtWe0ParzN8PFMYjo1TOXg9obMkjMZ1K 6fkiyx+ACCSu0m64QHOhOkk5YjLiJqd7S3Jo3zzbB3gQrFvHnW2beAi3Mlr04l+Hmlc3 c3Z+21O1OT4Xe5tifkYKsKvx/rvIIxK7ZU7koemel+FCp3HGCxh0gpka2nP7ST6Iuwze FTeLD4JFSh4sqd+bXyl/go7HRLLLq5lwigwo6evkIzYNMpvQ3xY9yKqnyNRvOJ8kMcYT ZKXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=NHI3SJE3; spf=pass (google.com: domain of linux-kernel+bounces-17680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17680-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d22-20020a0cb2d6000000b0067f92e3d944si1375859qvf.398.2024.01.05.01.45.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 01:45:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-17680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=NHI3SJE3; spf=pass (google.com: domain of linux-kernel+bounces-17680-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17680-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 35FB11C217CB for ; Fri, 5 Jan 2024 09:45:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 04C1524B57; Fri, 5 Jan 2024 09:44:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NHI3SJE3" X-Original-To: linux-kernel@vger.kernel.org Received: from mail-vs1-f44.google.com (mail-vs1-f44.google.com [209.85.217.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D53BE2421D for ; Fri, 5 Jan 2024 09:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Received: by mail-vs1-f44.google.com with SMTP id ada2fe7eead31-4673b620d95so285265137.2 for ; Fri, 05 Jan 2024 01:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1704447895; x=1705052695; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TFpseWSlXa6VJ8x1Bw84TJ22oa6aTo4EtNJAEkzn/5k=; b=NHI3SJE32/yf9P1jX0pK04v0UXnSp5H5/4Kp0l/CbEQyHc/RYN77xBfVeaZXIggzx3 4XEvwzy7pJAWlBiBJwQUVRQvl5VlMZAaJYmbo63qRh2QNsyvvTLOdZoXHtPPhX0rtlym bz6lUg7FfaQ4aGe6Cm48jZME8OORoFo52QY7WRqaAjOH/adnyLqlVvZxy5DHXPLC3Sgg 8X3+FnVBcZlkweY26MoQ0GNbxaajtSe9cIo/EvWRIXPTGY8xz+0LMPbNGinBPjkmRSVR +U52U7xnsPUSfymXL/eRecpCGbDmkrzpPCRlhdU5aA5hNxJICbVrf6eTwFV8GsV30Q+V IgfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704447895; x=1705052695; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TFpseWSlXa6VJ8x1Bw84TJ22oa6aTo4EtNJAEkzn/5k=; b=xNQnRGw/I6UBqY1Y8pkjMbj7IgV7KdfbU8+Uuvjb+/XkEXOepA+J11DS9ZR1eUCUun kKvmPKgY6cZHJsDps7Ifhg2VaID8yFFmm0Rkvbt8pZuSpJ12kZ2MaAfGjw2hMPwwdpGN khdRESzHJjkUH//pp26aKo/AOYOBz2UXdZibg6IToGltZXCX0Sw/e0WE3iIIcVne/jFz EAHlk1YRkgrCler/z/vmFcS1undGd8VMyFjrWB5GkoT/rf63Jp7wnuW0XQ4DKb8yPikD E3sGqZipI/A6wy8RrMrK5z7zyd5RJwONPkhI2C61YLszkBLPKf835sXk/bzMMReyVzJv 9cBQ== X-Gm-Message-State: AOJu0YzcHTZetuv5wnluCxyrrKSJHiTQb7o8hQuW/WnPoJIpSGyXZUmy owV6CawjUQmS7VkAFndk+55SQSMIum9bfi6q3ZGd1hgxy89N X-Received: by 2002:a05:6102:440f:b0:467:bacf:5a6e with SMTP id df15-20020a056102440f00b00467bacf5a6emr54778vsb.20.1704447895692; Fri, 05 Jan 2024 01:44:55 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240104-rb-new-condvar-methods-v3-0-70b514fcbe52@google.com> <20240104-rb-new-condvar-methods-v3-4-70b514fcbe52@google.com> In-Reply-To: From: Alice Ryhl Date: Fri, 5 Jan 2024 10:44:44 +0100 Message-ID: Subject: Re: [PATCH v3 4/4] rust: sync: update integer types in CondVar To: Boqun Feng Cc: Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Tiago Lam , Thomas Gleixner , Martin Rodriguez Reboredo , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 4, 2024 at 11:48=E2=80=AFPM Boqun Feng w= rote: > > On Thu, Jan 04, 2024 at 02:02:44PM +0000, Alice Ryhl wrote: > [...] > > -use core::ffi::c_long; > > +use core::ffi::{c_int, c_long, c_uint}; > > core::ffi::c_uint is not needed here. And > > use core::ptr; > > is missing (for the `ptr::mut_null()` below) Oops, looks like I messed up this patch. Sorry about that.