Date: Wed, 12 Dec 2007 02:47:00 -0800
From: Andrew Morton <akpm@linux-foundation.org>
To: Adam Jackson <ajax@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] apm_event{,info}_t are userspace types.
Message-Id: <20071212024700.19560b60.akpm@linux-foundation.org>
In-Reply-To: <1196452963295-git-send-email-ajax@redhat.com>
References: <1196452963295-git-send-email-ajax@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1358
Lines: 46

On Fri, 30 Nov 2007 15:02:43 -0500 Adam Jackson <ajax@redhat.com> wrote:

> These types define the size of data read from /dev/apm_bios.  They
> should not be hidden behind #ifdef __KERNEL__.

Missing info: what are the consequences of this fix?  What id broken when
it it not applied?


> ---
>  include/linux/apm_bios.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Please include Signed-off-by:, as per Documentation/SubmittingPatches,
thanks.

> diff --git a/include/linux/apm_bios.h b/include/linux/apm_bios.h
> index 9754baa..01a6244 100644
> --- a/include/linux/apm_bios.h
> +++ b/include/linux/apm_bios.h
> @@ -18,6 +18,9 @@
>  
>  #include <linux/types.h>
>  
> +typedef unsigned short	apm_event_t;
> +typedef unsigned short	apm_eventinfo_t;
> +
>  struct apm_bios_info {
>  	__u16	version;
>  	__u16	cseg;
> @@ -32,9 +35,6 @@ struct apm_bios_info {
>  
>  #ifdef __KERNEL__
>  
> -typedef unsigned short	apm_event_t;
> -typedef unsigned short	apm_eventinfo_t;
> -
>  #define APM_CS		(GDT_ENTRY_APMBIOS_BASE * 8)
>  #define APM_CS_16	(APM_CS + 8)
>  #define APM_DS		(APM_CS_16 + 8)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/