Received-SPF: pass (google.com: domain of linux-kernel+bounces-17712-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 5 Jan 2024 18:08:30 +0800
From: kernel test robot <oliver.sang@intel.com>
To: Zeng Heng <zengheng4@huawei.com>
CC: <oe-lkp@lists.linux.dev>, <lkp@intel.com>, <linux-kernel@vger.kernel.org>,
	<ying.huang@intel.com>, <feng.tang@intel.com>, <fengwei.yin@intel.com>,
	<mingo@redhat.com>, <will@kernel.org>, <peterz@infradead.org>,
	<longman@redhat.com>, <boqun.feng@gmail.com>, <xiexiuqi@huawei.com>,
	<liwei391@huawei.com>, <oliver.sang@intel.com>
Subject: Re: [PATCH v2] locking/osq_lock: Avoid false sharing in
 optimistic_spin_node
Message-ID: <202401051804.77722270-oliver.sang@intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231222121040.2635879-1-zengheng4@huawei.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Yg/QjVMi9x9L/EUGqOnS31lDrl7VlGiTxtv+FRgBUMmo79SNPaSBE3lNsI?=
 =?iso-8859-1?Q?V7CKGTFW1IRTZ58K3tqFBTxhNNv6TV9zf6lXEX2mUDTqHisLAJH2jasA+E?=
 =?iso-8859-1?Q?PXD0Cw1tFpZ2oQwxfkStrrBFmR17Tr9N01nWOILahiBvE/e8wICoADVcbu?=
 =?iso-8859-1?Q?dr+kCx/5FRg3jaOxcEV4aAyZNgnMeSL3i0RdxUt4POqLjJCGbZbeCwH2Vm?=
 =?iso-8859-1?Q?W1B7vFrOMng+uEs7EI3MuM8ZLGSBoWJ2/dka9YUU0YiwYC63j064+AkN/L?=
 =?iso-8859-1?Q?dGhMhiZbOgksd0cStkoPwIWVh0hb/E/tuxXk9bnxGrXmKX+MEoeXgjTAx0?=
 =?iso-8859-1?Q?Gy/0Iq3wbuwKa02eImY4e/2A5jU91RMF9/uPq5AwE97ysLjjHWHoBxhi4O?=
 =?iso-8859-1?Q?vZdBeaaAGKzSKXBMoNYllxbF55F4PhxNwhR3luwPr1LC0+nsboBGJaa4B8?=
 =?iso-8859-1?Q?YtJPuw6UKB/TmfD/0kiJ5tSWu4ZZzS2ULKDpXRL1h8ZaHtYTWAX/qH8jEJ?=
 =?iso-8859-1?Q?1kDKhvRuWsci98jcV4EkXwqimiIAJHVwmRwshigDFR6dkUM3H89jOGim/L?=
 =?iso-8859-1?Q?xQt32zy+lYpi6O/kiB4NrBoa2URaQ9VLqbEpQcim8LALshLgejm/Gnvwna?=
 =?iso-8859-1?Q?qPo4/7dLj+kW5K9tvv7acasiHYtVOX6u6h67tr9Gs2NyMMFjGURRtSwlnf?=
 =?iso-8859-1?Q?dAvEnRwlR6RgVpjQcPO8w1PiLjzH8EPA8D8zkwF9bhyDx7JRybkbY+SgpL?=
 =?iso-8859-1?Q?WZ+BOLL04A3X9B1AAx8wqJMZjEUfbSvaO/oKVJW+GPCZdC6hxTbhp03PdB?=
 =?iso-8859-1?Q?MGkTKrqBGm0+7VeKJD1hDuSN3GXKfPgcJrcgSFpN/CrdaGJz7vzbWzOxkG?=
 =?iso-8859-1?Q?d8sEa606e11MMkvP4TZGRTmkO8GnstrrGJQ4P5hNt4DJnBMI4gbopcchr2?=
 =?iso-8859-1?Q?wQmqYqKBMnED2RhmXG37+u1oS4iyrT923R9bWwAL04LxmJe2EccNZkmDQ+?=
 =?iso-8859-1?Q?GbjLgWUqQWoD0MWAAOn/YvZmsb4LxD3W+AXU1AzSEk3J96lA1VoENPrc+h?=
 =?iso-8859-1?Q?hMFuqdSeBj6y9DP/J9IFgxaRNPZNoQnn5dAjQVRVLLtf6UIcsHo/bipV/A?=
 =?iso-8859-1?Q?RLNJ+GgVGrhj1Z170CoqOYZMn/2gm7wrYJ8/tUisVjjSILmBwrXLeYQQbx?=
 =?iso-8859-1?Q?S50sFgqtmCtcpXWN0v8PhoCZP8CFiB7XVevJ8T3VtpadmCuV/srh4B/wx/?=
 =?iso-8859-1?Q?CdXroVQqgTCz0zhzaghS4Q+kaEiNzAJ4YIxh3GKnxpFvsJPtFNTLHlHaTb?=
 =?iso-8859-1?Q?YLz/egpXHV+fquI1vo7h460hrdQU0fV81cl6IrcGFTSPNPQaYRAHthB0LS?=
 =?iso-8859-1?Q?YccWzrbKtaxMXKY3GZHlENfg0wh2ue0dndpH/GPNu+Qg7h1+n96X6xb6NN?=
 =?iso-8859-1?Q?fJJdtTuIV8NhmPRU869xteiM1XKi5BrdPFn+1X/wXsPpSTkxwWl9HduFb6?=
 =?iso-8859-1?Q?VBmVSR5eYszIypPEjxK4EExYoqWVbpFs9q3HqWi7bzbyWYX6DfEc6HV8/p?=
 =?iso-8859-1?Q?CTRCkybatY6gmf/kjj2qlYwx1LPDJySiR6AlZ8o+wquTHdGiPSuSdOob/i?=
 =?iso-8859-1?Q?YeuqZq6gaNCCkG8VGQYK0LDlAt8ckR9fAKYIl/uVjz6DHPrchcLq1sTA?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 25a85a60-ae14-4ca6-a3cb-08dc0dd64aa7
X-MS-Exchange-CrossTenant-AuthSource: LV3PR11MB8603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 10:08:40.9865
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m7dqwYyxGI5KhptZNrR6WD6uXb39Lqv2t7IK9NDHpPG1nfDwRi/y/beVqJ+MyHWedDzQk64bHzfZQihkcG0I7Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5100
X-OriginatorOrg: intel.com


Hello,

kernel test robot noticed a 15.3% improvement of fxmark.ssd_xfs_DWOM_72_bufferedio.works/sec on:


commit: 511ac0a137f4211f42aa2ba168e50550b703bb7c ("[PATCH v2] locking/osq_lock: Avoid false sharing in optimistic_spin_node")
url: https://github.com/intel-lab-lkp/linux/commits/Zeng-Heng/locking-osq_lock-Avoid-false-sharing-in-optimistic_spin_node/20231222-200921
base: https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git a51749ab34d9e5dec548fe38ede7e01e8bb26454
patch link: https://lore.kernel.org/all/20231222121040.2635879-1-zengheng4@huawei.com/
patch subject: [PATCH v2] locking/osq_lock: Avoid false sharing in optimistic_spin_node

testcase: fxmark
test machine: 128 threads 2 sockets Intel(R) Xeon(R) Platinum 8358 CPU @ 2.60GHz (Ice Lake) with 128G memory
parameters:

	disk: 1SSD
	media: ssd
	test: DWOM
	fstype: xfs
	directio: bufferedio
	cpufreq_governor: performance


Details are as below:
-------------------------------------------------------------------------------------------------->


The kernel config and materials to reproduce are available at:
https://download.01.org/0day-ci/archive/20240105/202401051804.77722270-oliver.sang@intel.com

=========================================================================================
compiler/cpufreq_governor/directio/disk/fstype/kconfig/media/rootfs/tbox_group/test/testcase:
  gcc-12/performance/bufferedio/1SSD/xfs/x86_64-rhel-8.3/ssd/debian-11.1-x86_64-20220510.cgz/lkp-icl-2sp5/DWOM/fxmark

commit: 
  a51749ab34 ("locking/mutex: Document that mutex_unlock() is non-atomic")
  511ac0a137 ("locking/osq_lock: Avoid false sharing in optimistic_spin_node")

a51749ab34d9e5de 511ac0a137f4211f42aa2ba168e 
---------------- --------------------------- 
         %stddev     %change         %stddev
             \          |                \  
     19727 ?  6%     -13.5%      17073 ?  6%  vmstat.system.cs
     19254 ?  7%     -13.4%      16678 ?  7%  perf-stat.i.context-switches
     19499 ?  6%     -13.6%      16851 ?  6%  perf-stat.ps.context-switches
    105.12 ? 13%    +115.9%     227.00 ?  9%  perf-c2c.DRAM.local
      5028 ?  2%      -9.1%       4571 ?  2%  perf-c2c.DRAM.remote
      3526 ?  3%     -13.8%       3040 ?  3%  perf-c2c.HITM.remote
  77565522 ?  2%     +11.2%   86238276 ?  3%  fxmark.ssd_xfs_DWOM_18_bufferedio.works
   1551311 ?  2%     +11.2%    1724766 ?  3%  fxmark.ssd_xfs_DWOM_18_bufferedio.works/sec
  61955316           +12.3%   69564863        fxmark.ssd_xfs_DWOM_36_bufferedio.works
   1239107           +12.3%    1391298        fxmark.ssd_xfs_DWOM_36_bufferedio.works/sec
      2.21 ?  4%      +9.2%       2.41 ?  2%  fxmark.ssd_xfs_DWOM_4_bufferedio.user_sec
      1.10 ?  4%      +9.3%       1.20 ?  2%  fxmark.ssd_xfs_DWOM_4_bufferedio.user_util
  46595523           +16.2%   54146121 ?  2%  fxmark.ssd_xfs_DWOM_54_bufferedio.works
    931911           +16.2%    1082933 ?  2%  fxmark.ssd_xfs_DWOM_54_bufferedio.works/sec
  44518641           +15.3%   51332276        fxmark.ssd_xfs_DWOM_72_bufferedio.works
    890372           +15.3%    1026646        fxmark.ssd_xfs_DWOM_72_bufferedio.works/sec


Disclaimer:
Results have been estimated based on internal Intel analysis and are provided
for informational purposes only. Any difference in system hardware or software
design or configuration may affect actual performance.


-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki