Received-SPF: pass (google.com: domain of linux-kernel+bounces-17725-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: =?UTF-8?q?Micha=C5=82=20Winiarski?= <michal.winiarski@intel.com>
To: <intel-xe@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>
CC: Rodrigo Vivi <rodrigo.vivi@intel.com>, Michal Wajdeczko
	<michal.wajdeczko@intel.com>, Maarten Lankhorst
	<maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Javier Martinez Canillas
	<javierm@redhat.com>, =?UTF-8?q?Ma=C3=ADra=20Canal?= <mcanal@igalia.com>,
	=?UTF-8?q?Micha=C5=82=20Winiarski?= <michal.winiarski@intel.com>
Subject: [PATCH v4 6/6] drm/tests: managed: Add a simple test for drmm_managed_release
Date: Fri, 5 Jan 2024 11:13:24 +0100
Message-ID: <20240105101324.26811-7-michal.winiarski@intel.com>
In-Reply-To: <20240105101324.26811-1-michal.winiarski@intel.com>
References: <20240105101324.26811-1-michal.winiarski@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K0hiNlNBWVNMcFVUYTJjR2tVTFZxTEQyYmZIMWJQV0lBTUVxcllBeTJTTUxl?=
 =?utf-8?B?Q0x6cTFHNXBpUS9JOFlpODl6elNXcWFTaU9XZ2VDMmV5OS9PbHRZZ0ZqMzVN?=
 =?utf-8?B?OFRnZ3dOOWlud3R5TnlnSmFGRzFaYmFWMWhQclJqVmlEbCtjajA0UUNaenlt?=
 =?utf-8?B?UGJzNU9pQ2lodnhJQ0dSTWJLb0JQaW9MWW1zTkpzYWRWb01sSmJBVkw2WTlM?=
 =?utf-8?B?TXpWeWE4MlBFZFlYWm51MzE2NVM0ZnlaV0RnekFVYy9PTTJWc3pTaWxGQm0x?=
 =?utf-8?B?VllUV2tzUnVQcTExSVFVbXhFQzBJVEFBOTVvREhFb29SQmx1M2JQMXNSMFhD?=
 =?utf-8?B?TG1QNlFuK2FuQ0RYeE0wUFFSUzZPUVJkTUs0NE1KcDdzOUdCWjRkUDF5U3hB?=
 =?utf-8?B?akI0WFVNN3ExZmJXYVhGNndrWDdvYTJYQUdtU1pQQnEyRlcvanJnbkZzTSts?=
 =?utf-8?B?TEM3UWtmWEFickFWbzgvNkpmMnFNR0JERDNFYi9CSk1jN2VjalNiWGZ5aGNV?=
 =?utf-8?B?MCtBR1c0TldoblJVMGtOYSsxWUszOWhuTFB0aU5NeG9wTVBOSmZnVzdVdzNm?=
 =?utf-8?B?YXlKeWdNallYUlJFeHJqOUF4b3VGUjhUMi9DV3F6OXhHY3F3Vlo1MkhBL3hB?=
 =?utf-8?B?YXVCODIycjBsOTlqSGZYTDAwN2NKYmRienVjcEtyU05TOHpJSFBFUkpqRXRt?=
 =?utf-8?B?TkpLZVpmR3l4NGEyQngwY3ZvRmcveTBrREtxN3dUVTZwOFdHTUNNTzVIK0hO?=
 =?utf-8?B?czdGTXZSSDh5ZU5KSWpRZVJrcXBqM2dYOEpYQmI2YWd4RXNDZFhJWHBRTTRX?=
 =?utf-8?B?cVFUb1c3Z3N5NmdHUVkxRTdtcXQ2VU9rNURGcytWQTZDS3piYUxTdVIwZVg5?=
 =?utf-8?B?cmF5MnIrK2hNbElhVlNZYmUrYlR2M3RJN0pxNVpxMlNYdjl3aHVIRUxFSnF6?=
 =?utf-8?B?RHpPWk4vcWRBdHFiWUp5Y0V6aVllb0RtWVQyd21EL3c0RWpaWG50WVFsK2o4?=
 =?utf-8?B?VUdINHZjZmx0RkhOSzNiM2NzVXZtSTFjT0FsUHZ2N2NDcXBSSzA3a09hNE55?=
 =?utf-8?B?eDZ3UmIvdWRYU3NLclpUb3hPNzVGcUg3eTVYdFBaVkt5WVVzYk9HUzZpa0tJ?=
 =?utf-8?B?SXJRQ1FnaXVBaEFDTU5YdG0xR0p6NWpxUE5CTU85VzBTVFE1TURwclE5d3Zx?=
 =?utf-8?B?VTVQN0xPK0ZvNW95Ny9FVHQzWmNpQ2YvcE4xS1dZYmRnd0p5ZEpxempWY29l?=
 =?utf-8?B?MjJ1SjNGRnpJV2VyTkQ0V3NtdDJZbm8zSTdLRzZkaXVSSU8yb0U4VWtXemhC?=
 =?utf-8?B?YkpGaFNMQW5mb1hmQ2h0bkw4L29PZzlPaE5Ub2twa21nMnVOZXEvOFNXTmNF?=
 =?utf-8?B?Yzg3YWQxOFgrYlppNEtBS3B2bmRPNVRaZWFJeWt5RkN1dkFHWFN6cTMwTmhk?=
 =?utf-8?B?dmMvZndCRytZTUlxNGlTYnZZQlJucTdncVZFWjFpaVZSOU5WeVM2WENTQzhI?=
 =?utf-8?B?bS9xYXRsMzBZZ2FuaW5nUUFNWXUrN1hZYkhadm4wL1V2TUptdHZzTGx3VjlX?=
 =?utf-8?B?ZEVERWdUaC9sRXE5aE1PYjRzaCszdWJjZUJnbGV0UkF6SFU2UnVYNUJ6bTRP?=
 =?utf-8?B?U21XWU9ldVFqVkxxRk5YV0ZFZUpnWVp2Nk1JR1h1cFhNd1ZDVE1mWnF2Q28r?=
 =?utf-8?B?NmNRVmpjZERUSndOaDNhendwNW5iMDJ4TW02d1dnTXlUbmx6dm0zQVhzcnpv?=
 =?utf-8?B?NUZoZDBrRkdZbzZoTlY5STBiZmhlZWFkNjc4TUFaNUc3bnhhVFYzNmtIeHBP?=
 =?utf-8?B?SDljQm1PR1liakZiSHVkejh5dElQK3dBdFZzNk9tUkEvVVc5M2VmSzJwallp?=
 =?utf-8?B?S3V2akFBTk9iS1JrazQ2bEVvdXFhcWVBVHA2UXdZVGZRckQzRmFuWDJPOThM?=
 =?utf-8?B?UUdIcFdNT0RkeTVQaDQvbzRCSUU5OXJzejgwT2VGRXJHWkN5bXNjcE5WcHB5?=
 =?utf-8?B?SXlFeXRhTHZxeVpDYkNldSsyUUF3VytLQjhoZWI4WUZOY2t0SkMzd3NLZFNJ?=
 =?utf-8?B?RU51RU9VeDdjS01hQitsYkZobTJ2cFQzZE43VkQrS3ZiUHdlcExDUTZraTBF?=
 =?utf-8?B?eEZsQTJPc3BsbE1meWJ4UHprT1NyVDJmaVV4M0RKc0h6VTdKTFYreUZVNnBC?=
 =?utf-8?B?L2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 66606960-96ed-4533-711f-08dc0dd706fb
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 10:13:56.8875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IfX6EsbBimyYe6l5VmwTT7barni7XdGsxChFBYX5Ck41qUf/BeI5zyMu9w0XCpXTjiQNd8HJ2F/fqS/d9FVoYbc2R2IUF50kwEMBIq2YdNI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4823
X-OriginatorOrg: intel.com

Add a simple test that checks whether the action is indeed called right
away and that it is not called on the final drm_dev_put().

Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
---
 drivers/gpu/drm/tests/drm_managed_test.c | 28 ++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/gpu/drm/tests/drm_managed_test.c b/drivers/gpu/drm/tests/drm_managed_test.c
index c1fc1f0aac9b2..91863642efc13 100644
--- a/drivers/gpu/drm/tests/drm_managed_test.c
+++ b/drivers/gpu/drm/tests/drm_managed_test.c
@@ -41,6 +41,33 @@ static void drm_test_managed_run_action(struct kunit *test)
 	KUNIT_EXPECT_TRUE_MSG(test, priv->action_done, "Release action was not called");
 }
 
+/*
+ * The test verifies that the release action is called immediately when
+ * drmm_release_action is called and that it is not called for a second time
+ * when the device is released.
+ */
+static void drm_test_managed_release_action(struct kunit *test)
+{
+	struct managed_test_priv *priv = test->priv;
+	int ret;
+
+	ret = drmm_add_action_or_reset(priv->drm, drm_action, priv);
+	KUNIT_EXPECT_EQ(test, ret, 0);
+
+	ret = drm_dev_register(priv->drm, 0);
+	KUNIT_ASSERT_EQ(test, ret, 0);
+
+	drmm_release_action(priv->drm, drm_action, priv);
+	KUNIT_EXPECT_TRUE_MSG(test, priv->action_done, "Release action was not called");
+	priv->action_done = false;
+
+	drm_dev_unregister(priv->drm);
+	drm_kunit_helper_free_device(test, priv->drm->dev);
+
+	KUNIT_EXPECT_FALSE_MSG(test, priv->action_done,
+			       "Unexpected release action call during cleanup");
+}
+
 static int drm_managed_test_init(struct kunit *test)
 {
 	struct managed_test_priv *priv;
@@ -67,6 +94,7 @@ static int drm_managed_test_init(struct kunit *test)
 }
 
 static struct kunit_case drm_managed_tests[] = {
+	KUNIT_CASE(drm_test_managed_release_action),
 	KUNIT_CASE(drm_test_managed_run_action),
 	{}
 };
-- 
2.43.0