Received-SPF: pass (google.com: domain of linux-kernel+bounces-17818-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <522eb2bb-95d0-4e2f-a426-9347f14f51cb@vaisala.com>
Date: Fri, 5 Jan 2024 13:56:35 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] usb: core: Make default authorization mode configurable
Content-Language: en-US
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
 Jaaskelainen Vesa VEJ <vesa.jaaskelainen@vaisala.com>
References: <20240104163203.7381-1-niko.mauno@vaisala.com>
 <2024010413-portable-lingo-3c11@gregkh>
From: Niko Mauno <niko.mauno@vaisala.com>
In-Reply-To: <2024010413-portable-lingo-3c11@gregkh>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?MDhvTnhoMDlFcDdJVXkxSTFQVklnUDRTMytMSS84c1FwUFNFMHVRbGJjSUZ1?=
 =?utf-8?B?RjJkSWEycXNGL3hWSDY1L3E5WkhDY3VCNzlORUZuSzFEMTA5cm90TVRIam0v?=
 =?utf-8?B?OEFZK3BjOXNCMXdXMG1DYjJXbjlVdW1PVFFQN2FlQUtzeUtwZHJvWGdYVjll?=
 =?utf-8?B?N1BnYjU5c29ETjh3VFJXbUgwejNncVRIbXBCUUp4Rlo4MmorVDU2aTYzYTJX?=
 =?utf-8?B?akdHc3cySjVaVncxTU5SbGxyeTlIRm1uUUtRcFQ3S2k1bnRxZ3I1emdkUXIv?=
 =?utf-8?B?OUF1bThtaWZDTHFGOXM3MGl5ejloWEo4Z3d3clNiazUralRreW9hZ29aQi9o?=
 =?utf-8?B?eTR1c0VUMjRlN3hvZm1ORlhkSDVMQ1NXQkhPc0lFTlNEZDBGeExsV1RrSXVW?=
 =?utf-8?B?VU8vSklmRjZTK2lZV3c2N0I4RzRxbUZtamk5Q1lVdGd4VnV3dkZBVmtYUjhF?=
 =?utf-8?B?Z2lyZFFKR2tsUnczOFFLbW1jaGgzRUFyZmU2cXhDMWs3YzIvNFlFSnU1VUsw?=
 =?utf-8?B?WXhpU3NtM0FubVRheVltbHQxL0lDNWxkVDlUKy8rUFlRTzNGYWdnamM1Q1dM?=
 =?utf-8?B?UndhYWFERkpSVjFmU0dZVzQvSXpBYTRCVGYxN3RxdmF4M3JRMDM1b2FVVTdL?=
 =?utf-8?B?ZVAwRUlrbjZaOUFzbENoMmxBVDZKbWkrNitwVTQ1RGhtS1c4a3Y3Z1dPQzdK?=
 =?utf-8?B?T1lqdk9GYmhwN2F6TktmSVM3Zy9zakthTlVrMnBKaTlxRmNmM3BDZll6Yzk0?=
 =?utf-8?B?elcrZERyd0s3K2ZmUTZCbXZWanNwZ3hPMjZRMEdNaWxzbjFORlNSaXEvTnBI?=
 =?utf-8?B?Z1ZTclUzOTB0YjRSYmFSK003N1lpbHNrS3I3eHVqUC9STzlqQ1FHSHdxaWVH?=
 =?utf-8?B?WGJzZWF0eWhRbEt0TGtBL2RvZ29FME1abVNHUzNrZ1J3RW5Wem1Sb2VJK2hm?=
 =?utf-8?B?bjRoUmwvWlFqNTVOT1AxVGF0SGhmY0g0RklFSkUxcUx3ZHZ4TnB4bnZHQWJT?=
 =?utf-8?B?SlR5R0U2VGhLdkxtYmp4N3grZ3BBZExCdlVBeFZYYUk5eVV5K2VGSEEyRmJC?=
 =?utf-8?B?RTVyVmk2MzJwSVNjNUlTdG0rWlRPTUZiZVphazd2WFBRV3BiM3JRbmN2SlVW?=
 =?utf-8?B?TVFsRnBleldXUFd6cEZrSUlhTFhWTlcwREZ1NWw3VGFIZm9ld3RyYlhIWHN3?=
 =?utf-8?B?bytLclpUUjJYbmtNa1BNeWNLUzNPbTJrVDVjWUdaWUZnVkdxcklFdEV0RUFz?=
 =?utf-8?B?TUNlaVMySzRISkxiRkxQdU9WNDZuSlBFc1djb0t6bTR4Q0N6RDRsUnlreWtS?=
 =?utf-8?B?ODBEMjNFYURPWDFKMTY1djU4WTZZZkxmeHF6MEVwdVcvZEM0N1V2c3pZN0lz?=
 =?utf-8?B?RldwTE95Qk1VVHBhMjhQZnlnNkh3VGo2ZVZVV1NMOU9HMXVaQ3prTFk4VmRN?=
 =?utf-8?B?WHNrajZiSFZzSlhPbG91UDd5ZlNHQUF0NTVkcnlVK0lXOFp0TGpEbXNuTkZj?=
 =?utf-8?B?bkVheEZCR0NWY0RsRlJTRDJmWThHbHVXT0FoM0pUQlVlblc3bHg1UnpPcUZC?=
 =?utf-8?B?b05MdFNKaExhN28rc1ZMcVJ2Nnh2WG5QbktpTzM4WHBCaG56ZFRkMUZpdkxK?=
 =?utf-8?B?YmQ5Y21XUG9hRjQ0Q2hUNVBwM1Zhb0ZzRUdrTXhqN3o0cmE0VlllcUNHZ1NM?=
 =?utf-8?B?MVY0Z0pOcjVNSXV3TkFMZHN3K2t6ZzlhWmkvenpjVm13RkZ6Z3VTZjdZaEFM?=
 =?utf-8?B?Tjg2SG9obitvbDFBSVQ4ZUZNcjVNajI5MU9vdERQRVRJVHRuNjIzOXBRbjBu?=
 =?utf-8?B?M21uLzNhc01zWG1FRGNpWlVJTm1pdTd1NGlPWXo1cTloRjh0OXo2MitQc1c4?=
 =?utf-8?B?NkNia3BPMmVHWkswd3VXOUJ1bDdzbkhHd0hZY0tlUEZPemhwNmJkMVlBN1NM?=
 =?utf-8?B?WXRGdzlBZ1pOV01vL0RKMUxUd2F2NUIrTTNtczNnalJ0UllFNDYzZ3hPWTE3?=
 =?utf-8?B?ZUJwYnF6QUV0eDZOU3RQV0Z5L0FuRjk2eDVDWWRIRXhtU0lFU2VuVkNMaWVB?=
 =?utf-8?B?c00wNVBWQURyRWVWSS8ySkVwM2RmdFpOSjllcG9LN0MxMkVQYXRqd0hwd0Q2?=
 =?utf-8?B?ZUZYWktyQStHaHluYUVEWHdGRWhhZmVQRHJweitWNlo5OWdLbUFRQWF6Qndl?=
 =?utf-8?B?bkE9PQ==?=
X-OriginatorOrg: vaisala.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e8de5be4-0951-4c7d-42fe-08dc0de55f75
X-MS-Exchange-CrossTenant-AuthSource: AS4PR06MB8447.eurprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 11:56:38.1730
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 6d7393e0-41f5-4c2e-9b12-4c2be5da5c57
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GIGrvJB8spPTua0mFq2nJQ1Phz2B580bVze4imrq4EJ3iHLubolzkp6N4aYw8jkaaTzOE7A43nA81dbrz/ygDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR06MB7074

On 4.1.2024 18.41, Greg KH wrote:
> On Thu, Jan 04, 2024 at 06:32:03PM +0200, niko.mauno@vaisala.com wrote:
...
>> +       The available values have the following meanings:
>> +             -1 is authorized for all devices (leftover from wireless USB)
>> +             0 is unauthorized for all devices
>> +             1 is authorized for all devices
> 
> What's the difference now between -1 and 1?  We don't have wireless USB
> anymore as that never turned into an actual product, so we shouldn't
> reference it anymore, right?
> 
> We should get rid of the -1 option entirely, but keep the module option
> and properly map it to '1'.
> 
> 
>> +             2 is authorized for internal devices
> 
> Needs a "if you don't know what to select, please choose X" text here.

Thanks, submitted v2 which strives to address also these considerations.
-Niko