Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp96207rdb; Fri, 5 Jan 2024 04:06:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IEINKQiJw+SxQabLe9/bd8XZPtFnINujwIGUV/j5lgWAXPhCX35m0wo1BD3c06QIXC5c/qs X-Received: by 2002:a17:907:28c2:b0:a26:a4bd:9ded with SMTP id en2-20020a17090728c200b00a26a4bd9dedmr865001ejc.90.1704456406208; Fri, 05 Jan 2024 04:06:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704456406; cv=none; d=google.com; s=arc-20160816; b=cyRRld8scPjDpTD+H37MVmVZ3BCAOTN1ReZJS9I4iErAIXAbRe0csRjXSfhLkGUE5g CJRU/BZqGAjwOKFUYclhOvVowvCKzhGBHtSVXXvs8za4q3NMUrHnIXr6gJ+15v9xYCTr WyM9+/JekSveLdEl0Jek6RROCrXYUlM+9qD/licOkBNL/BSQrJdsrTruT/e7kQbhQvBB Zc7LGj5SqB7X3GN9EN7hR9+wMaEPQNA6ZDDXRQZod0Tupj9ooS0yOpTAkdKxaJr0Gbct rFg9TnMyQaQRSz9eXgCVjB+fV5zcSPpmYHUXS/5beu0xcUzURDF2Ktov0k7o1WG8OlDj NhFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/t+4QZVzou6lGZdFB2I8Kdi0kIffmCbPVyQVve9cYLk=; fh=xMDRHasd5Mw/WSZpkMRdaoUTIVU7/Ywkc/ryue/PXvo=; b=SejHFt0u6spDuME3k3oe8AAyZuuQKk9vwlCPgdctJEpvFlocbHMDRjA5nuti3dai0l M7AGEOBBqBtY7M+JIpQFf5RvoWKPu3MrMEJ46UAtk6ysCnGpA4LW02Ll/8YZnpJD54Ul CCBd0IrCct233qrVx+Wqne9zzCPWkAcgJMylpERp3bj2qycFeABmPGIYUYSWwT4ZCf2s myU2AKNjKDKbCTC9Wd/IuAN2JKbSy/CvHC02ZyVlW6A6S8Jm5gPKSAnji6+hl7rlnNmU PGJIhWg6B3PkIiZG7onAw4z9uOpcxYEoLY4dbCOvJxj3PAkkT0h3wjWzLKBp1/lBV6Y1 AyCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y0mWOKyk; spf=pass (google.com: domain of linux-kernel+bounces-17824-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17824-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 14-20020a170906224e00b00a294940ab67si377469ejr.414.2024.01.05.04.06.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 04:06:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-17824-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Y0mWOKyk; spf=pass (google.com: domain of linux-kernel+bounces-17824-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17824-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id F0C161F22A5A for ; Fri, 5 Jan 2024 12:06:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7C1AC2D042; Fri, 5 Jan 2024 12:06:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Y0mWOKyk" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95F762D601; Fri, 5 Jan 2024 12:06:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2588C433C8; Fri, 5 Jan 2024 12:06:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1704456396; bh=771cJmS/QvQZS5wH+fF4qF6c0Cu3brr3xJExwpIAORc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y0mWOKyk8NrVUi8/jFJtBL/mFSCUoIVGYI8Eapi3GsoO+FQWFrgEiicQwN+VzA4o5 t69q71kbLGk8B1m7GJEJunGvK8BRInjboGoSpMkDy2XAQ3yvpT9KCg9Po78WimY91d gMyuIAjzU6EyQsLazYhIgwzo8jcQ2XySjA7cXAtw= Date: Fri, 5 Jan 2024 13:06:33 +0100 From: Greg KH To: Niko Mauno Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jaaskelainen Vesa VEJ Subject: Re: [PATCH] usb: core: Make default authorization mode configurable Message-ID: <2024010518-embattled-illusion-9a13@gregkh> References: <20240104163203.7381-1-niko.mauno@vaisala.com> <2024010413-portable-lingo-3c11@gregkh> <522eb2bb-95d0-4e2f-a426-9347f14f51cb@vaisala.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <522eb2bb-95d0-4e2f-a426-9347f14f51cb@vaisala.com> On Fri, Jan 05, 2024 at 01:56:35PM +0200, Niko Mauno wrote: > On 4.1.2024 18.41, Greg KH wrote: > > On Thu, Jan 04, 2024 at 06:32:03PM +0200, niko.mauno@vaisala.com wrote: > ... > > > + The available values have the following meanings: > > > + -1 is authorized for all devices (leftover from wireless USB) > > > + 0 is unauthorized for all devices > > > + 1 is authorized for all devices > > > > What's the difference now between -1 and 1? We don't have wireless USB > > anymore as that never turned into an actual product, so we shouldn't > > reference it anymore, right? > > > > We should get rid of the -1 option entirely, but keep the module option > > and properly map it to '1'. > > > > > > > + 2 is authorized for internal devices > > > > Needs a "if you don't know what to select, please choose X" text here. > > Thanks, submitted v2 which strives to address also these considerations. Much better, thanks. I'll look at them after 6.8-rc1 is out. greg k-h