Received-SPF: pass (google.com: domain of linux-kernel+bounces-17834-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 5 Jan 2024 14:36:20 +0200
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Roger Quadros <rogerq@kernel.org>,
	Javier Carrasco <javier.carrasco@wolfvision.net>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tipd: fix use of device-specific init
 function
Message-ID: <ZZf2lhtRdmIHmlBq@kuha.fi.intel.com>
References: <20240104-dev_spec_init-v1-1-1a57e7fd8cc8@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240104-dev_spec_init-v1-1-1a57e7fd8cc8@gmail.com>

On Thu, Jan 04, 2024 at 06:07:12PM +0100, Javier Carrasco wrote:
> The current implementation supports device-pecific callbacks for the
> init function with a function pointer. The patch that introduced this
> feature did not update one call to the tps25750 init function to turn it
> into a call with the new pointer in the resume function.
> 
> Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data")
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

This was suggested by Roger, no?

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tipd/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index a956eb976906..8a7cdfee27a1 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -1495,7 +1495,7 @@ static int __maybe_unused tps6598x_resume(struct device *dev)
>  		return ret;
>  
>  	if (ret == TPS_MODE_PTCH) {
> -		ret = tps25750_init(tps);
> +		ret = tps->data->init(tps);
>  		if (ret)
>  			return ret;
>  	}

thans,

-- 
heikki