Received: by 2002:a05:7412:98c1:b0:fa:551:50a7 with SMTP id kc1csp118808rdb; Fri, 5 Jan 2024 04:53:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IHWhQ2QX5pMHGfxesjGd6/o3xCXUaDjNvokW0ZZoCBNNr191rpY4gDSrVYMKwRQTBrcMRcO X-Received: by 2002:a05:6808:208e:b0:3bc:25c3:c11b with SMTP id s14-20020a056808208e00b003bc25c3c11bmr2425546oiw.24.1704459202089; Fri, 05 Jan 2024 04:53:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704459202; cv=none; d=google.com; s=arc-20160816; b=TaPzGyVk7G+Kb2qzcVP7xrecY2DlHPYV3rW6pLd+vs8IAnlqYvLgVtyt1lAd8x1EBY 58Xklagh4UUz4fiHgONvGyvJmZJfVyB2/N4C6b/ihEyBhfTsYkpooHF6JG0rPgWzkNZc rDfpCQAP0ToSHt8k/2hGQ62IGp6V5k02AbuWw/GA9zoDVfSmeMl/yo4CJy2+e9ttUOup +KxujIFViTakwD1JS/TuV83A4UnYLCCyYv8v788HryBZXg7JNUzgd45gyT9/EaENmgZl 29XkRh7jnqzg2kZCEKLaNmGUvHSolZdDjLBtsKUJAIqz1AJMS9E3weEfUcgV7XnXBUP+ ubSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2an2Pv/qCauQsRBnQpa5u164onzZnBQGOP53Zr8SgZQ=; fh=n1WC7Kckwd81ExfDh+8q2FyCDP4Zm0aZNdGiQ2+o9Jc=; b=aiKg74zcPWL/7L8aMUmHzTlTkUKb7CgV9tb3C8YnhS//W5H1/+E0ITmH09nrriWtPv NUdpFeuQZVS6fmt8IvWAp9nP4MKCfxJft0T5gNv7jXcm7CpmjGvp/EITnqW2kUrKg/U9 rXG0Bk5hPNuFw3GgYi2mYw3LE2arEk533+949UgmE1IctCME/jpIubn2KQh/BNNnBcR8 CCaEa2PiVQi/xbitwbDGii45jDLk1ldeQVTakmJNbQ6BqDnR0F8RrUStJ/89GQnMik9X V59GsNJfwIIrrDID3qtOwKhr87/eIeLAzAzt/UDYLjzyaA+7cPROBi+iPIBSKKzv5S/Y XBcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wew1HBWw; spf=pass (google.com: domain of linux-kernel+bounces-17844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17844-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id z1-20020aa78881000000b006be0f482c0fsi1288885pfe.63.2024.01.05.04.53.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jan 2024 04:53:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-17844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wew1HBWw; spf=pass (google.com: domain of linux-kernel+bounces-17844-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-17844-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 7B796286ACE for ; Fri, 5 Jan 2024 12:53:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 077B02D611; Fri, 5 Jan 2024 12:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wew1HBWw" X-Original-To: linux-kernel@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 351012D602; Fri, 5 Jan 2024 12:53:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60CD3C433C9; Fri, 5 Jan 2024 12:53:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1704459191; bh=/OKCBDu+sT7dZNqDjiKljP55Xl6ozfTj6H60TBI/UN8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wew1HBWw+Fwxi7TpcBJnT1OOVbtF1F4GkUOKrqJbWkamrdDOOlXOEGuQ6luQp1Foi 8jOa7NZzF1z4hhNgVz6dCLuzkguBr7DmL0RN2mtNgmn0mZrHNQlDXmSOD8wFVLtOjW 8fktZJFfYD+APqBQ+dOEBXomSveJlFIW+2XQbgzw= Date: Fri, 5 Jan 2024 13:53:09 +0100 From: Greg Kroah-Hartman To: Javier Carrasco Cc: Heikki Krogerus , Roger Quadros , Javier Carrasco , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: typec: tipd: fix use of device-specific init function Message-ID: <2024010558-unhappy-scandal-b823@gregkh> References: <20240104-dev_spec_init-v1-1-1a57e7fd8cc8@gmail.com> <56a15164-dbce-4740-b59e-b566f613f878@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56a15164-dbce-4740-b59e-b566f613f878@gmail.com> On Fri, Jan 05, 2024 at 01:42:47PM +0100, Javier Carrasco wrote: > On 05.01.24 13:36, Heikki Krogerus wrote: > > On Thu, Jan 04, 2024 at 06:07:12PM +0100, Javier Carrasco wrote: > >> The current implementation supports device-pecific callbacks for the > >> init function with a function pointer. The patch that introduced this > >> feature did not update one call to the tps25750 init function to turn it > >> into a call with the new pointer in the resume function. > >> > >> Fixes: d49f90822015 ("usb: typec: tipd: add init and reset functions to tipd_data") > >> Signed-off-by: Javier Carrasco > > > > This was suggested by Roger, no? > > > > Yes, it was. Thanks for the reminder. > > Could the following trailer be added before applying? > > Suggested-by: Roger Quadros The tools automatically just added that now, thanks. greg k-h