Received-SPF: pass (google.com: domain of linux-kernel+bounces-17886-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <09d009cd-6366-4372-9534-4c637c56b3d7@amd.com>
Date: Fri, 5 Jan 2024 20:39:56 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH 3/6] iommu/amd: Introduce Guest-ID struct
 amd_iommu_vminfo
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
 "joro@8bytes.org" <joro@8bytes.org>, "jgg@nvidia.com" <jgg@nvidia.com>
Cc: "Liu, Yi L" <yi.l.liu@intel.com>,
 "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
 "eric.auger@redhat.com" <eric.auger@redhat.com>,
 "vasant.hegde@amd.com" <vasant.hegde@amd.com>,
 "jon.grimm@amd.com" <jon.grimm@amd.com>,
 "santosh.shukla@amd.com" <santosh.shukla@amd.com>,
 "Dhaval.Giani@amd.com" <Dhaval.Giani@amd.com>,
 "pandoh@google.com" <pandoh@google.com>,
 "loganodell@google.com" <loganodell@google.com>
References: <20231212160139.174229-1-suravee.suthikulpanit@amd.com>
 <20231212160139.174229-4-suravee.suthikulpanit@amd.com>
 <BN9PR11MB527634DAFBBACC20DD691DD58C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
From: "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <BN9PR11MB527634DAFBBACC20DD691DD58C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TCtCZk8vTi94Q1d0T3c1YkNDY0YxRk5WTWFsZHkrK1lQT1FXYnlpRzBSL29Y?=
 =?utf-8?B?NDFyWkordS9TRWRHTEd6aW4vRHd1bFZQMDFNUE9DRnNoRHlwTTlnR28rd2Z3?=
 =?utf-8?B?UzRxbzJiK01qZ0Z6UnB0OXdkV1NGK0d1WEVVRHR1cmhRTkRaWU9oNG03MDI3?=
 =?utf-8?B?QTB2NGZvcldsTmhsdE1Ldlc1akZsOVI1Rk9QWGhFazVzaExrT2hnYnNEVDR6?=
 =?utf-8?B?Y3hGc1hkeXRCQnJ5dTlJN25ySERFRWNXODY4SmljeXpESVI1cFpYWFlnVEs2?=
 =?utf-8?B?VW9nNGVRcGZzeXhueXNFVEcyYWV1ZWtESDhhZHlzanVWK1J1WnhjZ1cyZDVp?=
 =?utf-8?B?bjRJakNSZCs4MTJrTGFNUDFtczBIK3hIS0xUR0NFdFNNYnU2QkduWUgwSkVU?=
 =?utf-8?B?L1hwSCt3MWF1UTNkZjdRc1czWERWcUIxODhodHZUM2UzK1RTV2s5VVdZS3hO?=
 =?utf-8?B?TTdTQkVuUVVuL0dkZEpxSDVTTVhkTFZFSTdRcmM5MlFNaVZneFoyTTNNd3Ba?=
 =?utf-8?B?dURPdzdiUjl5cDNKeW1Bd2d3QkhlSEFjZFFxMzJQdll2QXRxT2Q0NndaWW5I?=
 =?utf-8?B?emY2K0JoRU9RckpWYS9QelBvb2ZpMVdETmlQbGJ4RG1oSkhubDhBTkdJY3kv?=
 =?utf-8?B?bVhzZGdFUXhTa2t2SURSRk1wQk03UThncEZWZjdYWDNRaTMyRHhwUHpMaldH?=
 =?utf-8?B?S2w1bGU5V3NvUWpXSnJidms0M2IwWGEwN1lhdHYwNERHdVVrMTlrdU5NRjN5?=
 =?utf-8?B?Z0MxOGg5WUp6OFZHMWtVZDhUakhhaTRzb2h1OXdINEdNT2xoOHJQQ2plOXJN?=
 =?utf-8?B?cDE3clU5eUVjTmE5Q0wwY0k3QUtYeFdUblhGSlB4NnVjUmlLTjRxZWJHZWRE?=
 =?utf-8?B?M3hOa0ZjSnp5MGVjTGxMN2I1dTZaTTFEdk0zbGNPUWliZHVqQklYQXA5S25B?=
 =?utf-8?B?UU9UcTV4b1l3S0lnQjY5Sks3bGpZdmsvQkQ0b2VOM0JCOGczMkVNdnhGbzFy?=
 =?utf-8?B?VytjT1ZyM0xrTk5wZXNnblVsM0hYcmJxNk9LQndyYnQ5VjVtMnhvWVNlMHJw?=
 =?utf-8?B?Snl2c1NMUlJYY2FKd0U2ZFBpSk5EV1BMMzhaUnFiNjhWNmVvOFdycExPYUw1?=
 =?utf-8?B?dHVlbXZtVXRUSVJaalgrY29aZ1FZZCs5dDBNRE1iWTBwdkxQa1BrKzJOY1dn?=
 =?utf-8?B?MHZ5eVpoQVBrQ2s2QnlPU080Ym41VVl0MDZydFJISjczOGw5cFljUW9Hb25L?=
 =?utf-8?B?TU1Ya3dvdTFMd3gwWjM1SWIydldKdDk5ZXUxUm45VXNNZUpQajZPU2hqZEQw?=
 =?utf-8?B?dGVoSGhzWlRnNC9TeFJLMTBkM1E0ZWdQSUh2U0NvVXoxNUUyRm1YaHNoV1hN?=
 =?utf-8?B?S2ZBVUNPa1NhVER1dUZEODV5Y1VXakhMOGFBUDJ4NTJwU3pqVmhnL3g1YnNT?=
 =?utf-8?B?aDZFeXlYSTJoN2QwNnIrdDhjMUhEY3BwNEg2bFNUMzdlQ1FKQWFlWDExM3Vt?=
 =?utf-8?B?TTZlQnBwVDlQZ0hMQ3kwOFNwL2R1UWM5Z2tTQXVxYUtyQVRpYVV5V01Od2JK?=
 =?utf-8?B?SzBQMjd4MFFUdUZTeE5EU0Z1SXNRR1U0UHFuNG9mTVpIVlFpUUhBOW5QNERM?=
 =?utf-8?B?WEJ2aU9hTlUxS1VpQW5Ib3pYbGpjdXZNeVE4cXFtZVBWUUpxcnppV2dPT0tx?=
 =?utf-8?B?VW15aUZnQ2sxYjVObjZUb2xtTjZJdTJBYTIyd2d4Vll6b0tjbHZOVHB5MWcx?=
 =?utf-8?B?R29KQjhreTVqdmN2dXoyMkN5UUluV2V6aGFYT3hra1BRbkdScys1QnNNS29l?=
 =?utf-8?B?VHFOak9ReEJ0VDNJUE9tK3UwcERPMnJwWWdiano3TDhjeWt1Nkc4TTFyVlJn?=
 =?utf-8?B?VHp0QXBPKzZXa0RDK0RuVEUxS1o1NWlxZFVTNUxFNFVDS21wc0FEdzF1SFZE?=
 =?utf-8?B?bFE4Y1hMYVVaQm9nc244dGl3czg3bVFUb2NGT0ZqVW04S3RPL0dkdGNBdU5T?=
 =?utf-8?B?SDFHY0xVTGgvVWJYNllObmQyR0NKZCs2bzRHSUV0M0FzY0UzK25OWTA2WHMx?=
 =?utf-8?B?OFFPZ3VabTZwR3hETkl4bTdQU21pMWNMMTVqeTBkRS9pQUtoZGRYN2k3WEpU?=
 =?utf-8?Q?eGDqdSd+l3CBzVqQHavRdwaaU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 55bd52fc-b78d-4ece-11a9-08dc0df3d377
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 13:40:05.7194
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tNZH42vipGRCGChTMymbrXtvtvnZAcl3Tnr0OomMAgaAGPRXvhaUFBzR8XQp/6aT+yjH2RY+eINRuYJ5eEu4Bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6233

Hi Kevin

On 12/15/2023 2:35 PM, Tian, Kevin wrote:
>> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>> Sent: Wednesday, December 13, 2023 12:02 AM
>>
>> AMD HW-vIOMMU feature requires IOMMU driver to specify a unique 16-bit
>> Guest ID (GID) for each VM. This ID is used to index into various
>> data structures for configuring the hardware.
>>
>> Introduce amd_iommu_vminfo_hash hashtable to store per-vm
>> configuration,
>> which uses 16-bit GID as a hash key along with helper functions.
>>
> 
> somehow it's unclear to me whether this series is only for hw
> supporting vf or broader hw supporting nested capability. for
> the latter case is GID still necessary?

I am restructuring the series and might be moving GID stuff until later 
when introduce broader hw support for AMD vIOMMU.

Suravee