Received-SPF: pass (google.com: domain of linux-kernel+bounces-17887-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <e480bcc9-f13c-4172-b4d3-e025e14790b1@amd.com>
Date: Fri, 5 Jan 2024 20:40:06 +0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH 2/6] iommu/amd: Add support for hw_info for iommu
 capability query
Content-Language: en-US
To: "Tian, Kevin" <kevin.tian@intel.com>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
 "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
 "joro@8bytes.org" <joro@8bytes.org>, "jgg@nvidia.com" <jgg@nvidia.com>
Cc: "Liu, Yi L" <yi.l.liu@intel.com>,
 "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
 "eric.auger@redhat.com" <eric.auger@redhat.com>,
 "vasant.hegde@amd.com" <vasant.hegde@amd.com>,
 "jon.grimm@amd.com" <jon.grimm@amd.com>,
 "santosh.shukla@amd.com" <santosh.shukla@amd.com>,
 "Dhaval.Giani@amd.com" <Dhaval.Giani@amd.com>,
 "pandoh@google.com" <pandoh@google.com>,
 "loganodell@google.com" <loganodell@google.com>
References: <20231212160139.174229-1-suravee.suthikulpanit@amd.com>
 <20231212160139.174229-3-suravee.suthikulpanit@amd.com>
 <BN9PR11MB52767952B60E86FD6C93CB1D8C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
From: "Suthikulpanit, Suravee" <suravee.suthikulpanit@amd.com>
In-Reply-To: <BN9PR11MB52767952B60E86FD6C93CB1D8C93A@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?ZnAwandjNWZZclZvRHhxRkhhZjBJOWVOcmU1M0FLN1VrR3R6VjlINHFNZ2FH?=
 =?utf-8?B?bXFpVjcyRldhM2UwdDFyUzF3aGU2QTJwSWpWSzU4VW53UXNuSm5jbFd5UHp5?=
 =?utf-8?B?SnNCMmp1cnN0a2JKdXNpaTVSWmkvYzFtb3ZaUVBjbHk4NjBVa2VWSjMzQXF2?=
 =?utf-8?B?a25NcllHRk4zQU9LVGlaSzNqTUVlZzlaOC9JZ2FxTksvYkFCdERDSWR2V2FN?=
 =?utf-8?B?N1NLQ3pQdGYwWFUrWW9kaUV3VmcrWDl2Y3JkOUg0QmlrMDlBTUcvSVBjK1Nw?=
 =?utf-8?B?ZzVJNkJuZGhFbnl6SS84b1BYRnAxWkU3cU0ya1VmVm8rQmhPZFlZSmhTUW0w?=
 =?utf-8?B?b3dtd2Rib1hXWmt5anFyR1hVV0JFcGtYT1l3VGFKR0lrYldyL3FzVWlidmxa?=
 =?utf-8?B?YWlMT3dJbE1SZTBIV09iN1BvMUdkMWtoWTFjZUZIajd2MDQwZ08vU3R1L1lp?=
 =?utf-8?B?Rk4vN0dEK0xlL21IaGwzblcvZXZZWXZMNm1IQnFIbUtoTW5kdVAwNTNyYzdx?=
 =?utf-8?B?eThiRTJJSzFGVzl6TC9Dbi81blF4U3p1NzdLK0d0QnNlSXREMlRtR01MZmw1?=
 =?utf-8?B?ODJYdmJBUHRBcmp2RVdRWXNmNWJyYnVlZzgwZ2VUQ2J0RGYzb1F0ZEdnMzZC?=
 =?utf-8?B?Uno5N3VMVW5GVFpsei9LZTFGU3RrZVlLVlVQeTJPa1Y3VlEzUjlSeW1ydkRY?=
 =?utf-8?B?emgxYWRicFBVNGg5K25FcTJGekVadlFtUWtjRjB6NTYwb0pRNXY3dW0za0Qv?=
 =?utf-8?B?TU56amlRR1Z1VDBvTzNIYlZPUUVJOHFYdVprMXlDZWhycGI4T0g0b1UvSHBx?=
 =?utf-8?B?QWJkZi9LVkJndGNOaWRTYjJpM05FWWkzWE1oZS95UFMyeitsekFsSTNRNldW?=
 =?utf-8?B?cjlKRThZZ01SYzBBRmFJQ0NCYzAzakdYN2txaC9iWUhUdnc1aG1PTXRGNW8z?=
 =?utf-8?B?LzhVUjFnZFpIaXhNUHlLOXBOYmFCdDNPbkFrQ3RJT2I5QnZZUm5MUnl3VkRp?=
 =?utf-8?B?MHFXYVc4bnYxQUtnR0haK2wwK2dUZEVZWm0yYzhJb3FhZnAyK29VK1RFTWph?=
 =?utf-8?B?L2VJRkhBcVkvWFJQYUlFTjhvSVYwc0J2eFNzWUQ4UEdTRjJUaTFIbDg3Um5T?=
 =?utf-8?B?RFJnbWd1ak0raVJuNDN0TWEvMVZjM3hmT0pyRXEyRDkrMUxDVzZKT0N4RHND?=
 =?utf-8?B?ZkJKVDJQVHZWTGVkNkJBamhvdktJdWhoZ1JxdUFzUk9kYTZHTmxVY1UweS9v?=
 =?utf-8?B?U0xsR3pKOHVMWVllZFRHSC85Zzl5UDhLcnpld09wUzlsa3lhMkJrK3I2cTBS?=
 =?utf-8?B?ekVPbThQNjJncXB6SUlLSnozRjJkODFnTEVKQjRlL0FpLzNoVHpGTmVQVUw4?=
 =?utf-8?B?MDJGNm1PakQrNWdaMi9jWUVDTEpUU04wQ0FzYWZlaXFVVkRYU2YwRk9neUhY?=
 =?utf-8?B?cUdqRWU2LzFkZTR2enBkdGVhbSthRTZLYmlZL2tOTURCQ1ZQSEVMWGMydXow?=
 =?utf-8?B?djhkK2pIVUpleDZhSEo3d2U1VDZPeTRKNExrSG5mTDYvU29GYmhqZ1VvWmlH?=
 =?utf-8?B?RURReE5qbmRuKzNvLzM0N3hlV0dVYldzUG0xNm80elZYUUV4NHBKZER6YXh5?=
 =?utf-8?B?eTNwR0pnZFo5T3dPa3ZYemNFUEZQbkVpQTlCb0xXNEMwVHBUTFJjUVJkK0NB?=
 =?utf-8?B?Y2RuWitIM3Z3cG9kWFNDZXhab0d6bXl5SDNLVytlSWhyampIa0V4QzFrQnFP?=
 =?utf-8?B?WmJ6T2RPL2YwVE9uOHIvSkxmTkFyY1pDRDVCTWRZNysrQTVtbkRUMGdNWkt3?=
 =?utf-8?B?Ky93bTNDOTNnRy9ZeXVYaGR5WjNXRzVpZTJyR2xJc1lVMGMyejg0UkpYdHJK?=
 =?utf-8?B?eGNPdmlxWjRUQ0pBRktZQXowOENOMkg0aUNDZVZSc0o4UmlmM2FhOE1iRWNC?=
 =?utf-8?B?M0xzWnhqSmltVVNic3lEZnR5SERZQVcwOE83SU9Bb2ZZWkJwSWJPelEvdFdq?=
 =?utf-8?B?UWI3Sm9PRUNZamtodlkzaWdVbUtvejAyRWFBZHMzUlk2NTZjVVpMVEJRdVhq?=
 =?utf-8?B?TVk0THp0TWNZbGY0dEVEUmlDZVZNTE9TcTBmalNxTit0WVlXTHkwU3p1RG9D?=
 =?utf-8?Q?+ZH7b8i/mlrHvBKwrSF/jraqy?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25f25879-0eba-4855-9992-08dc0df3d69a
X-MS-Exchange-CrossTenant-AuthSource: DM8PR12MB5445.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 13:40:11.2042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZP/7DgRH0fTBlH8ZGklr7JxaWzkAqz54h+aysGkD+9oG/JMVy7zsYNbrrtASJEXGcgaq+RimNiw9ddb7gym6jA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6233

Hi Kevin,

On 12/15/2023 2:32 PM, Tian, Kevin wrote:
>> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>> Sent: Wednesday, December 13, 2023 12:02 AM
>>
>> +void amd_iommu_build_efr(u64 *efr, u64 *efr2)
>> +{
>> +	if (efr) {
>> +		*efr = (FEATURE_GT | FEATURE_GIOSUP | FEATURE_PPR);
>> +
>> +		/* 5-level v2 page table support */
>> +		*efr |= ((FEATURE_GATS_5LEVEL << FEATURE_GATS_SHIFT) &
>> +			 FEATURE_GATS_MASK);
>> +
>> +		/* 3-level GCR3 table support */
>> +		*efr |= ((FEATURE_GLX_3LEVEL << FEATURE_GLX_SHIFT) &
>> +			 FEATURE_GLX_MASK);
>> +
>> +		/* 16-bit PASMAX support */
>> +		*efr |= ((FEATURE_PASMAX_16 << FEATURE_PASMAX_SHIFT)
>> &
>> +			 FEATURE_PASMAX_MASK);
>> +	}
>> +
>> +	if (efr2)
>> +		*efr2 = 0;
>> +}
> 
> Don't this need to check the support in hw?

Ah.. Good point. Let me add check for the support for these features in 
the actual hardware.

Thanks,
Suravee