Received-SPF: pass (google.com: domain of linux-kernel+bounces-17964-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 5 Jan 2024 16:48:17 +0200 (EET)
From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To: lizhe <sensor1010@163.com>
cc: Jiri Slaby <jirislaby@kernel.org>, 
    Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    linux-serial <linux-serial@vger.kernel.org>, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re:Re: [PATCH v6] serial: linflexuart: Remove redundant uart type
 assignment
In-Reply-To: <7a49d3a4.1e16.18cd8564671.Coremail.sensor1010@163.com>
Message-ID: <ee52b724-799f-1be5-b455-8e82aba55ee2@linux.intel.com>
References: <20230105170437.4437-1-sensor1010@163.com> <67a7681a-ca4a-0ac7-97b6-2c7db8f2bb3c@kernel.org> <7a49d3a4.1e16.18cd8564671.Coremail.sensor1010@163.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1854983850-1704466100=:1746"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1854983850-1704466100=:1746
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT

On Fri, 5 Jan 2024, lizhe wrote:

> HI，all
> 
>        How should I wirte these comments ? please help me, 
>        i am not sure how to properly write these comments, 
>        i want to merge this patch into the mainline
> 
> 
> 
> 
> 
> 
> At 2023-01-06 15:16:56, "Jiri Slaby" <jirislaby@kernel.org> wrote:
> >On 05. 01. 23, 18:04, 李哲 wrote:
> >> in linflex_config_port() the member variable type will be
> >> assigned again. see linflex_connfig_port()
> >
> >I wrote to v5:
> >Please use capitals when you start a sentence. And periods at the ends 
> >of them.
> >> Signed-off-by: 李哲 <sensor1010@163.com>
> >
> >
> >> V4 -> V5: Link: https://lore.kernel.org/all/ddcf396b-7b91-00f3-8c16-7de5d
> c891aef@kernel.org/
> >> V3 -> V4: Link: https://lore.kernel.org/all/2f726128-29c-b7dd-ad8-f8b536f
> be5f@linux.intel.com/
> >> V2 -> V3: Link: https://lore.kernel.org/all/8f433e5-fb46-d3b8-431b-4bddcc
> 938f6b@linux.intel.com/
> >> V1 -> V2: Link: https://lore.kernel.org/all/1c33a2af-cd0d-cdde-5bc7-49b41
> 8665784@kernel.org/
> >
> >This is not the proper way. PLease see:
> >https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-
> canonical-patch-format

For this you need to spell out the changes you made between versions.

E.g.,

v6:
- Used Chinese letters for From and Signed-off-by


-- 
 i.

--8323329-1854983850-1704466100=:1746--