Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758677AbXLLMDS (ORCPT ); Wed, 12 Dec 2007 07:03:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751052AbXLLMDI (ORCPT ); Wed, 12 Dec 2007 07:03:08 -0500 Received: from mailout.stusta.mhn.de ([141.84.69.5]:39768 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751899AbXLLMDH (ORCPT ); Wed, 12 Dec 2007 07:03:07 -0500 Date: Wed, 12 Dec 2007 13:03:09 +0100 From: Adrian Bunk To: Mauro Carvalho Chehab Cc: Shane , Brandon Philips , linux-kernel@vger.kernel.org, video4linux-list Subject: Re: 2.6.24-rc5 "videobuf_read_start" [drivers/media/video/videobuf-dvb.ko] undefined! Message-ID: <20071212120308.GG14204@stusta.de> References: <20071212090709.GF14204@stusta.de> <1197457394.4807.40.camel@gaivota> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1197457394.4807.40.camel@gaivota> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1443 Lines: 43 On Wed, Dec 12, 2007 at 09:03:14AM -0200, Mauro Carvalho Chehab wrote: >... > I'm afraid that this wouldn't avoid this bug, however. > > The removal of the EXPORT_SYMBOL_GPL seemed to be the intention of > Brandon, since he renamed the function, removing the locks. I think he > didn't noticed that videobuf_dvb were using videobuf_read_start. The > patch I've just send fixes it properly. At least in the commit in Linus' tree, videobuf_read_start() stayed nearly unchanged. > Btw, Shane patch reveals a small trouble with EXPORT_SYMBOL_GPL: adding > the tag for a non-existing function didn't rise any error. See above. > IMO, it > should generate some compilation error, if you try to export a symbol > that doesn't exist at the file that is being compiled. It does give you a compile error when there's not at least a prototype for the stuff to be exported, and a link error if there's no variable/function. > Cheers, > Mauro cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/